All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nilesh Javali <njavali@marvell.com>
To: Bart Van Assche <bvanassche@acm.org>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	GR-QLogic-Storage-Upstream
	<GR-QLogic-Storage-Upstream@marvell.com>,
	"djeffery@redhat.com" <djeffery@redhat.com>,
	"loberman@redhat.com" <loberman@redhat.com>,
	Bikash Hazarika <bhazarika@marvell.com>,
	Harish Zunjarrao <hzunjarrao@marvell.com>
Subject: RE: [EXT] Re: [PATCH v2 01/10] qla2xxx: Add support for mailbox passthru
Date: Tue, 14 Sep 2021 07:15:12 +0000	[thread overview]
Message-ID: <CO6PR18MB4500AD57B2D53AD56F14B777AFDA9@CO6PR18MB4500.namprd18.prod.outlook.com> (raw)
In-Reply-To: <96a11a9b-fc55-0826-1970-b37b738c3c97@acm.org>

Bart,

> -----Original Message-----
> From: Bart Van Assche <bvanassche@acm.org>
> Sent: Wednesday, September 8, 2021 11:58 PM
> To: Nilesh Javali <njavali@marvell.com>; martin.petersen@oracle.com
> Cc: linux-scsi@vger.kernel.org; GR-QLogic-Storage-Upstream <GR-QLogic-
> Storage-Upstream@marvell.com>; djeffery@redhat.com;
> loberman@redhat.com
> Subject: [EXT] Re: [PATCH v2 01/10] qla2xxx: Add support for mailbox
> passthru
> 
> External Email
> 
> ----------------------------------------------------------------------
> On 9/8/21 9:46 AM, Nilesh Javali wrote:
> > +struct qla_mbx_passthru {
> > +	uint16_t reserved1[2];
> > +	uint16_t mbx_in[32];
> > +	uint16_t mbx_out[32];
> > +	uint32_t reserved2[16];
> > +} __packed;
> 
> Why does this data structure start with 4 reserved bytes?

Specifically, more than the driver, the reserved bytes would be used by the application,
and driver uses only the mbx_in and mbx_out fields to access 32 register content.

Thanks,
Nilesh

  reply	other threads:[~2021-09-14  7:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-08 16:46 [PATCH v2 00/10] qla2xxx driver bug fixes Nilesh Javali
2021-09-08 16:46 ` [PATCH v2 01/10] qla2xxx: Add support for mailbox passthru Nilesh Javali
2021-09-08 18:28   ` Bart Van Assche
2021-09-14  7:15     ` Nilesh Javali [this message]
2021-09-08 16:46 ` [PATCH v2 02/10] qla2xxx: Display 16G only as supported speeds for 3830c card Nilesh Javali
2021-09-08 16:46 ` [PATCH v2 03/10] qla2xxx: Check for firmware capability before creating QPair Nilesh Javali
2021-09-08 16:46 ` [PATCH v2 04/10] qla2xxx: Fix crash in NVME abort path Nilesh Javali
2021-09-08 16:46 ` [PATCH v2 05/10] qla2xxx: edif: Use link event to wake up app Nilesh Javali
2021-09-08 16:46 ` [PATCH v2 06/10] qla2xxx: Fix kernel crash when accessing port_speed sysfs file Nilesh Javali
2021-09-08 16:46 ` [PATCH v2 07/10] qla2xxx: Call process_response_queue() in Tx path Nilesh Javali
2021-09-08 16:46 ` [PATCH v2 08/10] qla2xxx: Move heart beat handling from dpc thread to workqueue Nilesh Javali
2021-09-08 16:46 ` [PATCH v2 09/10] qla2xxx: Fix use after free in eh_abort path Nilesh Javali
2021-09-08 16:46 ` [PATCH v2 10/10] qla2xxx: Update version to 10.02.07.100-k Nilesh Javali
2021-09-15  2:59 ` [PATCH v2 00/10] qla2xxx driver bug fixes Martin K. Petersen
2021-09-22  4:45 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO6PR18MB4500AD57B2D53AD56F14B777AFDA9@CO6PR18MB4500.namprd18.prod.outlook.com \
    --to=njavali@marvell.com \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=bhazarika@marvell.com \
    --cc=bvanassche@acm.org \
    --cc=djeffery@redhat.com \
    --cc=hzunjarrao@marvell.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=loberman@redhat.com \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.