From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 198B3C636CD for ; Tue, 7 Feb 2023 09:23:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:From:Subject: Cc:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hfmdaluj+tZWlYWda6zQYMsUPejA+ioT11yOfbKc+pw=; b=ftt7D3tzIpqDik Tjl3IeYToIMzYcc0V88rP2DWZWMdfYrpFjG6aF68DPZUG3pYuwRn7LZZGMd9wl+jb/mcZhDMwKNmp d/J9remJ2jj5gd0+8WwzMdalt/NQ2WSpZRQcZqOXTMkcylLwL9gDGDX6dhAv3FZaWVMBc0lsIaNSm OBdFybp9TFuONunDnyJKk0EYzLKsRvUkultDRq02LTiJHjy+oEuOTpspxgOeBF2jmU/zGglBTuuSR +nEYfQ4YgvEUi/k8HbM2yTQgEkPwOR8nNOmuKdGA0RtdMISqlVKT88qCdmimGd/4sUQKMnwfxPMOz CozgIy5EILkYfUcGsycw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPKCA-00BScB-Rk; Tue, 07 Feb 2023 09:23:22 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPKBy-00BSY8-LU for linux-mtd@lists.infradead.org; Tue, 07 Feb 2023 09:23:14 +0000 Received: by mail-ej1-x634.google.com with SMTP id ud5so41537120ejc.4 for ; Tue, 07 Feb 2023 01:23:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=I70HhxHLsI2HHGcZI04fStNVNeSuevhKRqsln0/FI/A=; b=yrMGmfrMG5RKmVutlzGybx2TOoPNybxgeoFTGv81EX+SrqeMxTBh6j1swNcISVyw+p AgxQ+dFKkqs4M+u7dP5WPvcw6t/6BiMCzK+bOyEBzFiotz/5L2G3eEMdJFEYX4+4bwpJ Z0MRw+rSaCVL7tO3EKomyzEQp/H7CkFnKCW7+mzsAR0ABkwjVvW9n6FRXkKWS8OtlSVW 0GnttzP+aRl1UBX6dKSXSyf58HWn/JgZXGprVJzROGcIll13KS+KQKtI+car/sh4sQk3 i7b90CA7JynTrQkutLlEKl4SxpFEHmuY9HM0fTBVmDHIJUDDQFwDmwPsvnJidHbLmfFO CVaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=I70HhxHLsI2HHGcZI04fStNVNeSuevhKRqsln0/FI/A=; b=znEtk6sLpIljTBSKiMvCl9jQ3CuvK/cyaCPNnWyNYX2PwrsGSg7qNgixJ7Z0b40fgD qWWxktDfa6LDbJt+OGZnxIYauonIRlNiEAd33xN7ppoCwV9ZJoslpNB672BwUf+N/IeQ rXng7Wd2vXKUH3DRz4IIVWDhJsEDueIQyCrEuhTJcPqGsu5Yu2lqxeGHXbFb4Wldqg2h 6P0oBtAKqqBM76L8DNO0oivOZyBpd+s271h/q2iVAiT67bJyUEsvD/HHos5/Jb6EDDo0 bpi7zRZmYE+AjnCg+/rtTCcVLOGQK2NXFOVZGXoV+KLzbL5vNP3UyDjL0pJubsLrPckP Odgg== X-Gm-Message-State: AO0yUKXPzWbnIwt8G0pi+r1G58w7MB9trsuFmaQCv0D1k6D8FKY8W2Es erC4D+P2qluo2U5rORb/GnDSoQ== X-Google-Smtp-Source: AK7set/4jc5ZZLArDJD4G8kQ0dT4ezIRyv/eZI/G0ee7KmVpY7u9jRJrKjLsy6MxGRs020d764r0jA== X-Received: by 2002:a17:906:448c:b0:88a:4a22:dd5 with SMTP id y12-20020a170906448c00b0088a4a220dd5mr2585928ejo.23.1675761787520; Tue, 07 Feb 2023 01:23:07 -0800 (PST) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b00882f9130eafsm6599467ejb.26.2023.02.07.01.23.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Feb 2023 01:23:07 -0800 (PST) Mime-Version: 1.0 Date: Tue, 07 Feb 2023 10:23:06 +0100 Message-Id: Cc: "Abel Vesa" , "Alexander Stein" , "Tony Lindgren" , "Geert Uytterhoeven" , "John Stultz" , "Doug Anderson" , "Guenter Roeck" , "Dmitry Baryshkov" , "Maxim Kiselev" , "Maxim Kochetkov" , "Colin Foster" , "Martin Kepplinger" , "Jean-Philippe Brucker" , "Vladimir Oltean" , , , , , , , , Subject: Re: [PATCH v3 00/12] fw_devlink improvements From: "Luca Weiss" To: "Saravana Kannan" , "Greg Kroah-Hartman" , "Rafael J. Wysocki" , "Sudeep Holla" , "Cristian Marussi" , "Linus Walleij" , "Bartosz Golaszewski" , "Thomas Gleixner" , "Marc Zyngier" , "Shawn Guo" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "NXP Linux Team" , "Miquel Raynal" , "Richard Weinberger" , "Vignesh Raghavendra" , "Rob Herring" , "Frank Rowand" , "Geert Uytterhoeven" , "Magnus Damm" , "Andy Shevchenko" , "Daniel Scally" , "Heikki Krogerus" , "Sakari Ailus" , "Len Brown" , =?utf-8?q?Rafa=C5=82_Mi=C5=82ecki?= X-Mailer: aerc 0.14.0 References: <20230207014207.1678715-1-saravanak@google.com> In-Reply-To: <20230207014207.1678715-1-saravanak@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230207_012311_572262_AA6609FB X-CRM114-Status: GOOD ( 28.74 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue Feb 7, 2023 at 2:41 AM CET, Saravana Kannan wrote: > Naresh, Tony, Abel, Geert, Dmitry, Maxim(s), Miquel, Luca, Doug, Martin, > Jean-Philippe, > > Can I get your Tested-by's for this v3 series please? Hi Saravana, Seems to be alright on the same platform where it broke previously. Tested-by: Luca Weiss # qcom/sm7225-fairphone-fp4 Regards Luca > > Vladimir, > > Ccing you because DSA's and fw_devlink have known/existing problems > (still in my TODOs to fix). But I want to make sure this series doesn't > cause additional problems for DSA. > > All, > > This patch series improves fw_devlink in the following ways: > > 1. It no longer cares about a fwnode having a "compatible" property. It > figures this out more dynamically. The only expectation is that > fwnodes that are converted to devices actually get probed by a driver > for the dependencies to be enforced correctly. > > 2. Finer grained dependency tracking. fw_devlink will now create device > links from the consumer to the actual resource's device (if it has one, > Eg: gpio_device) instead of the parent supplier device. This improves > things like async suspend/resume ordering, potentially remove the need > for frameworks to create device links, more parallelized async probing, > and better sync_state() tracking. > > 3. Handle hardware/software quirks where a child firmware node gets > populated as a device before its parent firmware node AND actually > supplies a non-optional resource to the parent firmware node's > device. > > 4. Way more robust at cycle handling (see patch for the insane cases). > > 5. Stops depending on OF_POPULATED to figure out some corner cases. > > 6. Simplifies the work that needs to be done by the firmware specific > code. > > The v3 series has gone through my usual testing on my end and looks good > to me. > > Thanks, > Saravana > > [1] - https://lore.kernel.org/lkml/20220810060040.321697-1-saravanak@google.com/ > [2] - https://lore.kernel.org/lkml/CAGETcx-JUV1nj8wBJrTPfyvM7=Mre5j_vkVmZojeiumUGG6QZQ@mail.gmail.com/ > > v1 -> v2: > - Fixed Patch 1 to handle a corner case discussed in [2]. > - New patch 10 to handle "fsl,imx8mq-gpc" being initialized by 2 drivers. > - New patch 11 to add fw_devlink support for SCMI devices. > > v2 -> v3: > - Addressed most of Andy's comments in v2 > - Added Colin and Sudeep's Tested-by for the series (except the imx and > renesas patches) > - Added Sudeep's Acked-by for the scmi patch. > - Added Geert's Reviewed-by for the renesas patch. > - Fixed gpiolib crash reported by Naresh. > - Patch 6: Fix __fwnode_links_move_consumers() to preserve fwnode link flags. > - New Patch 12 to fix nvmem-cells issue reported by Maxim(s)/Miquel. > - Deleted some stale function doc in Patch 8 > > Cc: Abel Vesa > Cc: Alexander Stein > Cc: Tony Lindgren > Cc: Sudeep Holla > Cc: Geert Uytterhoeven > Cc: John Stultz > Cc: Doug Anderson > Cc: Guenter Roeck > Cc: Dmitry Baryshkov > Cc: Maxim Kiselev > Cc: Maxim Kochetkov > Cc: Miquel Raynal > Cc: Luca Weiss > Cc: Colin Foster > Cc: Martin Kepplinger > Cc: Jean-Philippe Brucker > Cc: Vladimir Oltean > > Saravana Kannan (12): > driver core: fw_devlink: Don't purge child fwnode's consumer links > driver core: fw_devlink: Improve check for fwnode with no > device/driver > soc: renesas: Move away from using OF_POPULATED for fw_devlink > gpiolib: Clear the gpio_device's fwnode initialized flag before adding > driver core: fw_devlink: Add DL_FLAG_CYCLE support to device links > driver core: fw_devlink: Allow marking a fwnode link as being part of > a cycle > driver core: fw_devlink: Consolidate device link flag computation > driver core: fw_devlink: Make cycle detection more robust > of: property: Simplify of_link_to_phandle() > irqchip/irq-imx-gpcv2: Mark fwnode device as not initialized > firmware: arm_scmi: Set fwnode for the scmi_device > mtd: mtdpart: Don't create platform device that'll never probe > > drivers/base/core.c | 449 +++++++++++++++++++++----------- > drivers/firmware/arm_scmi/bus.c | 3 +- > drivers/gpio/gpiolib.c | 7 + > drivers/irqchip/irq-imx-gpcv2.c | 1 + > drivers/mtd/mtdpart.c | 10 + > drivers/of/property.c | 84 +----- > drivers/soc/imx/gpcv2.c | 2 +- > drivers/soc/renesas/rcar-sysc.c | 2 +- > include/linux/device.h | 1 + > include/linux/fwnode.h | 12 +- > 10 files changed, 344 insertions(+), 227 deletions(-) > > -- > 2.39.1.519.gcb327c4b5f-goog ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CA3EC64EC4 for ; Tue, 7 Feb 2023 09:24:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231562AbjBGJYL (ORCPT ); Tue, 7 Feb 2023 04:24:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231382AbjBGJXp (ORCPT ); Tue, 7 Feb 2023 04:23:45 -0500 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B532366B7 for ; Tue, 7 Feb 2023 01:23:09 -0800 (PST) Received: by mail-ej1-x62e.google.com with SMTP id jg8so1879235ejc.6 for ; Tue, 07 Feb 2023 01:23:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=I70HhxHLsI2HHGcZI04fStNVNeSuevhKRqsln0/FI/A=; b=yrMGmfrMG5RKmVutlzGybx2TOoPNybxgeoFTGv81EX+SrqeMxTBh6j1swNcISVyw+p AgxQ+dFKkqs4M+u7dP5WPvcw6t/6BiMCzK+bOyEBzFiotz/5L2G3eEMdJFEYX4+4bwpJ Z0MRw+rSaCVL7tO3EKomyzEQp/H7CkFnKCW7+mzsAR0ABkwjVvW9n6FRXkKWS8OtlSVW 0GnttzP+aRl1UBX6dKSXSyf58HWn/JgZXGprVJzROGcIll13KS+KQKtI+car/sh4sQk3 i7b90CA7JynTrQkutLlEKl4SxpFEHmuY9HM0fTBVmDHIJUDDQFwDmwPsvnJidHbLmfFO CVaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=I70HhxHLsI2HHGcZI04fStNVNeSuevhKRqsln0/FI/A=; b=lVVwmaWr8GijDJUpEJBCtL5z6MR99TLzjECYIELiPVnTfvu6NqK254YKrmdp7WHI1L 5LyN4EhXuoKDygJTzUYQT7yLiBwZTJwnzqqcHX1xyhpVjmUNYYYk2kToRlYAwK5llGt+ KmCQ/J4Vq65/HA5HUBToQLvYI8RbOThRvY3/FTQXQrOh1bQfxF7TCf3IOS2OLAbO1kux pqWrxyV5cvipghqxy0yhEg2enQspNzn+rhi2n7QYRD9dKbw+tHLMkfL0MYMxgHZ+A973 dCWsgBcjgR1GOxP3LRuG71voyJCtcOGt99sHiAs0lPHPRsDhpyvM+TALfNjSNWQHQwcx IODQ== X-Gm-Message-State: AO0yUKUvmMEASdDxMOvdS4jDhhGfxjD6DqblKwFjO2nVChURWLQInIUI NPqNxxF+5nmwgA6VJgIZ1I4vvA== X-Google-Smtp-Source: AK7set/4jc5ZZLArDJD4G8kQ0dT4ezIRyv/eZI/G0ee7KmVpY7u9jRJrKjLsy6MxGRs020d764r0jA== X-Received: by 2002:a17:906:448c:b0:88a:4a22:dd5 with SMTP id y12-20020a170906448c00b0088a4a220dd5mr2585928ejo.23.1675761787520; Tue, 07 Feb 2023 01:23:07 -0800 (PST) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b00882f9130eafsm6599467ejb.26.2023.02.07.01.23.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Feb 2023 01:23:07 -0800 (PST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 07 Feb 2023 10:23:06 +0100 Message-Id: Cc: "Abel Vesa" , "Alexander Stein" , "Tony Lindgren" , "Geert Uytterhoeven" , "John Stultz" , "Doug Anderson" , "Guenter Roeck" , "Dmitry Baryshkov" , "Maxim Kiselev" , "Maxim Kochetkov" , "Colin Foster" , "Martin Kepplinger" , "Jean-Philippe Brucker" , "Vladimir Oltean" , , , , , , , , Subject: Re: [PATCH v3 00/12] fw_devlink improvements From: "Luca Weiss" To: "Saravana Kannan" , "Greg Kroah-Hartman" , "Rafael J. Wysocki" , "Sudeep Holla" , "Cristian Marussi" , "Linus Walleij" , "Bartosz Golaszewski" , "Thomas Gleixner" , "Marc Zyngier" , "Shawn Guo" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "NXP Linux Team" , "Miquel Raynal" , "Richard Weinberger" , "Vignesh Raghavendra" , "Rob Herring" , "Frank Rowand" , "Geert Uytterhoeven" , "Magnus Damm" , "Andy Shevchenko" , "Daniel Scally" , "Heikki Krogerus" , "Sakari Ailus" , "Len Brown" , =?utf-8?q?Rafa=C5=82_Mi=C5=82ecki?= X-Mailer: aerc 0.14.0 References: <20230207014207.1678715-1-saravanak@google.com> In-Reply-To: <20230207014207.1678715-1-saravanak@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue Feb 7, 2023 at 2:41 AM CET, Saravana Kannan wrote: > Naresh, Tony, Abel, Geert, Dmitry, Maxim(s), Miquel, Luca, Doug, Martin, > Jean-Philippe, > > Can I get your Tested-by's for this v3 series please? Hi Saravana, Seems to be alright on the same platform where it broke previously. Tested-by: Luca Weiss # qcom/sm7225-fairphone-fp= 4 Regards Luca > > Vladimir, > > Ccing you because DSA's and fw_devlink have known/existing problems > (still in my TODOs to fix). But I want to make sure this series doesn't > cause additional problems for DSA. > > All, > > This patch series improves fw_devlink in the following ways: > > 1. It no longer cares about a fwnode having a "compatible" property. It > figures this out more dynamically. The only expectation is that > fwnodes that are converted to devices actually get probed by a driver > for the dependencies to be enforced correctly. > > 2. Finer grained dependency tracking. fw_devlink will now create device > links from the consumer to the actual resource's device (if it has one= , > Eg: gpio_device) instead of the parent supplier device. This improves > things like async suspend/resume ordering, potentially remove the need > for frameworks to create device links, more parallelized async probing= , > and better sync_state() tracking. > > 3. Handle hardware/software quirks where a child firmware node gets > populated as a device before its parent firmware node AND actually > supplies a non-optional resource to the parent firmware node's > device. > > 4. Way more robust at cycle handling (see patch for the insane cases). > > 5. Stops depending on OF_POPULATED to figure out some corner cases. > > 6. Simplifies the work that needs to be done by the firmware specific > code. > > The v3 series has gone through my usual testing on my end and looks good > to me. > > Thanks, > Saravana > > [1] - https://lore.kernel.org/lkml/20220810060040.321697-1-saravanak@goog= le.com/ > [2] - https://lore.kernel.org/lkml/CAGETcx-JUV1nj8wBJrTPfyvM7=3DMre5j_vkV= mZojeiumUGG6QZQ@mail.gmail.com/ > > v1 -> v2: > - Fixed Patch 1 to handle a corner case discussed in [2]. > - New patch 10 to handle "fsl,imx8mq-gpc" being initialized by 2 drivers. > - New patch 11 to add fw_devlink support for SCMI devices. > > v2 -> v3: > - Addressed most of Andy's comments in v2 > - Added Colin and Sudeep's Tested-by for the series (except the imx and > renesas patches) > - Added Sudeep's Acked-by for the scmi patch. > - Added Geert's Reviewed-by for the renesas patch. > - Fixed gpiolib crash reported by Naresh. > - Patch 6: Fix __fwnode_links_move_consumers() to preserve fwnode link fl= ags. > - New Patch 12 to fix nvmem-cells issue reported by Maxim(s)/Miquel. > - Deleted some stale function doc in Patch 8 > > Cc: Abel Vesa > Cc: Alexander Stein > Cc: Tony Lindgren > Cc: Sudeep Holla > Cc: Geert Uytterhoeven > Cc: John Stultz > Cc: Doug Anderson > Cc: Guenter Roeck > Cc: Dmitry Baryshkov > Cc: Maxim Kiselev > Cc: Maxim Kochetkov > Cc: Miquel Raynal > Cc: Luca Weiss > Cc: Colin Foster > Cc: Martin Kepplinger > Cc: Jean-Philippe Brucker > Cc: Vladimir Oltean > > Saravana Kannan (12): > driver core: fw_devlink: Don't purge child fwnode's consumer links > driver core: fw_devlink: Improve check for fwnode with no > device/driver > soc: renesas: Move away from using OF_POPULATED for fw_devlink > gpiolib: Clear the gpio_device's fwnode initialized flag before adding > driver core: fw_devlink: Add DL_FLAG_CYCLE support to device links > driver core: fw_devlink: Allow marking a fwnode link as being part of > a cycle > driver core: fw_devlink: Consolidate device link flag computation > driver core: fw_devlink: Make cycle detection more robust > of: property: Simplify of_link_to_phandle() > irqchip/irq-imx-gpcv2: Mark fwnode device as not initialized > firmware: arm_scmi: Set fwnode for the scmi_device > mtd: mtdpart: Don't create platform device that'll never probe > > drivers/base/core.c | 449 +++++++++++++++++++++----------- > drivers/firmware/arm_scmi/bus.c | 3 +- > drivers/gpio/gpiolib.c | 7 + > drivers/irqchip/irq-imx-gpcv2.c | 1 + > drivers/mtd/mtdpart.c | 10 + > drivers/of/property.c | 84 +----- > drivers/soc/imx/gpcv2.c | 2 +- > drivers/soc/renesas/rcar-sysc.c | 2 +- > include/linux/device.h | 1 + > include/linux/fwnode.h | 12 +- > 10 files changed, 344 insertions(+), 227 deletions(-) > > --=20 > 2.39.1.519.gcb327c4b5f-goog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9190BC636CC for ; Tue, 7 Feb 2023 09:24:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:From:Subject: Cc:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IP7M3++IcDOPPRxxwoad9jPjKj2eZEag0AV+yowAzXE=; b=bTBH6/hRrZEct5 z1GHuJf9YYBy5xFjo7QRclBprQf34B7rMsm+Tdaph2E2x46K420uQIb8EE3qGSe/QEZib3sxcmGXF iFJZXR7JZRnpNNGw23aWCVXDJA4+eJJ/WvhkAMugc5y2VV8mRj8BnIWoROhd9u2gDH4VM9Jcr8Ydi BDpePi1xeXiOk1JQS2cF9eMCeG2Fjx8QaSoa3EuDQGR/infLvGJRUL5B4f7BhIb81AepphDNt8U3S 7SxxJeT4LPNiLtXWN7AGyNy/Nh8abnPmW+53msqEIAYfg4CNoCZ34+3SR87l9JxaEQcopPaSz1Nuy n3E+JHf6wWVL0UpIa80Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPKC2-00BSZt-NB; Tue, 07 Feb 2023 09:23:14 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPKBy-00BSY7-Ll for linux-arm-kernel@lists.infradead.org; Tue, 07 Feb 2023 09:23:13 +0000 Received: by mail-ej1-x62e.google.com with SMTP id gr7so41497884ejb.5 for ; Tue, 07 Feb 2023 01:23:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=I70HhxHLsI2HHGcZI04fStNVNeSuevhKRqsln0/FI/A=; b=yrMGmfrMG5RKmVutlzGybx2TOoPNybxgeoFTGv81EX+SrqeMxTBh6j1swNcISVyw+p AgxQ+dFKkqs4M+u7dP5WPvcw6t/6BiMCzK+bOyEBzFiotz/5L2G3eEMdJFEYX4+4bwpJ Z0MRw+rSaCVL7tO3EKomyzEQp/H7CkFnKCW7+mzsAR0ABkwjVvW9n6FRXkKWS8OtlSVW 0GnttzP+aRl1UBX6dKSXSyf58HWn/JgZXGprVJzROGcIll13KS+KQKtI+car/sh4sQk3 i7b90CA7JynTrQkutLlEKl4SxpFEHmuY9HM0fTBVmDHIJUDDQFwDmwPsvnJidHbLmfFO CVaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=I70HhxHLsI2HHGcZI04fStNVNeSuevhKRqsln0/FI/A=; b=fgpQsb9QQCVKBwHhDjmqB3bryG61EMfTaAitirISSPQka3+ZCDlcxtrluPLlgEvBxy /G3xmEu7LnPp5MzApgtc2NMZGJ3J07CzLecY2JdpTJvKhHC1z5mE7eKaA5kYH34fvcPs j2CHW1V36CnRVmdtbewjQP6p/ZBcLx0eMFw5wVyC3ZcIEJct9i2QPLmpQo4bgyf+Z0af hGc53pRCigmN35cat+9sPS3rpdQ5bO5TmRKEwKqyXkFRYicayxW6IlsSADIh6vO1wDEg 0xSaoyK+M3QjrJoJhM7IygRWUPkGwIWIguRjed+bzWTMiEQ+C6pB0qkD5vk3YpnhMxU8 2hWw== X-Gm-Message-State: AO0yUKVLRfoe6LgGy3e2JaSkbYokHJIhWc02bp/a3m0snDqnwOVirkVd 7Zlm55sQ/dT8g0tuvSTONmWlXQ== X-Google-Smtp-Source: AK7set/4jc5ZZLArDJD4G8kQ0dT4ezIRyv/eZI/G0ee7KmVpY7u9jRJrKjLsy6MxGRs020d764r0jA== X-Received: by 2002:a17:906:448c:b0:88a:4a22:dd5 with SMTP id y12-20020a170906448c00b0088a4a220dd5mr2585928ejo.23.1675761787520; Tue, 07 Feb 2023 01:23:07 -0800 (PST) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id ml18-20020a170906cc1200b00882f9130eafsm6599467ejb.26.2023.02.07.01.23.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Feb 2023 01:23:07 -0800 (PST) Mime-Version: 1.0 Date: Tue, 07 Feb 2023 10:23:06 +0100 Message-Id: Cc: "Abel Vesa" , "Alexander Stein" , "Tony Lindgren" , "Geert Uytterhoeven" , "John Stultz" , "Doug Anderson" , "Guenter Roeck" , "Dmitry Baryshkov" , "Maxim Kiselev" , "Maxim Kochetkov" , "Colin Foster" , "Martin Kepplinger" , "Jean-Philippe Brucker" , "Vladimir Oltean" , , , , , , , , Subject: Re: [PATCH v3 00/12] fw_devlink improvements From: "Luca Weiss" To: "Saravana Kannan" , "Greg Kroah-Hartman" , "Rafael J. Wysocki" , "Sudeep Holla" , "Cristian Marussi" , "Linus Walleij" , "Bartosz Golaszewski" , "Thomas Gleixner" , "Marc Zyngier" , "Shawn Guo" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "NXP Linux Team" , "Miquel Raynal" , "Richard Weinberger" , "Vignesh Raghavendra" , "Rob Herring" , "Frank Rowand" , "Geert Uytterhoeven" , "Magnus Damm" , "Andy Shevchenko" , "Daniel Scally" , "Heikki Krogerus" , "Sakari Ailus" , "Len Brown" , =?utf-8?q?Rafa=C5=82_Mi=C5=82ecki?= X-Mailer: aerc 0.14.0 References: <20230207014207.1678715-1-saravanak@google.com> In-Reply-To: <20230207014207.1678715-1-saravanak@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230207_012311_569996_2280919F X-CRM114-Status: GOOD ( 29.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue Feb 7, 2023 at 2:41 AM CET, Saravana Kannan wrote: > Naresh, Tony, Abel, Geert, Dmitry, Maxim(s), Miquel, Luca, Doug, Martin, > Jean-Philippe, > > Can I get your Tested-by's for this v3 series please? Hi Saravana, Seems to be alright on the same platform where it broke previously. Tested-by: Luca Weiss # qcom/sm7225-fairphone-fp4 Regards Luca > > Vladimir, > > Ccing you because DSA's and fw_devlink have known/existing problems > (still in my TODOs to fix). But I want to make sure this series doesn't > cause additional problems for DSA. > > All, > > This patch series improves fw_devlink in the following ways: > > 1. It no longer cares about a fwnode having a "compatible" property. It > figures this out more dynamically. The only expectation is that > fwnodes that are converted to devices actually get probed by a driver > for the dependencies to be enforced correctly. > > 2. Finer grained dependency tracking. fw_devlink will now create device > links from the consumer to the actual resource's device (if it has one, > Eg: gpio_device) instead of the parent supplier device. This improves > things like async suspend/resume ordering, potentially remove the need > for frameworks to create device links, more parallelized async probing, > and better sync_state() tracking. > > 3. Handle hardware/software quirks where a child firmware node gets > populated as a device before its parent firmware node AND actually > supplies a non-optional resource to the parent firmware node's > device. > > 4. Way more robust at cycle handling (see patch for the insane cases). > > 5. Stops depending on OF_POPULATED to figure out some corner cases. > > 6. Simplifies the work that needs to be done by the firmware specific > code. > > The v3 series has gone through my usual testing on my end and looks good > to me. > > Thanks, > Saravana > > [1] - https://lore.kernel.org/lkml/20220810060040.321697-1-saravanak@google.com/ > [2] - https://lore.kernel.org/lkml/CAGETcx-JUV1nj8wBJrTPfyvM7=Mre5j_vkVmZojeiumUGG6QZQ@mail.gmail.com/ > > v1 -> v2: > - Fixed Patch 1 to handle a corner case discussed in [2]. > - New patch 10 to handle "fsl,imx8mq-gpc" being initialized by 2 drivers. > - New patch 11 to add fw_devlink support for SCMI devices. > > v2 -> v3: > - Addressed most of Andy's comments in v2 > - Added Colin and Sudeep's Tested-by for the series (except the imx and > renesas patches) > - Added Sudeep's Acked-by for the scmi patch. > - Added Geert's Reviewed-by for the renesas patch. > - Fixed gpiolib crash reported by Naresh. > - Patch 6: Fix __fwnode_links_move_consumers() to preserve fwnode link flags. > - New Patch 12 to fix nvmem-cells issue reported by Maxim(s)/Miquel. > - Deleted some stale function doc in Patch 8 > > Cc: Abel Vesa > Cc: Alexander Stein > Cc: Tony Lindgren > Cc: Sudeep Holla > Cc: Geert Uytterhoeven > Cc: John Stultz > Cc: Doug Anderson > Cc: Guenter Roeck > Cc: Dmitry Baryshkov > Cc: Maxim Kiselev > Cc: Maxim Kochetkov > Cc: Miquel Raynal > Cc: Luca Weiss > Cc: Colin Foster > Cc: Martin Kepplinger > Cc: Jean-Philippe Brucker > Cc: Vladimir Oltean > > Saravana Kannan (12): > driver core: fw_devlink: Don't purge child fwnode's consumer links > driver core: fw_devlink: Improve check for fwnode with no > device/driver > soc: renesas: Move away from using OF_POPULATED for fw_devlink > gpiolib: Clear the gpio_device's fwnode initialized flag before adding > driver core: fw_devlink: Add DL_FLAG_CYCLE support to device links > driver core: fw_devlink: Allow marking a fwnode link as being part of > a cycle > driver core: fw_devlink: Consolidate device link flag computation > driver core: fw_devlink: Make cycle detection more robust > of: property: Simplify of_link_to_phandle() > irqchip/irq-imx-gpcv2: Mark fwnode device as not initialized > firmware: arm_scmi: Set fwnode for the scmi_device > mtd: mtdpart: Don't create platform device that'll never probe > > drivers/base/core.c | 449 +++++++++++++++++++++----------- > drivers/firmware/arm_scmi/bus.c | 3 +- > drivers/gpio/gpiolib.c | 7 + > drivers/irqchip/irq-imx-gpcv2.c | 1 + > drivers/mtd/mtdpart.c | 10 + > drivers/of/property.c | 84 +----- > drivers/soc/imx/gpcv2.c | 2 +- > drivers/soc/renesas/rcar-sysc.c | 2 +- > include/linux/device.h | 1 + > include/linux/fwnode.h | 12 +- > 10 files changed, 344 insertions(+), 227 deletions(-) > > -- > 2.39.1.519.gcb327c4b5f-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel