From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pv50p00im-zteg10011501.me.com (pv50p00im-zteg10011501.me.com [17.58.6.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C385D2ED for ; Tue, 21 Mar 2023 16:50:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1679417449; bh=5ukV6PY3ucC9hJDuXZfIVXvf88RafbDWPyWPmbI4b+M=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To; b=sgnlOBOdnJ4Md1bXyy0cTRU3QCOeruwaZC8HiYR65vzbQQ2ge3aX+tWCMisb4D/uf I1wWmYnpJcFCcUh7ofpd7CoOCJyuzL1O1HLrBVaMu8L7aOQZ/gbdERcEitcLR4ujBR FooPqSKK6iCNUA5uwLrF0m5JmtVzcgbyJw0OMdX3PjkZTGUo0ljQEsGUkcimcFquL9 DzzOFblcqbngGjpqVtiOwQnjHkUEOGOvd/DpN1EtHz03q85d8SKaoa0y8sMoi5/9UP 9mdLtyyboIOUOzqLQX8qA/cnU6IQCZfFe1Js3i1LM6Qk5rhB/JSk8njepVxy9Pi70b NV8THQNzkH8OQ== Received: from localhost (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-zteg10011501.me.com (Postfix) with ESMTPSA id BA8B54A00DE; Tue, 21 Mar 2023 16:50:45 +0000 (UTC) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 21 Mar 2023 17:50:43 +0100 Message-Id: Subject: Re: [PATCH] drm/sun4i: uncouple DSI dotclock divider from TCON0_DCLK_REG From: "Roman Beranek" To: "Maxime Ripard" Cc: "Chen-Yu Tsai" , "David Airlie" , "Daniel Vetter" , "Jernej Skrabec" , "Samuel Holland" , , , , X-Mailer: aerc 0.14.0 References: <20230320161636.24411-1-romanberanek@icloud.com> <20230321145646.w6kr7ddurfxpg5rt@houat> In-Reply-To: <20230321145646.w6kr7ddurfxpg5rt@houat> X-Proofpoint-GUID: nW3p3X6tTkVEQXdicLpHvySaM0EbhDEp X-Proofpoint-ORIG-GUID: nW3p3X6tTkVEQXdicLpHvySaM0EbhDEp X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.517,18.0.883,17.0.605.474.0000000_definitions?= =?UTF-8?Q?=3D2022-06-21=5F08:2022-06-21=5F01,2022-06-21=5F08,2020-01-23?= =?UTF-8?Q?=5F02_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 malwarescore=0 mlxscore=0 phishscore=0 clxscore=1011 bulkscore=0 suspectscore=0 mlxlogscore=771 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2303210132 Hello Maxime, On Tue Mar 21, 2023 at 3:56 PM CET, Maxime Ripard wrote: > > This is similar to > https://lore.kernel.org/all/20230319160704.9858-2-frank@oltmanns.dev/ > > What's the story there? Yes, Frank Oltmanns wrote me recently in relation to a patch I wrote ~ 3 years ago that addressed the framerate issue, proposing to collaborate on pushing it upstream, however as I've been keeping up with my inbox rather sporadically these days, by the time I read his message, Frank had already taken the initiative and sent the patch. So that's how we've got to this slightly awkward situation with two patches on the same subject arriving 1 day apart of each other. The problem with the original patch was that it went around sun4i_dotclock by feeding it a rate adjusted such that the pll-mipi rate was set correctly. I couldn't quite figure out at the time of how big a portion of the tcon logic does the sun4i_dotclock code need to be made aware of. >Also, how was it tested/confirmed? By counting Vblank interrupts (GIC 118). Roman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33E21C74A5B for ; Tue, 21 Mar 2023 16:50:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 82E8F10E7F1; Tue, 21 Mar 2023 16:50:51 +0000 (UTC) Received: from pv50p00im-zteg10011501.me.com (pv50p00im-zteg10011501.me.com [17.58.6.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5CBEC10E7F1 for ; Tue, 21 Mar 2023 16:50:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1679417449; bh=5ukV6PY3ucC9hJDuXZfIVXvf88RafbDWPyWPmbI4b+M=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To; b=sgnlOBOdnJ4Md1bXyy0cTRU3QCOeruwaZC8HiYR65vzbQQ2ge3aX+tWCMisb4D/uf I1wWmYnpJcFCcUh7ofpd7CoOCJyuzL1O1HLrBVaMu8L7aOQZ/gbdERcEitcLR4ujBR FooPqSKK6iCNUA5uwLrF0m5JmtVzcgbyJw0OMdX3PjkZTGUo0ljQEsGUkcimcFquL9 DzzOFblcqbngGjpqVtiOwQnjHkUEOGOvd/DpN1EtHz03q85d8SKaoa0y8sMoi5/9UP 9mdLtyyboIOUOzqLQX8qA/cnU6IQCZfFe1Js3i1LM6Qk5rhB/JSk8njepVxy9Pi70b NV8THQNzkH8OQ== Received: from localhost (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-zteg10011501.me.com (Postfix) with ESMTPSA id BA8B54A00DE; Tue, 21 Mar 2023 16:50:45 +0000 (UTC) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 21 Mar 2023 17:50:43 +0100 Message-Id: Subject: Re: [PATCH] drm/sun4i: uncouple DSI dotclock divider from TCON0_DCLK_REG From: "Roman Beranek" To: "Maxime Ripard" X-Mailer: aerc 0.14.0 References: <20230320161636.24411-1-romanberanek@icloud.com> <20230321145646.w6kr7ddurfxpg5rt@houat> In-Reply-To: <20230321145646.w6kr7ddurfxpg5rt@houat> X-Proofpoint-GUID: nW3p3X6tTkVEQXdicLpHvySaM0EbhDEp X-Proofpoint-ORIG-GUID: nW3p3X6tTkVEQXdicLpHvySaM0EbhDEp X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.517,18.0.883,17.0.605.474.0000000_definitions?= =?UTF-8?Q?=3D2022-06-21=5F08:2022-06-21=5F01,2022-06-21=5F08,2020-01-23?= =?UTF-8?Q?=5F02_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 malwarescore=0 mlxscore=0 phishscore=0 clxscore=1011 bulkscore=0 suspectscore=0 mlxlogscore=771 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2303210132 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samuel Holland , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chen-Yu Tsai , Jernej Skrabec , linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello Maxime, On Tue Mar 21, 2023 at 3:56 PM CET, Maxime Ripard wrote: > > This is similar to > https://lore.kernel.org/all/20230319160704.9858-2-frank@oltmanns.dev/ > > What's the story there? Yes, Frank Oltmanns wrote me recently in relation to a patch I wrote ~ 3 years ago that addressed the framerate issue, proposing to collaborate on pushing it upstream, however as I've been keeping up with my inbox rather sporadically these days, by the time I read his message, Frank had already taken the initiative and sent the patch. So that's how we've got to this slightly awkward situation with two patches on the same subject arriving 1 day apart of each other. The problem with the original patch was that it went around sun4i_dotclock by feeding it a rate adjusted such that the pll-mipi rate was set correctly. I couldn't quite figure out at the time of how big a portion of the tcon logic does the sun4i_dotclock code need to be made aware of. >Also, how was it tested/confirmed? By counting Vblank interrupts (GIC 118). Roman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA918C74A5B for ; Tue, 21 Mar 2023 16:52:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tmm+PR+H48lNEEH7UpomnCRieUMx/8a9pa1HmSgjbhw=; b=TZTsz5eUixSVjQ yxpiQjyIVuYzujDhuIoM+trH2mZMmpU03BYgRw71RThzAZZj58mbUe6bn5uAmcIpVvjQF2mBSEtpY gd0i6L/1A/k+KLbKY4C7lW3CplpLz7tUoP27yDViFz7h06c+sX/iXMom1lingppVaRLAGUNH6lMsp A42dY2l39rCui7ZEV7fGCgQLzO3YJ142rMs0URr3ZOPYDxNV2ooy2pOybTv8aLJw83o27Zdm0uwD0 7I5EpbYnsloOhotAG/KXhi1JxxXgl0nzvCiNkT6CAQOWjX/ZjRcB8+148xEWgK+23XuR+DEcp3kE8 AhlDEm7QWWWPgTDUDStA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pefCN-00D8Aj-1i; Tue, 21 Mar 2023 16:50:59 +0000 Received: from pv50p00im-zteg10011501.me.com ([17.58.6.42]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pefCK-00D88n-1V for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 16:50:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1679417449; bh=5ukV6PY3ucC9hJDuXZfIVXvf88RafbDWPyWPmbI4b+M=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To; b=sgnlOBOdnJ4Md1bXyy0cTRU3QCOeruwaZC8HiYR65vzbQQ2ge3aX+tWCMisb4D/uf I1wWmYnpJcFCcUh7ofpd7CoOCJyuzL1O1HLrBVaMu8L7aOQZ/gbdERcEitcLR4ujBR FooPqSKK6iCNUA5uwLrF0m5JmtVzcgbyJw0OMdX3PjkZTGUo0ljQEsGUkcimcFquL9 DzzOFblcqbngGjpqVtiOwQnjHkUEOGOvd/DpN1EtHz03q85d8SKaoa0y8sMoi5/9UP 9mdLtyyboIOUOzqLQX8qA/cnU6IQCZfFe1Js3i1LM6Qk5rhB/JSk8njepVxy9Pi70b NV8THQNzkH8OQ== Received: from localhost (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-zteg10011501.me.com (Postfix) with ESMTPSA id BA8B54A00DE; Tue, 21 Mar 2023 16:50:45 +0000 (UTC) Mime-Version: 1.0 Date: Tue, 21 Mar 2023 17:50:43 +0100 Message-Id: Subject: Re: [PATCH] drm/sun4i: uncouple DSI dotclock divider from TCON0_DCLK_REG From: "Roman Beranek" To: "Maxime Ripard" Cc: "Chen-Yu Tsai" , "David Airlie" , "Daniel Vetter" , "Jernej Skrabec" , "Samuel Holland" , , , , X-Mailer: aerc 0.14.0 References: <20230320161636.24411-1-romanberanek@icloud.com> <20230321145646.w6kr7ddurfxpg5rt@houat> In-Reply-To: <20230321145646.w6kr7ddurfxpg5rt@houat> X-Proofpoint-GUID: nW3p3X6tTkVEQXdicLpHvySaM0EbhDEp X-Proofpoint-ORIG-GUID: nW3p3X6tTkVEQXdicLpHvySaM0EbhDEp X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.517,18.0.883,17.0.605.474.0000000_definitions?= =?UTF-8?Q?=3D2022-06-21=5F08:2022-06-21=5F01,2022-06-21=5F08,2020-01-23?= =?UTF-8?Q?=5F02_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 malwarescore=0 mlxscore=0 phishscore=0 clxscore=1011 bulkscore=0 suspectscore=0 mlxlogscore=771 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2303210132 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_095056_524560_04D19E7E X-CRM114-Status: GOOD ( 11.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Maxime, On Tue Mar 21, 2023 at 3:56 PM CET, Maxime Ripard wrote: > > This is similar to > https://lore.kernel.org/all/20230319160704.9858-2-frank@oltmanns.dev/ > > What's the story there? Yes, Frank Oltmanns wrote me recently in relation to a patch I wrote ~ 3 years ago that addressed the framerate issue, proposing to collaborate on pushing it upstream, however as I've been keeping up with my inbox rather sporadically these days, by the time I read his message, Frank had already taken the initiative and sent the patch. So that's how we've got to this slightly awkward situation with two patches on the same subject arriving 1 day apart of each other. The problem with the original patch was that it went around sun4i_dotclock by feeding it a rate adjusted such that the pll-mipi rate was set correctly. I couldn't quite figure out at the time of how big a portion of the tcon logic does the sun4i_dotclock code need to be made aware of. >Also, how was it tested/confirmed? By counting Vblank interrupts (GIC 118). Roman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel