From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from qs51p00im-qukt01071902.me.com (qs51p00im-qukt01071902.me.com [17.57.155.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F2D917EA for ; Wed, 12 Apr 2023 07:15:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1681283703; bh=FuHa2VctxY8ljAUtLpIjGV5QmLAE4POaPbEVmwgcH2o=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To; b=qY08AyFEmbBbMRmPeik5yhhAU3lwphghNn24tlEZ05vOVrFWtZSNDXmUtGuHh8n5N vFBfCSUOMVpXxOSzg00fpuzPLEkUrVvbznMG5ErYZEbnDeeVkW/qbjlOxr2oX2Bomy v5KC7nZMd/+z/r5cZ1ilzsAebgJn1m7/DiOQebOT8F4ZVvCSXRwH8NdCfGRPrEJ3oB IW+Pc4wC30B0LWGprb9e4gJMCsOTJFQN0WuKuHYUD5U/L2E8ZltqoR4xXpdes5Ct1i WjQc3/gtJcsSykcDtr8ljRgmxlFNdy87z4EydHZshcht2f70xYrxVMuOJsMe5ICQGc ww/8hNCOGbCqQ== Received: from localhost (qs51p00im-dlb-asmtp-mailmevip.me.com [17.57.155.28]) by qs51p00im-qukt01071902.me.com (Postfix) with ESMTPSA id 4C7375EC011E; Wed, 12 Apr 2023 07:15:01 +0000 (UTC) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 12 Apr 2023 09:14:59 +0200 Message-Id: Cc: "Frank Oltmanns" , "Chen-Yu Tsai" , "David Airlie" , "Daniel Vetter" , "Jernej Skrabec" , "Samuel Holland" , , , , Subject: Re: [PATCH] drm/sun4i: uncouple DSI dotclock divider from TCON0_DCLK_REG From: "Roman Beranek" To: "Maxime Ripard" X-Mailer: aerc 0.14.0 References: <20230320161636.24411-1-romanberanek@icloud.com> <87wn356ni4.fsf@oltmanns.dev> <20230327202045.ceeqqwjug4ktxtsf@penduick> <20230329195802.veybo3367zifw77n@penduick> In-Reply-To: X-Proofpoint-GUID: s-iO_fMJ2HHG6apJavxJxsPYR0SgWQJt X-Proofpoint-ORIG-GUID: s-iO_fMJ2HHG6apJavxJxsPYR0SgWQJt X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.425,18.0.572,17.11.62.513.0000000_definitions?= =?UTF-8?Q?=3D2022-01-11=5F01:2022-01-11=5F01,2020-02-14=5F11,2021-12-02?= =?UTF-8?Q?=5F01_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=487 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 clxscore=1015 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2304120065 On Wed Apr 5, 2023 at 5:03 PM CEST, Maxime Ripard wrote: > On Wed, Apr 05, 2023 at 02:34:11PM +0200, Roman Beranek wrote: > > It turns out however that the new dclk rates can't be set exactly as > > requested without touching pll-video0*, tcon0 now therefore gets > > reparented from pll-mipi to pll-video0-2x which, as it further turns > > out, breaks DSI. While simply forbidding the video0-2x mux option seems > > to me as the right way to go because there's not much use for it with > > non-DSI interfaces either besides the opportunity to power pll-mipi > > down, I'd like to run by you first. > > Sounds reasonable Okay, I'm unsure of how to denote that in the code however. Should I just comment the parent out of the table and put an explanation in a comment nearby? Or just erase it? I couldn't find an applicable precedent. > > * As pll-mipi doesn't have CLK_SET_RATE_PARENT flag set, pll-video0 > > retains its boot-time rate of 294 MHz set by sunxi-dw-hdmi driver > > in u-boot. Why 294 MHz (as opposed to the default rate of 297 MHz)? > > The driver actually asks for 297 MHz, clock_set_pll3 rounds it to > > 294 MHz though because it limits itself to 6 MHz steps. > > We could also address that though Should I include it in v2 of the series, or leave it for later? Thanks, Roman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD785C77B6E for ; Wed, 12 Apr 2023 07:16:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:From:Subject: Cc:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6u2WNNvVpFyNXXCfbpWTPA+CGBWZ688QYo4K9EPGdLM=; b=bFuCV4pGuQi93P L5os5+2T/POTeIclsULDjmqj4yXJJV8U4HlF749rhSG48MQD5bixJi91w0U6zziZDIp5m8XKl722b ZCDoyDxsZ5YOJjw1PUlE4yGmLlOd1Arm9XulgAtaj++OzQMA/hOYkmXfDNJ+YIsI+rgRn1y1RTmCM go9yIBybMZXSgSC3iWukjKGXnf53KZhL0mTOSgTY72ubPXJ4JduMP3woiy+hZkKK3bA1W7BkOKceU HwadAHdmgb3jo811DOmBwolpdM/fyDZnLzxlT9CtwlCvakpGOf3jsS3PIN22m4rc2yqn2vc30P3/L flApRMhWQCTRbP5/RZLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmUhB-0024Dv-0B; Wed, 12 Apr 2023 07:15:09 +0000 Received: from qs51p00im-qukt01071902.me.com ([17.57.155.9]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmUh7-0024Cv-2m for linux-arm-kernel@lists.infradead.org; Wed, 12 Apr 2023 07:15:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1681283703; bh=FuHa2VctxY8ljAUtLpIjGV5QmLAE4POaPbEVmwgcH2o=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To; b=qY08AyFEmbBbMRmPeik5yhhAU3lwphghNn24tlEZ05vOVrFWtZSNDXmUtGuHh8n5N vFBfCSUOMVpXxOSzg00fpuzPLEkUrVvbznMG5ErYZEbnDeeVkW/qbjlOxr2oX2Bomy v5KC7nZMd/+z/r5cZ1ilzsAebgJn1m7/DiOQebOT8F4ZVvCSXRwH8NdCfGRPrEJ3oB IW+Pc4wC30B0LWGprb9e4gJMCsOTJFQN0WuKuHYUD5U/L2E8ZltqoR4xXpdes5Ct1i WjQc3/gtJcsSykcDtr8ljRgmxlFNdy87z4EydHZshcht2f70xYrxVMuOJsMe5ICQGc ww/8hNCOGbCqQ== Received: from localhost (qs51p00im-dlb-asmtp-mailmevip.me.com [17.57.155.28]) by qs51p00im-qukt01071902.me.com (Postfix) with ESMTPSA id 4C7375EC011E; Wed, 12 Apr 2023 07:15:01 +0000 (UTC) Mime-Version: 1.0 Date: Wed, 12 Apr 2023 09:14:59 +0200 Message-Id: Cc: "Frank Oltmanns" , "Chen-Yu Tsai" , "David Airlie" , "Daniel Vetter" , "Jernej Skrabec" , "Samuel Holland" , , , , Subject: Re: [PATCH] drm/sun4i: uncouple DSI dotclock divider from TCON0_DCLK_REG From: "Roman Beranek" To: "Maxime Ripard" X-Mailer: aerc 0.14.0 References: <20230320161636.24411-1-romanberanek@icloud.com> <87wn356ni4.fsf@oltmanns.dev> <20230327202045.ceeqqwjug4ktxtsf@penduick> <20230329195802.veybo3367zifw77n@penduick> In-Reply-To: X-Proofpoint-GUID: s-iO_fMJ2HHG6apJavxJxsPYR0SgWQJt X-Proofpoint-ORIG-GUID: s-iO_fMJ2HHG6apJavxJxsPYR0SgWQJt X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.425,18.0.572,17.11.62.513.0000000_definitions?= =?UTF-8?Q?=3D2022-01-11=5F01:2022-01-11=5F01,2020-02-14=5F11,2021-12-02?= =?UTF-8?Q?=5F01_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=487 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 clxscore=1015 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2304120065 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_001505_967893_503505A1 X-CRM114-Status: GOOD ( 17.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed Apr 5, 2023 at 5:03 PM CEST, Maxime Ripard wrote: > On Wed, Apr 05, 2023 at 02:34:11PM +0200, Roman Beranek wrote: > > It turns out however that the new dclk rates can't be set exactly as > > requested without touching pll-video0*, tcon0 now therefore gets > > reparented from pll-mipi to pll-video0-2x which, as it further turns > > out, breaks DSI. While simply forbidding the video0-2x mux option seems > > to me as the right way to go because there's not much use for it with > > non-DSI interfaces either besides the opportunity to power pll-mipi > > down, I'd like to run by you first. > > Sounds reasonable Okay, I'm unsure of how to denote that in the code however. Should I just comment the parent out of the table and put an explanation in a comment nearby? Or just erase it? I couldn't find an applicable precedent. > > * As pll-mipi doesn't have CLK_SET_RATE_PARENT flag set, pll-video0 > > retains its boot-time rate of 294 MHz set by sunxi-dw-hdmi driver > > in u-boot. Why 294 MHz (as opposed to the default rate of 297 MHz)? > > The driver actually asks for 297 MHz, clock_set_pll3 rounds it to > > 294 MHz though because it limits itself to 6 MHz steps. > > We could also address that though Should I include it in v2 of the series, or leave it for later? Thanks, Roman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 726F1C7619A for ; Wed, 12 Apr 2023 07:21:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 210C410E285; Wed, 12 Apr 2023 07:21:43 +0000 (UTC) X-Greylist: delayed 397 seconds by postgrey-1.36 at gabe; Wed, 12 Apr 2023 07:21:41 UTC Received: from qs51p00im-qukt01071902.me.com (qs51p00im-qukt01071902.me.com [17.57.155.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id E252210E285 for ; Wed, 12 Apr 2023 07:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1681283703; bh=FuHa2VctxY8ljAUtLpIjGV5QmLAE4POaPbEVmwgcH2o=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To; b=qY08AyFEmbBbMRmPeik5yhhAU3lwphghNn24tlEZ05vOVrFWtZSNDXmUtGuHh8n5N vFBfCSUOMVpXxOSzg00fpuzPLEkUrVvbznMG5ErYZEbnDeeVkW/qbjlOxr2oX2Bomy v5KC7nZMd/+z/r5cZ1ilzsAebgJn1m7/DiOQebOT8F4ZVvCSXRwH8NdCfGRPrEJ3oB IW+Pc4wC30B0LWGprb9e4gJMCsOTJFQN0WuKuHYUD5U/L2E8ZltqoR4xXpdes5Ct1i WjQc3/gtJcsSykcDtr8ljRgmxlFNdy87z4EydHZshcht2f70xYrxVMuOJsMe5ICQGc ww/8hNCOGbCqQ== Received: from localhost (qs51p00im-dlb-asmtp-mailmevip.me.com [17.57.155.28]) by qs51p00im-qukt01071902.me.com (Postfix) with ESMTPSA id 4C7375EC011E; Wed, 12 Apr 2023 07:15:01 +0000 (UTC) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 12 Apr 2023 09:14:59 +0200 Message-Id: Subject: Re: [PATCH] drm/sun4i: uncouple DSI dotclock divider from TCON0_DCLK_REG From: "Roman Beranek" To: "Maxime Ripard" X-Mailer: aerc 0.14.0 References: <20230320161636.24411-1-romanberanek@icloud.com> <87wn356ni4.fsf@oltmanns.dev> <20230327202045.ceeqqwjug4ktxtsf@penduick> <20230329195802.veybo3367zifw77n@penduick> In-Reply-To: X-Proofpoint-GUID: s-iO_fMJ2HHG6apJavxJxsPYR0SgWQJt X-Proofpoint-ORIG-GUID: s-iO_fMJ2HHG6apJavxJxsPYR0SgWQJt X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.425,18.0.572,17.11.62.513.0000000_definitions?= =?UTF-8?Q?=3D2022-01-11=5F01:2022-01-11=5F01,2020-02-14=5F11,2021-12-02?= =?UTF-8?Q?=5F01_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=487 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 clxscore=1015 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2304120065 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samuel Holland , Frank Oltmanns , Jernej Skrabec , linux-kernel@vger.kernel.org, Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed Apr 5, 2023 at 5:03 PM CEST, Maxime Ripard wrote: > On Wed, Apr 05, 2023 at 02:34:11PM +0200, Roman Beranek wrote: > > It turns out however that the new dclk rates can't be set exactly as > > requested without touching pll-video0*, tcon0 now therefore gets > > reparented from pll-mipi to pll-video0-2x which, as it further turns > > out, breaks DSI. While simply forbidding the video0-2x mux option seems > > to me as the right way to go because there's not much use for it with > > non-DSI interfaces either besides the opportunity to power pll-mipi > > down, I'd like to run by you first. > > Sounds reasonable Okay, I'm unsure of how to denote that in the code however. Should I just comment the parent out of the table and put an explanation in a comment nearby? Or just erase it? I couldn't find an applicable precedent. > > * As pll-mipi doesn't have CLK_SET_RATE_PARENT flag set, pll-video0 > > retains its boot-time rate of 294 MHz set by sunxi-dw-hdmi driver > > in u-boot. Why 294 MHz (as opposed to the default rate of 297 MHz)? > > The driver actually asks for 297 MHz, clock_set_pll3 rounds it to > > 294 MHz though because it limits itself to 6 MHz steps. > > We could also address that though Should I include it in v2 of the series, or leave it for later? Thanks, Roman