All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Elluru, Krishna Mohan" <elluru.kri.mohan@hpe.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, Elad Raz <e@eladraz.com>
Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>,
	David Miller <davem@davemloft.net>,
	Linux Netdev List <netdev@vger.kernel.org>,
	Jiri Pirko <jiri@resnulli.us>, Ido Schimmel <idosch@mellanox.com>,
	Yotam Gigi <yotamg@mellanox.com>
Subject: RE: [Patch net-next 2/2] netns: avoid disabling irq for netns id
Date: Tue, 31 Jan 2017 06:47:29 +0000	[thread overview]
Message-ID: <CS1PR84MB00721E8E05290D70693B0EFECA4A0@CS1PR84MB0072.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CAM_iQpU8XPixg3g=NPbOcUPDu+o1bOccpnng=HrW8-VzY-xmgw@mail.gmail.com>

HI Cong,
	Have you posted any patch for the same? I am looking for single netlink socket to handle multiple network namespace events using NETLINK_LISTEN_ALL_NSID. I don't see detection of new namespaces by this socket yet and causing updates to be missed.


Thanks
Krishna Mohan.

-----Original Message-----
From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On Behalf Of Cong Wang
Sent: Thursday, October 20, 2016 1:37 AM
To: Elad Raz <e@eladraz.com>
Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>; David Miller <davem@davemloft.net>; Linux Netdev List <netdev@vger.kernel.org>; Jiri Pirko <jiri@resnulli.us>; Ido Schimmel <idosch@mellanox.com>; Yotam Gigi <yotamg@mellanox.com>
Subject: Re: [Patch net-next 2/2] netns: avoid disabling irq for netns id

On Wed, Oct 19, 2016 at 8:21 AM, Elad Raz <e@eladraz.com> wrote:
> On Fri, Sep 2, 2016 at 11:12 AM, Nicolas Dichtel 
> <nicolas.dichtel@6wind.com> wrote:
>> Le 02/09/2016 à 06:53, Cong Wang a écrit :
>>> We never read or change netns id in hardirq context, the only place 
>>> we read netns id in softirq context is in vxlan_xmit(). So, it 
>>> should be enough to just disable BH.
>>
>> Are you sure? Did you audit all part of the code?
>> peernet2id() is called from netlink core system (do_one_broadcast()). 
>> Are you sure that no driver call this function from an hard irq context?
>>
>> I think that NETLINK_LISTEN_ALL_NSID is largely untested, so it will 
>> be hard to detect a bug introduced in this feature.
>
> I'm seeing strange things on our systems on boot time when trying to 
> mount autofs.
> I bisected and got this patch as the bad one.
> I can see that only when I'm using "debug" config file.

Yeah, I saw the same report from SELinux developers, I am working on a fix.

Thanks.

  reply	other threads:[~2017-01-31  6:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-02  4:53 [Patch net-next 0/2] net: some minor optimization for netns id Cong Wang
2016-09-02  4:53 ` [Patch net-next 1/2] vxlan: call peernet2id() in fdb notification Cong Wang
2016-09-02  8:59   ` Nicolas Dichtel
2016-09-02  4:53 ` [Patch net-next 2/2] netns: avoid disabling irq for netns id Cong Wang
2016-09-02  8:12   ` Nicolas Dichtel
2016-09-02 16:39     ` Cong Wang
2016-09-02 17:24       ` Cong Wang
2016-09-04 20:23         ` Nicolas Dichtel
2016-10-19 15:21     ` Elad Raz
2016-10-19 20:07       ` Cong Wang
2017-01-31  6:47         ` Elluru, Krishna Mohan [this message]
2017-01-31  6:53           ` Cong Wang
2017-01-31  7:10             ` Elluru, Krishna Mohan
2017-01-31  8:24           ` Nicolas Dichtel
2016-09-04 18:40 ` [Patch net-next 0/2] net: some minor optimization " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CS1PR84MB00721E8E05290D70693B0EFECA4A0@CS1PR84MB0072.NAMPRD84.PROD.OUTLOOK.COM \
    --to=elluru.kri.mohan@hpe.com \
    --cc=davem@davemloft.net \
    --cc=e@eladraz.com \
    --cc=idosch@mellanox.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=xiyou.wangcong@gmail.com \
    --cc=yotamg@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.