From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79FB7C77B7C for ; Fri, 5 May 2023 02:53:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229620AbjEECxU (ORCPT ); Thu, 4 May 2023 22:53:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbjEECxQ (ORCPT ); Thu, 4 May 2023 22:53:16 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DC9B2D53; Thu, 4 May 2023 19:53:15 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1ab1ce53ca6so9031065ad.0; Thu, 04 May 2023 19:53:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683255195; x=1685847195; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TvuQIwE86qT9nMkGXeQaDip5ug2GQu1BAKE7bYWgdwk=; b=jxvLXO0ysCTk5XQj17Rp4MPTljRhsg/NAlWqiFmGR2fpw55Cfg5sVLQNF9ke8zqu/N HHnWR+znibrRLrH9vcnvMDlm348iuI+SsyPL+KjDHd8kJ+kLygMtANYkoqlJA6z6lSGj QZNZWJy5SjgWh7ZGzeckqYUPsJuTsWIU94R5NJGqG7ornKXAjfQhUxU9ZW6eHYyHSwC8 XuNhhR9rjzN6nhEHsIDIEBvw8EKr9RR4JqVK8n0VmA4Fy2LIawRCSoZ2wFbIEnMX0Hu7 jCpsjNuzdvbOAUR1puJswLMYD3EbpysfH1e5Yu7q8B6TUU8LxJDGkmTXqTGuht3T2lUp xFiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683255195; x=1685847195; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=TvuQIwE86qT9nMkGXeQaDip5ug2GQu1BAKE7bYWgdwk=; b=PqDThDNkaN3j47pETaV8NVP7xh7UVdKs/7F/M3n0i3leM7jrWJPBORrWC1G5Hd0n5M myO3x9McEzAmQcqNVHJAPGAqhDHofCA8UbZFE6TV46kF6K0rOOjetTGJI+8qEsV7w2Ym +k35YNRMooPOugxhLl8PBJYQuDMjIYtX9d8Aqy8/JhR3zlDe0yGuLeTjGQ/+YhxxbqHL 1Fe6j0eXTF23dB5nx2cWGQPvlaqe7TjPLg5pNzGPb1/Af50VichO+ll0XCaw3Q0TKK+V UJgLAPr+EIBAXCUUBNxGJyERdreGt7o50F30Ctcr+r73BSvHy0qXVGfFhyP4y/XefvRt vmCA== X-Gm-Message-State: AC+VfDxHsFobOfsuzACz3v+Du0xLUnPQiO5XUhTCAryprwVlgJjZJ/M8 ENmIo7nSBf60R8ed7oyrG/8= X-Google-Smtp-Source: ACHHUZ5a9oH4I1uJO71H1fLGgVbhwllNxoxjP5ILVe8scfc+huKbvNVr33otWqWTE3YRZg/we43I2g== X-Received: by 2002:a17:903:2285:b0:1aa:f536:b1e2 with SMTP id b5-20020a170903228500b001aaf536b1e2mr6428524plh.62.1683255194928; Thu, 04 May 2023 19:53:14 -0700 (PDT) Received: from localhost ([203.59.190.92]) by smtp.gmail.com with ESMTPSA id a13-20020a170902eccd00b00186a2274382sm356805plh.76.2023.05.04.19.53.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 May 2023 19:53:14 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 05 May 2023 12:53:01 +1000 Message-Id: Cc: "Sumit Garg" , "Mark Rutland" , "Matthias Kaehlcke" , "Stephane Eranian" , "Stephen Boyd" , , "Tzung-Bi Shih" , "Lecopzer Chen" , , "Masayoshi Mizuma" , "Guenter Roeck" , "Pingfan Liu" , "Andi Kleen" , "Ian Rogers" , , , , "Randy Dunlap" , "Chen-Yu Tsai" , , , , , "Will Deacon" , , , "Marc Zyngier" , "Catalin Marinas" , "Daniel Thompson" Subject: Re: [PATCH v4 06/17] watchdog/perf: Rename watchdog_hld.c to watchdog_perf.c From: "Nicholas Piggin" To: "Douglas Anderson" , "Petr Mladek" , "Andrew Morton" X-Mailer: aerc 0.14.0 References: <20230504221349.1535669-1-dianders@chromium.org> <20230504151100.v4.6.Ice803cb078d0e15fb2cbf49132f096ee2bd4199d@changeid> In-Reply-To: <20230504151100.v4.6.Ice803cb078d0e15fb2cbf49132f096ee2bd4199d@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Fri May 5, 2023 at 8:13 AM AEST, Douglas Anderson wrote: > The code currently in "watchdog_hld.c" is for detecting hardlockups > using perf, as evidenced by the line in the Makefile that only > compiles this file if CONFIG_HARDLOCKUP_DETECTOR_PERF is > defined. Rename the file to prepare for the buddy hardlockup detector, > which doesn't use perf. > > It could be argued that the new name makes it less obvious that this > is a hardlockup detector. While true, it's not hard to remember that > the "perf" detector is always a hardlockup detector and it's nice not > to have names that are too convoluted. Better than the confusion that the perf version is *the* hardlockup detector IMO. Acked-by: Nicholas Piggin > > Signed-off-by: Douglas Anderson > --- > > Changes in v4: > - ("Rename watchdog_hld.c to watchdog_perf.c") new for v4. > > kernel/Makefile | 2 +- > kernel/{watchdog_hld.c =3D> watchdog_perf.c} | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > rename kernel/{watchdog_hld.c =3D> watchdog_perf.c} (99%) > > diff --git a/kernel/Makefile b/kernel/Makefile > index 10ef068f598d..406ccccc4dd3 100644 > --- a/kernel/Makefile > +++ b/kernel/Makefile > @@ -91,7 +91,7 @@ obj-$(CONFIG_FAIL_FUNCTION) +=3D fail_function.o > obj-$(CONFIG_KGDB) +=3D debug/ > obj-$(CONFIG_DETECT_HUNG_TASK) +=3D hung_task.o > obj-$(CONFIG_LOCKUP_DETECTOR) +=3D watchdog.o > -obj-$(CONFIG_HARDLOCKUP_DETECTOR_PERF) +=3D watchdog_hld.o > +obj-$(CONFIG_HARDLOCKUP_DETECTOR_PERF) +=3D watchdog_perf.o > obj-$(CONFIG_SECCOMP) +=3D seccomp.o > obj-$(CONFIG_RELAY) +=3D relay.o > obj-$(CONFIG_SYSCTL) +=3D utsname_sysctl.o > diff --git a/kernel/watchdog_hld.c b/kernel/watchdog_perf.c > similarity index 99% > rename from kernel/watchdog_hld.c > rename to kernel/watchdog_perf.c > index 96b717205952..c3d8ceb149da 100644 > --- a/kernel/watchdog_hld.c > +++ b/kernel/watchdog_perf.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * Detect hard lockups on a system > + * Detect hard lockups on a system using perf > * > * started by Don Zickus, Copyright (C) 2010 Red Hat, Inc. > * > --=20 > 2.40.1.521.gf1e218fcd8-goog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B9FCC77B73 for ; Fri, 5 May 2023 02:54:07 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QCFd96hnjz3cdk for ; Fri, 5 May 2023 12:54:05 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=jxvLXO0y; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::532; helo=mail-pg1-x532.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=jxvLXO0y; dkim-atps=neutral Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QCFcF6Pjhz2xJ6 for ; Fri, 5 May 2023 12:53:17 +1000 (AEST) Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-51452556acdso783143a12.2 for ; Thu, 04 May 2023 19:53:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683255195; x=1685847195; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TvuQIwE86qT9nMkGXeQaDip5ug2GQu1BAKE7bYWgdwk=; b=jxvLXO0ysCTk5XQj17Rp4MPTljRhsg/NAlWqiFmGR2fpw55Cfg5sVLQNF9ke8zqu/N HHnWR+znibrRLrH9vcnvMDlm348iuI+SsyPL+KjDHd8kJ+kLygMtANYkoqlJA6z6lSGj QZNZWJy5SjgWh7ZGzeckqYUPsJuTsWIU94R5NJGqG7ornKXAjfQhUxU9ZW6eHYyHSwC8 XuNhhR9rjzN6nhEHsIDIEBvw8EKr9RR4JqVK8n0VmA4Fy2LIawRCSoZ2wFbIEnMX0Hu7 jCpsjNuzdvbOAUR1puJswLMYD3EbpysfH1e5Yu7q8B6TUU8LxJDGkmTXqTGuht3T2lUp xFiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683255195; x=1685847195; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=TvuQIwE86qT9nMkGXeQaDip5ug2GQu1BAKE7bYWgdwk=; b=S9QE5ub9IwNoWBdvrKbROI9l/SLA9oFUT7fiG1MEwf3SBuYwcdyyyZNSRv+xAiagLB Na6wHIQR+kyXBirYF+/jb7amMc8Q9OP+iYICpYV5fc4IooBUxdHvNfjRwHWL4X26WS3V Z9tIDT4Hp89f5CawyzvP4snn6AgeQEl+IHF4qrnUcFy67M4nbUs7oNcpALt7ehe03edp lU9JjMZoHBx1uh50hWKK6NWqDdH/9PKctm7E2ZlNm04hshso0uf1Bd1plq6S/DGLNJZD QgQHBimFr3YcPT2Q1y9HRWCtGlbfzdlpbPlYa9E1A5ivzW7eM3H6kMg38CkpYQa47ADH YHZQ== X-Gm-Message-State: AC+VfDwRsbenQvdSBncLwW+RDzvmk/9wNQLgK8nJJQ1h5wECmVtyTeSy fzcNbsdgJY46L35BgBZ3xjU= X-Google-Smtp-Source: ACHHUZ5a9oH4I1uJO71H1fLGgVbhwllNxoxjP5ILVe8scfc+huKbvNVr33otWqWTE3YRZg/we43I2g== X-Received: by 2002:a17:903:2285:b0:1aa:f536:b1e2 with SMTP id b5-20020a170903228500b001aaf536b1e2mr6428524plh.62.1683255194928; Thu, 04 May 2023 19:53:14 -0700 (PDT) Received: from localhost ([203.59.190.92]) by smtp.gmail.com with ESMTPSA id a13-20020a170902eccd00b00186a2274382sm356805plh.76.2023.05.04.19.53.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 May 2023 19:53:14 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 05 May 2023 12:53:01 +1000 Message-Id: Subject: Re: [PATCH v4 06/17] watchdog/perf: Rename watchdog_hld.c to watchdog_perf.c From: "Nicholas Piggin" To: "Douglas Anderson" , "Petr Mladek" , "Andrew Morton" X-Mailer: aerc 0.14.0 References: <20230504221349.1535669-1-dianders@chromium.org> <20230504151100.v4.6.Ice803cb078d0e15fb2cbf49132f096ee2bd4199d@changeid> In-Reply-To: <20230504151100.v4.6.Ice803cb078d0e15fb2cbf49132f096ee2bd4199d@changeid> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ian Rogers , Randy Dunlap , Lecopzer Chen , kgdb-bugreport@lists.sourceforge.net, ricardo.neri@intel.com, Stephane Eranian , Guenter Roeck , sparclinux@vger.kernel.org, Will Deacon , Daniel Thompson , Andi Kleen , Chen-Yu Tsai , Matthias Kaehlcke , Catalin Marinas , Masayoshi Mizuma , ravi.v.shankar@intel.com, Tzung-Bi Shih , Stephen Boyd , Pingfan Liu , linux-arm-kernel@lists.infradead.org, Sumit Garg , ito-yuichi@fujitsu.com, linux-perf-users@vger.kernel.org, Marc Zyngier , linuxppc-dev@lists.ozlabs.org, davem@davemloft.net Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri May 5, 2023 at 8:13 AM AEST, Douglas Anderson wrote: > The code currently in "watchdog_hld.c" is for detecting hardlockups > using perf, as evidenced by the line in the Makefile that only > compiles this file if CONFIG_HARDLOCKUP_DETECTOR_PERF is > defined. Rename the file to prepare for the buddy hardlockup detector, > which doesn't use perf. > > It could be argued that the new name makes it less obvious that this > is a hardlockup detector. While true, it's not hard to remember that > the "perf" detector is always a hardlockup detector and it's nice not > to have names that are too convoluted. Better than the confusion that the perf version is *the* hardlockup detector IMO. Acked-by: Nicholas Piggin > > Signed-off-by: Douglas Anderson > --- > > Changes in v4: > - ("Rename watchdog_hld.c to watchdog_perf.c") new for v4. > > kernel/Makefile | 2 +- > kernel/{watchdog_hld.c =3D> watchdog_perf.c} | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > rename kernel/{watchdog_hld.c =3D> watchdog_perf.c} (99%) > > diff --git a/kernel/Makefile b/kernel/Makefile > index 10ef068f598d..406ccccc4dd3 100644 > --- a/kernel/Makefile > +++ b/kernel/Makefile > @@ -91,7 +91,7 @@ obj-$(CONFIG_FAIL_FUNCTION) +=3D fail_function.o > obj-$(CONFIG_KGDB) +=3D debug/ > obj-$(CONFIG_DETECT_HUNG_TASK) +=3D hung_task.o > obj-$(CONFIG_LOCKUP_DETECTOR) +=3D watchdog.o > -obj-$(CONFIG_HARDLOCKUP_DETECTOR_PERF) +=3D watchdog_hld.o > +obj-$(CONFIG_HARDLOCKUP_DETECTOR_PERF) +=3D watchdog_perf.o > obj-$(CONFIG_SECCOMP) +=3D seccomp.o > obj-$(CONFIG_RELAY) +=3D relay.o > obj-$(CONFIG_SYSCTL) +=3D utsname_sysctl.o > diff --git a/kernel/watchdog_hld.c b/kernel/watchdog_perf.c > similarity index 99% > rename from kernel/watchdog_hld.c > rename to kernel/watchdog_perf.c > index 96b717205952..c3d8ceb149da 100644 > --- a/kernel/watchdog_hld.c > +++ b/kernel/watchdog_perf.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * Detect hard lockups on a system > + * Detect hard lockups on a system using perf > * > * started by Don Zickus, Copyright (C) 2010 Red Hat, Inc. > * > --=20 > 2.40.1.521.gf1e218fcd8-goog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2220C77B7C for ; Fri, 5 May 2023 02:54:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:From:Subject: Cc:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yMNWZegwH8CH6//cOgiAn28TrZcs67xNTlpzzYPUcz8=; b=JM0qCL3OLF0tSY dTp9P7zk3gfAzaHBkmRQXy2BJA9MGmosj/xQpdmHg9vR8H+eITCoTRh+304Lk0yXA8jdjEMWah22J CbCSBZ0I0rS6f0D/g81I2SS7QXZWhkvMBzH8HOksFF41aQZTgoo8bG+YDU0AR13alkfkhsecbB5S2 ED3j6OgZOsFogFWampPA3BKO3U70CZfr3EW9KaUwObwoQQan7ejrVXUjMPIEaXyKd0RnD3s5SP03O B+J3uoecV5R2QLi+ZhCeECq2sMDU8CfPEpgiajerQt1TBJagXbPp39drxsya+CocTmJKQahZLuhpz fIXGR/ofD9R2Joqo6T+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pulZP-009a3j-2t; Fri, 05 May 2023 02:53:19 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pulZM-009a2o-0n for linux-arm-kernel@lists.infradead.org; Fri, 05 May 2023 02:53:18 +0000 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1aad5245632so8907095ad.3 for ; Thu, 04 May 2023 19:53:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683255195; x=1685847195; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TvuQIwE86qT9nMkGXeQaDip5ug2GQu1BAKE7bYWgdwk=; b=jxvLXO0ysCTk5XQj17Rp4MPTljRhsg/NAlWqiFmGR2fpw55Cfg5sVLQNF9ke8zqu/N HHnWR+znibrRLrH9vcnvMDlm348iuI+SsyPL+KjDHd8kJ+kLygMtANYkoqlJA6z6lSGj QZNZWJy5SjgWh7ZGzeckqYUPsJuTsWIU94R5NJGqG7ornKXAjfQhUxU9ZW6eHYyHSwC8 XuNhhR9rjzN6nhEHsIDIEBvw8EKr9RR4JqVK8n0VmA4Fy2LIawRCSoZ2wFbIEnMX0Hu7 jCpsjNuzdvbOAUR1puJswLMYD3EbpysfH1e5Yu7q8B6TUU8LxJDGkmTXqTGuht3T2lUp xFiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683255195; x=1685847195; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=TvuQIwE86qT9nMkGXeQaDip5ug2GQu1BAKE7bYWgdwk=; b=I2x+jWT788j01ye+Qa9l2mGPc/rdnpyHCcX3ZHY8EChlUTWE4sAyQdN6cDpGp2N9P0 ArVbUjbasGrXIJYka5K4kS77mUtjXxP9GagNbYm26bOF3/f/5WV41q7V6HvoYxy1JH9d RZScIGWNNiCqj8wntfz2yz+n+c84FmydMJayXQoxyX0XWeBHnbIXE8mKZSA9/eWGh8Ow idg2Zn/k44Q6348ZRBQVAMVKRuj6nYls6AhMqQW//20V7RhZGWauPexbAVmOi7LDyle1 Zc3DZtMaOAwAXA+Sli+hSkSMFSdZwShMsSKUoQHg3Ajw6ohbaY8I74UJ2/ug2hTdPshk APZg== X-Gm-Message-State: AC+VfDyibZvU+6olL4mpGWfpqUnAYRKO7F9lXuH/ZGjbcOyGUDOK3/8O Ds5I/ZcuzqMevLjzJL/wsI4= X-Google-Smtp-Source: ACHHUZ5a9oH4I1uJO71H1fLGgVbhwllNxoxjP5ILVe8scfc+huKbvNVr33otWqWTE3YRZg/we43I2g== X-Received: by 2002:a17:903:2285:b0:1aa:f536:b1e2 with SMTP id b5-20020a170903228500b001aaf536b1e2mr6428524plh.62.1683255194928; Thu, 04 May 2023 19:53:14 -0700 (PDT) Received: from localhost ([203.59.190.92]) by smtp.gmail.com with ESMTPSA id a13-20020a170902eccd00b00186a2274382sm356805plh.76.2023.05.04.19.53.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 May 2023 19:53:14 -0700 (PDT) Mime-Version: 1.0 Date: Fri, 05 May 2023 12:53:01 +1000 Message-Id: Cc: "Sumit Garg" , "Mark Rutland" , "Matthias Kaehlcke" , "Stephane Eranian" , "Stephen Boyd" , , "Tzung-Bi Shih" , "Lecopzer Chen" , , "Masayoshi Mizuma" , "Guenter Roeck" , "Pingfan Liu" , "Andi Kleen" , "Ian Rogers" , , , , "Randy Dunlap" , "Chen-Yu Tsai" , , , , , "Will Deacon" , , , "Marc Zyngier" , "Catalin Marinas" , "Daniel Thompson" Subject: Re: [PATCH v4 06/17] watchdog/perf: Rename watchdog_hld.c to watchdog_perf.c From: "Nicholas Piggin" To: "Douglas Anderson" , "Petr Mladek" , "Andrew Morton" X-Mailer: aerc 0.14.0 References: <20230504221349.1535669-1-dianders@chromium.org> <20230504151100.v4.6.Ice803cb078d0e15fb2cbf49132f096ee2bd4199d@changeid> In-Reply-To: <20230504151100.v4.6.Ice803cb078d0e15fb2cbf49132f096ee2bd4199d@changeid> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230504_195316_284484_0A60E3CD X-CRM114-Status: GOOD ( 23.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri May 5, 2023 at 8:13 AM AEST, Douglas Anderson wrote: > The code currently in "watchdog_hld.c" is for detecting hardlockups > using perf, as evidenced by the line in the Makefile that only > compiles this file if CONFIG_HARDLOCKUP_DETECTOR_PERF is > defined. Rename the file to prepare for the buddy hardlockup detector, > which doesn't use perf. > > It could be argued that the new name makes it less obvious that this > is a hardlockup detector. While true, it's not hard to remember that > the "perf" detector is always a hardlockup detector and it's nice not > to have names that are too convoluted. Better than the confusion that the perf version is *the* hardlockup detector IMO. Acked-by: Nicholas Piggin > > Signed-off-by: Douglas Anderson > --- > > Changes in v4: > - ("Rename watchdog_hld.c to watchdog_perf.c") new for v4. > > kernel/Makefile | 2 +- > kernel/{watchdog_hld.c => watchdog_perf.c} | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > rename kernel/{watchdog_hld.c => watchdog_perf.c} (99%) > > diff --git a/kernel/Makefile b/kernel/Makefile > index 10ef068f598d..406ccccc4dd3 100644 > --- a/kernel/Makefile > +++ b/kernel/Makefile > @@ -91,7 +91,7 @@ obj-$(CONFIG_FAIL_FUNCTION) += fail_function.o > obj-$(CONFIG_KGDB) += debug/ > obj-$(CONFIG_DETECT_HUNG_TASK) += hung_task.o > obj-$(CONFIG_LOCKUP_DETECTOR) += watchdog.o > -obj-$(CONFIG_HARDLOCKUP_DETECTOR_PERF) += watchdog_hld.o > +obj-$(CONFIG_HARDLOCKUP_DETECTOR_PERF) += watchdog_perf.o > obj-$(CONFIG_SECCOMP) += seccomp.o > obj-$(CONFIG_RELAY) += relay.o > obj-$(CONFIG_SYSCTL) += utsname_sysctl.o > diff --git a/kernel/watchdog_hld.c b/kernel/watchdog_perf.c > similarity index 99% > rename from kernel/watchdog_hld.c > rename to kernel/watchdog_perf.c > index 96b717205952..c3d8ceb149da 100644 > --- a/kernel/watchdog_hld.c > +++ b/kernel/watchdog_perf.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * Detect hard lockups on a system > + * Detect hard lockups on a system using perf > * > * started by Don Zickus, Copyright (C) 2010 Red Hat, Inc. > * > -- > 2.40.1.521.gf1e218fcd8-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel