From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06A09C7EE22 for ; Mon, 8 May 2023 01:35:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232487AbjEHBfH (ORCPT ); Sun, 7 May 2023 21:35:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232461AbjEHBfG (ORCPT ); Sun, 7 May 2023 21:35:06 -0400 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FE7B6A6D; Sun, 7 May 2023 18:35:05 -0700 (PDT) Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-52c6f81193cso2697372a12.1; Sun, 07 May 2023 18:35:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683509705; x=1686101705; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HU/mjP7Ap3TZEbMspJ2h6V5QMnaNP2Fmf0Z6DZ7aqHE=; b=L14pxpyy1Yc8+HiewNaTQb+1joh8hYSOP3/eSCWmsTMJDnd6785STORT8kwjkGo2Se 0i8+WagpXa8hJmR6t/LT7/sRKpmf+/KhkH0cbQcr2O6uaSzqM3ZscCvvnujixJA1Ohtz +TDocKRxq9Z7oFDz3JTmqk+qGJoW7sLBtQtnhjtT1o4Jbh/kSUAEi1DayHu/qBKsz9g0 OpLBg/55IJVmGITHmhJsf02wK5FPOZWzon9TAgZuxFxmSXGX2tWCWkv+4B/RWRpA1i4X sWQkpWNXRRqS1ceEPdkUmdpxnwjVOPZRPR/xEDB1D4aX3s85+ine5OJy93J2i3tU985P Pejg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683509705; x=1686101705; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HU/mjP7Ap3TZEbMspJ2h6V5QMnaNP2Fmf0Z6DZ7aqHE=; b=Ys/t9LjWq1idt0eml2xy1FTL9FrWKUGUIuIwDfQDHw44BptST341e71uPqysCe/Uqs pDF/YF3wjKkLeHtYhyzQA2VGGKk8NoT3XS4Gs1Cvwd5PCznfVIyUB/oRzCxwTO20iqFv DoTYPn4sCVChKtt/m0I7sRNMO3DKJEzMnCVWrGadxUibqFgx1fGp2eC2ssRFI3SFvl9X oruJN+MBlCjc9aq9oFMWiQmfc1tK4hZMUNeEmvnuMQwlJoDUdZn3m+U8tfX78dfpWMA9 uau4+h38qPuAViUjf9FK/ocG2gp+AryezQdk+KKDNzABYl3JUXB2sdBH6ahfPScLvZop CDMw== X-Gm-Message-State: AC+VfDxGj7mS1cil6Rq3V1zBQYCpA0U20UJzJmmef8FMNksSr4AjSmNN D78YdSbz3MtmqC+3wkwe97Y= X-Google-Smtp-Source: ACHHUZ7wpMgBNBiHQoh+RV3/6p2Xa+RAutLvbhq2Sce/KNFSy1fHPppI+Mwi880EABIulXrieqwNrA== X-Received: by 2002:a17:90b:19ce:b0:24e:1177:f467 with SMTP id nm14-20020a17090b19ce00b0024e1177f467mr9325645pjb.12.1683509704923; Sun, 07 May 2023 18:35:04 -0700 (PDT) Received: from localhost (58-6-235-78.tpgi.com.au. [58.6.235.78]) by smtp.gmail.com with ESMTPSA id n14-20020a170902968e00b001a4edbabad3sm5814967plp.230.2023.05.07.18.34.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 May 2023 18:35:04 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 08 May 2023 11:34:49 +1000 Message-Id: To: "Doug Anderson" Cc: "Petr Mladek" , "Andrew Morton" , "Sumit Garg" , "Mark Rutland" , "Matthias Kaehlcke" , "Stephane Eranian" , "Stephen Boyd" , , "Tzung-Bi Shih" , "Lecopzer Chen" , , "Masayoshi Mizuma" , "Guenter Roeck" , "Pingfan Liu" , "Andi Kleen" , "Ian Rogers" , , , , "Randy Dunlap" , "Chen-Yu Tsai" , , , , , "Will Deacon" , , , "Marc Zyngier" , "Catalin Marinas" , "Daniel Thompson" Subject: Re: [PATCH v4 05/17] watchdog/hardlockup: Rename touch_nmi_watchdog() to touch_hardlockup_watchdog() From: "Nicholas Piggin" X-Mailer: aerc 0.14.0 References: <20230504221349.1535669-1-dianders@chromium.org> <20230504151100.v4.5.I4e47cbfa1bb2ebbcdb5ca16817aa2887f15dc82c@changeid> In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org On Sat May 6, 2023 at 2:37 AM AEST, Doug Anderson wrote: > Hi, > > On Thu, May 4, 2023 at 7:51=E2=80=AFPM Nicholas Piggin wrote: > > > > On Fri May 5, 2023 at 8:13 AM AEST, Douglas Anderson wrote: > > > In preparation for the buddy hardlockup detector, rename > > > touch_nmi_watchdog() to touch_hardlockup_watchdog() to make it clear > > > that it will touch whatever hardlockup detector is configured. We'll > > > add a #define for the old name (touch_nmi_watchdog) so that we don't > > > have to touch every piece of code referring to the old name. > > > > Is this really helpful? Now it's got two names Could just leave it. > > If you insist then it'd be better just to rename everything in one > > go at the end of a merge window IMO. Conflicts would be trivial. > > I'm not picky here. I changed the name since Petr requested names to > be changed for any code I was touching [1] and so I threw this out as > a proposal. I agree that having two names can be confusing, but in > this case it didn't feel too terrible to me. > > I'd love to hear Petr's opinion on this name change. I'm happy with: > > a) This patch as it is. > > b) Dropping this patch (or perhaps just changing it to add comments). > > c) Changing this patch to rename all 70 uses of the old name. Assuming > this will go through Andrew Morton's tree, I'd be interested in > whether he's OK w/ this. > > d) Dropping this patch from this series but putting it on the > backburner to try to do later (so that the rename can happen at a time > when it's least disruptive). > > > > > Ideally this change would also rename the arch_touch_nmi_watchdog(), > > > but that is harder since arch_touch_nmi_watchdog() is exported with > > > EXPORT_SYMBOL() and thus is ABI. Add a comment next to the call to > > > hopefully alleviate some of the confusion here. > > > > We don't keep ABI fixed upstream. > > I'm happy to be corrected, but my understanding was that kernel devs > made an effort not to mess with things exported via "EXPORT_SYMBOL", > but things exported via "EXPORT_SYMBOL_GPL" were fair game. I don't think that's the case. If anything people might be a bit more inclined to accommodate GPL exports for out of tree modules that use them. > I guess maybe my patch calling it "ABI" is a stronger statement than > that, though. Doing a little more research, nobody wants to say that > things exported with "EXPORT_SYMBOL" are ABI, they just want to say > that we make an effort to have them be more stable. We wouldn't break any symbol for no reason, but in this case there is a good reason. If the name change is important for clarity then we change it. And this is about the easiest change for an out of tree module to deal with, so it should be no big deal for them. Thanks, Nick From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E954C77B7C for ; Mon, 8 May 2023 01:35:58 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QF3lc3Fc8z3fDQ for ; Mon, 8 May 2023 11:35:56 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=L14pxpyy; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::102f; helo=mail-pj1-x102f.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=L14pxpyy; dkim-atps=neutral Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QF3kh64jWz30QQ for ; Mon, 8 May 2023 11:35:06 +1000 (AEST) Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-24e2bbec3d5so2783209a91.3 for ; Sun, 07 May 2023 18:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683509705; x=1686101705; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HU/mjP7Ap3TZEbMspJ2h6V5QMnaNP2Fmf0Z6DZ7aqHE=; b=L14pxpyy1Yc8+HiewNaTQb+1joh8hYSOP3/eSCWmsTMJDnd6785STORT8kwjkGo2Se 0i8+WagpXa8hJmR6t/LT7/sRKpmf+/KhkH0cbQcr2O6uaSzqM3ZscCvvnujixJA1Ohtz +TDocKRxq9Z7oFDz3JTmqk+qGJoW7sLBtQtnhjtT1o4Jbh/kSUAEi1DayHu/qBKsz9g0 OpLBg/55IJVmGITHmhJsf02wK5FPOZWzon9TAgZuxFxmSXGX2tWCWkv+4B/RWRpA1i4X sWQkpWNXRRqS1ceEPdkUmdpxnwjVOPZRPR/xEDB1D4aX3s85+ine5OJy93J2i3tU985P Pejg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683509705; x=1686101705; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HU/mjP7Ap3TZEbMspJ2h6V5QMnaNP2Fmf0Z6DZ7aqHE=; b=Y7cCuXOtptIz0ghpzi3OxB2uPctmzeoOL/vNxZflFeXjkFdM7RYB5nFtTY/pDckP3a /ZYtFV+OW0/72vfM+M5japbVdwOmmOfTs0WDQwJ+WCRzasjKLPy13jm0RLUJlGlxUVU1 gLj/mJRYPqSsKl7/sDPinZevl6tYyZapZ0LCdzDpMpU4hJIYeVPgZ+lzp80AqLkyhqHS LpYVI/ZKaXItGIJZ/5RcAAEWKjIdu0GJf6cymHx9ASob4nwzp/J11F+iSJF13dUfu7pD V9L5iP01ZdFgNjSs2F1trYnGrWbLNJ9b2cgtPeKD8MsJ8ozDesw88OtY8wVwRDNxb0kb grLg== X-Gm-Message-State: AC+VfDz41+N/BRtffT1sny7lUgkVHJYDOFaynxPG9DhFkrHJLfZmRskU 0+xIVQantbJEWwZVAPzmR+4= X-Google-Smtp-Source: ACHHUZ7wpMgBNBiHQoh+RV3/6p2Xa+RAutLvbhq2Sce/KNFSy1fHPppI+Mwi880EABIulXrieqwNrA== X-Received: by 2002:a17:90b:19ce:b0:24e:1177:f467 with SMTP id nm14-20020a17090b19ce00b0024e1177f467mr9325645pjb.12.1683509704923; Sun, 07 May 2023 18:35:04 -0700 (PDT) Received: from localhost (58-6-235-78.tpgi.com.au. [58.6.235.78]) by smtp.gmail.com with ESMTPSA id n14-20020a170902968e00b001a4edbabad3sm5814967plp.230.2023.05.07.18.34.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 May 2023 18:35:04 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 08 May 2023 11:34:49 +1000 Message-Id: To: "Doug Anderson" Subject: Re: [PATCH v4 05/17] watchdog/hardlockup: Rename touch_nmi_watchdog() to touch_hardlockup_watchdog() From: "Nicholas Piggin" X-Mailer: aerc 0.14.0 References: <20230504221349.1535669-1-dianders@chromium.org> <20230504151100.v4.5.I4e47cbfa1bb2ebbcdb5ca16817aa2887f15dc82c@changeid> In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ian Rogers , Randy Dunlap , Lecopzer Chen , ravi.v.shankar@intel.com, kgdb-bugreport@lists.sourceforge.net, ricardo.neri@intel.com, Stephane Eranian , sparclinux@vger.kernel.org, Guenter Roeck , Will Deacon , Daniel Thompson , Andi Kleen , Chen-Yu Tsai , Matthias Kaehlcke , Catalin Marinas , Masayoshi Mizuma , Petr Mladek , Tzung-Bi Shih , Stephen Boyd , Pingfan Liu , linux-arm-kernel@lists.infradead.org, Sumit Garg , ito-yuichi@fujitsu.com, linux-perf-users@vger.kernel.org, Marc Zyngier , Andrew Morton , linuxppc-dev@lists.ozlabs.org, davem@davemloft.net Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat May 6, 2023 at 2:37 AM AEST, Doug Anderson wrote: > Hi, > > On Thu, May 4, 2023 at 7:51=E2=80=AFPM Nicholas Piggin wrote: > > > > On Fri May 5, 2023 at 8:13 AM AEST, Douglas Anderson wrote: > > > In preparation for the buddy hardlockup detector, rename > > > touch_nmi_watchdog() to touch_hardlockup_watchdog() to make it clear > > > that it will touch whatever hardlockup detector is configured. We'll > > > add a #define for the old name (touch_nmi_watchdog) so that we don't > > > have to touch every piece of code referring to the old name. > > > > Is this really helpful? Now it's got two names Could just leave it. > > If you insist then it'd be better just to rename everything in one > > go at the end of a merge window IMO. Conflicts would be trivial. > > I'm not picky here. I changed the name since Petr requested names to > be changed for any code I was touching [1] and so I threw this out as > a proposal. I agree that having two names can be confusing, but in > this case it didn't feel too terrible to me. > > I'd love to hear Petr's opinion on this name change. I'm happy with: > > a) This patch as it is. > > b) Dropping this patch (or perhaps just changing it to add comments). > > c) Changing this patch to rename all 70 uses of the old name. Assuming > this will go through Andrew Morton's tree, I'd be interested in > whether he's OK w/ this. > > d) Dropping this patch from this series but putting it on the > backburner to try to do later (so that the rename can happen at a time > when it's least disruptive). > > > > > Ideally this change would also rename the arch_touch_nmi_watchdog(), > > > but that is harder since arch_touch_nmi_watchdog() is exported with > > > EXPORT_SYMBOL() and thus is ABI. Add a comment next to the call to > > > hopefully alleviate some of the confusion here. > > > > We don't keep ABI fixed upstream. > > I'm happy to be corrected, but my understanding was that kernel devs > made an effort not to mess with things exported via "EXPORT_SYMBOL", > but things exported via "EXPORT_SYMBOL_GPL" were fair game. I don't think that's the case. If anything people might be a bit more inclined to accommodate GPL exports for out of tree modules that use them. > I guess maybe my patch calling it "ABI" is a stronger statement than > that, though. Doing a little more research, nobody wants to say that > things exported with "EXPORT_SYMBOL" are ABI, they just want to say > that we make an effort to have them be more stable. We wouldn't break any symbol for no reason, but in this case there is a good reason. If the name change is important for clarity then we change it. And this is about the easiest change for an out of tree module to deal with, so it should be no big deal for them. Thanks, Nick From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CC6CC77B75 for ; Mon, 8 May 2023 01:36:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:From:Subject:Cc: To:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OZUt3RGzIowktrt2CcRoZXXqQYlxS0DCVhHe1wzeShg=; b=mlbzxHK4gHa6qu TZ3gElgi5TcPb1yedGNbOAoQNPnLpXGWZYNGm83+vd2AFhhcDajaD0Dlsuq8uhMEdo3YSpYvW2mbr hudxxoIGCJdJD25uDXdVHYSpiU+Zz/WNDBPkirFknpxYt3UsPYJHQ0n7X/EqTKdigLIheKo7YaYK1 BhBKuxwFfw6c09t5Us2+dReFTSMZUIV+UsYtSMJ6MxL/nFG8Oq3B/ynzp6nsNNB3RYgn68lonTBP7 cCVqZ5WVdZQiutgciXd2QHJmdm9glgChKJgW+rbgfeLUElPnBk81VQ1joaPw6m6l/YMywwfLjQqQ3 ZzhwIYIcG4VklHAySrRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pvpmP-00GxSr-0n; Mon, 08 May 2023 01:35:09 +0000 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pvpmM-00GxS0-07 for linux-arm-kernel@lists.infradead.org; Mon, 08 May 2023 01:35:07 +0000 Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-24dec03ad8fso2787607a91.1 for ; Sun, 07 May 2023 18:35:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683509705; x=1686101705; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HU/mjP7Ap3TZEbMspJ2h6V5QMnaNP2Fmf0Z6DZ7aqHE=; b=L14pxpyy1Yc8+HiewNaTQb+1joh8hYSOP3/eSCWmsTMJDnd6785STORT8kwjkGo2Se 0i8+WagpXa8hJmR6t/LT7/sRKpmf+/KhkH0cbQcr2O6uaSzqM3ZscCvvnujixJA1Ohtz +TDocKRxq9Z7oFDz3JTmqk+qGJoW7sLBtQtnhjtT1o4Jbh/kSUAEi1DayHu/qBKsz9g0 OpLBg/55IJVmGITHmhJsf02wK5FPOZWzon9TAgZuxFxmSXGX2tWCWkv+4B/RWRpA1i4X sWQkpWNXRRqS1ceEPdkUmdpxnwjVOPZRPR/xEDB1D4aX3s85+ine5OJy93J2i3tU985P Pejg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683509705; x=1686101705; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HU/mjP7Ap3TZEbMspJ2h6V5QMnaNP2Fmf0Z6DZ7aqHE=; b=dcUGgHm5KB4tAmqBcXBPGOZlbCM4mGrZ3e9uM+tZjUzUhe4NyJcSBYPk7BWEFkL8QK Uk2r6uqB5zBGDMlQWRvlI8Zc97gcT36WVAy63saRbdlEADoRD20IcU60UJ3PGKi3F4fr X6NqLEmj7bA63NNdJD0dE9IOOYN5ipz2SCiY5K3ta4BAP9azvmuJ9QwDxOAeaYv6k5Cc 55a4Q57xZhfhbEi2yJLTCmbXPCztGhzPHthHPlxp37aaBgm0Ug2DaflVzWwP6/RSWN+v QgxU93MRtewbivIlWKPLiQ2NScP5L+DYQ+bfqxUYpcFKKrwsiqeBL2qlh9vCk+gRdZk1 LIQA== X-Gm-Message-State: AC+VfDxNar1awUifSWMe0TBxt0GxFppeMNBRR1r0/lL4I6jGOdQQpj2N kTpzJeaRIKxzg/cfFXywag0= X-Google-Smtp-Source: ACHHUZ7wpMgBNBiHQoh+RV3/6p2Xa+RAutLvbhq2Sce/KNFSy1fHPppI+Mwi880EABIulXrieqwNrA== X-Received: by 2002:a17:90b:19ce:b0:24e:1177:f467 with SMTP id nm14-20020a17090b19ce00b0024e1177f467mr9325645pjb.12.1683509704923; Sun, 07 May 2023 18:35:04 -0700 (PDT) Received: from localhost (58-6-235-78.tpgi.com.au. [58.6.235.78]) by smtp.gmail.com with ESMTPSA id n14-20020a170902968e00b001a4edbabad3sm5814967plp.230.2023.05.07.18.34.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 May 2023 18:35:04 -0700 (PDT) Mime-Version: 1.0 Date: Mon, 08 May 2023 11:34:49 +1000 Message-Id: To: "Doug Anderson" Cc: "Petr Mladek" , "Andrew Morton" , "Sumit Garg" , "Mark Rutland" , "Matthias Kaehlcke" , "Stephane Eranian" , "Stephen Boyd" , , "Tzung-Bi Shih" , "Lecopzer Chen" , , "Masayoshi Mizuma" , "Guenter Roeck" , "Pingfan Liu" , "Andi Kleen" , "Ian Rogers" , , , , "Randy Dunlap" , "Chen-Yu Tsai" , , , , , "Will Deacon" , , , "Marc Zyngier" , "Catalin Marinas" , "Daniel Thompson" Subject: Re: [PATCH v4 05/17] watchdog/hardlockup: Rename touch_nmi_watchdog() to touch_hardlockup_watchdog() From: "Nicholas Piggin" X-Mailer: aerc 0.14.0 References: <20230504221349.1535669-1-dianders@chromium.org> <20230504151100.v4.5.I4e47cbfa1bb2ebbcdb5ca16817aa2887f15dc82c@changeid> In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230507_183506_123279_A30D57AC X-CRM114-Status: GOOD ( 33.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0IE1heSA2LCAyMDIzIGF0IDI6MzcgQU0gQUVTVCwgRG91ZyBBbmRlcnNvbiB3cm90ZToK PiBIaSwKPgo+IE9uIFRodSwgTWF5IDQsIDIwMjMgYXQgNzo1MeKAr1BNIE5pY2hvbGFzIFBpZ2dp biA8bnBpZ2dpbkBnbWFpbC5jb20+IHdyb3RlOgo+ID4KPiA+IE9uIEZyaSBNYXkgNSwgMjAyMyBh dCA4OjEzIEFNIEFFU1QsIERvdWdsYXMgQW5kZXJzb24gd3JvdGU6Cj4gPiA+IEluIHByZXBhcmF0 aW9uIGZvciB0aGUgYnVkZHkgaGFyZGxvY2t1cCBkZXRlY3RvciwgcmVuYW1lCj4gPiA+IHRvdWNo X25taV93YXRjaGRvZygpIHRvIHRvdWNoX2hhcmRsb2NrdXBfd2F0Y2hkb2coKSB0byBtYWtlIGl0 IGNsZWFyCj4gPiA+IHRoYXQgaXQgd2lsbCB0b3VjaCB3aGF0ZXZlciBoYXJkbG9ja3VwIGRldGVj dG9yIGlzIGNvbmZpZ3VyZWQuIFdlJ2xsCj4gPiA+IGFkZCBhICNkZWZpbmUgZm9yIHRoZSBvbGQg bmFtZSAodG91Y2hfbm1pX3dhdGNoZG9nKSBzbyB0aGF0IHdlIGRvbid0Cj4gPiA+IGhhdmUgdG8g dG91Y2ggZXZlcnkgcGllY2Ugb2YgY29kZSByZWZlcnJpbmcgdG8gdGhlIG9sZCBuYW1lLgo+ID4K PiA+IElzIHRoaXMgcmVhbGx5IGhlbHBmdWw/IE5vdyBpdCdzIGdvdCB0d28gbmFtZXMgQ291bGQg anVzdCBsZWF2ZSBpdC4KPiA+IElmIHlvdSBpbnNpc3QgdGhlbiBpdCdkIGJlIGJldHRlciBqdXN0 IHRvIHJlbmFtZSBldmVyeXRoaW5nIGluIG9uZQo+ID4gZ28gYXQgdGhlIGVuZCBvZiBhIG1lcmdl IHdpbmRvdyBJTU8uIENvbmZsaWN0cyB3b3VsZCBiZSB0cml2aWFsLgo+Cj4gSSdtIG5vdCBwaWNr eSBoZXJlLiBJIGNoYW5nZWQgdGhlIG5hbWUgc2luY2UgUGV0ciByZXF1ZXN0ZWQgbmFtZXMgdG8K PiBiZSBjaGFuZ2VkIGZvciBhbnkgY29kZSBJIHdhcyB0b3VjaGluZyBbMV0gYW5kIHNvIEkgdGhy ZXcgdGhpcyBvdXQgYXMKPiBhIHByb3Bvc2FsLiBJIGFncmVlIHRoYXQgaGF2aW5nIHR3byBuYW1l cyBjYW4gYmUgY29uZnVzaW5nLCBidXQgaW4KPiB0aGlzIGNhc2UgaXQgZGlkbid0IGZlZWwgdG9v IHRlcnJpYmxlIHRvIG1lLgo+Cj4gSSdkIGxvdmUgdG8gaGVhciBQZXRyJ3Mgb3BpbmlvbiBvbiB0 aGlzIG5hbWUgY2hhbmdlLiBJJ20gaGFwcHkgd2l0aDoKPgo+IGEpIFRoaXMgcGF0Y2ggYXMgaXQg aXMuCj4KPiBiKSBEcm9wcGluZyB0aGlzIHBhdGNoIChvciBwZXJoYXBzIGp1c3QgY2hhbmdpbmcg aXQgdG8gYWRkIGNvbW1lbnRzKS4KPgo+IGMpIENoYW5naW5nIHRoaXMgcGF0Y2ggdG8gcmVuYW1l IGFsbCA3MCB1c2VzIG9mIHRoZSBvbGQgbmFtZS4gQXNzdW1pbmcKPiB0aGlzIHdpbGwgZ28gdGhy b3VnaCBBbmRyZXcgTW9ydG9uJ3MgdHJlZSwgSSdkIGJlIGludGVyZXN0ZWQgaW4KPiB3aGV0aGVy IGhlJ3MgT0sgdy8gdGhpcy4KPgo+IGQpIERyb3BwaW5nIHRoaXMgcGF0Y2ggZnJvbSB0aGlzIHNl cmllcyBidXQgcHV0dGluZyBpdCBvbiB0aGUKPiBiYWNrYnVybmVyIHRvIHRyeSB0byBkbyBsYXRl ciAoc28gdGhhdCB0aGUgcmVuYW1lIGNhbiBoYXBwZW4gYXQgYSB0aW1lCj4gd2hlbiBpdCdzIGxl YXN0IGRpc3J1cHRpdmUpLgo+Cj4KPiA+ID4gSWRlYWxseSB0aGlzIGNoYW5nZSB3b3VsZCBhbHNv IHJlbmFtZSB0aGUgYXJjaF90b3VjaF9ubWlfd2F0Y2hkb2coKSwKPiA+ID4gYnV0IHRoYXQgaXMg aGFyZGVyIHNpbmNlIGFyY2hfdG91Y2hfbm1pX3dhdGNoZG9nKCkgaXMgZXhwb3J0ZWQgd2l0aAo+ ID4gPiBFWFBPUlRfU1lNQk9MKCkgYW5kIHRodXMgaXMgQUJJLiBBZGQgYSBjb21tZW50IG5leHQg dG8gdGhlIGNhbGwgdG8KPiA+ID4gaG9wZWZ1bGx5IGFsbGV2aWF0ZSBzb21lIG9mIHRoZSBjb25m dXNpb24gaGVyZS4KPiA+Cj4gPiBXZSBkb24ndCBrZWVwIEFCSSBmaXhlZCB1cHN0cmVhbS4KPgo+ IEknbSBoYXBweSB0byBiZSBjb3JyZWN0ZWQsIGJ1dCBteSB1bmRlcnN0YW5kaW5nIHdhcyB0aGF0 IGtlcm5lbCBkZXZzCj4gbWFkZSBhbiBlZmZvcnQgbm90IHRvIG1lc3Mgd2l0aCB0aGluZ3MgZXhw b3J0ZWQgdmlhICJFWFBPUlRfU1lNQk9MIiwKPiBidXQgdGhpbmdzIGV4cG9ydGVkIHZpYSAiRVhQ T1JUX1NZTUJPTF9HUEwiIHdlcmUgZmFpciBnYW1lLgoKSSBkb24ndCB0aGluayB0aGF0J3MgdGhl IGNhc2UuIElmIGFueXRoaW5nIHBlb3BsZSBtaWdodCBiZSBhIGJpdCBtb3JlCmluY2xpbmVkIHRv IGFjY29tbW9kYXRlIEdQTCBleHBvcnRzIGZvciBvdXQgb2YgdHJlZSBtb2R1bGVzIHRoYXQgdXNl CnRoZW0uCgo+IEkgZ3Vlc3MgbWF5YmUgbXkgcGF0Y2ggY2FsbGluZyBpdCAiQUJJIiBpcyBhIHN0 cm9uZ2VyIHN0YXRlbWVudCB0aGFuCj4gdGhhdCwgdGhvdWdoLiBEb2luZyBhIGxpdHRsZSBtb3Jl IHJlc2VhcmNoLCBub2JvZHkgd2FudHMgdG8gc2F5IHRoYXQKPiB0aGluZ3MgZXhwb3J0ZWQgd2l0 aCAiRVhQT1JUX1NZTUJPTCIgYXJlIEFCSSwgdGhleSBqdXN0IHdhbnQgdG8gc2F5Cj4gdGhhdCB3 ZSBtYWtlIGFuIGVmZm9ydCB0byBoYXZlIHRoZW0gYmUgbW9yZSBzdGFibGUuCgpXZSB3b3VsZG4n dCBicmVhayBhbnkgc3ltYm9sIGZvciBubyByZWFzb24sIGJ1dCBpbiB0aGlzIGNhc2UgdGhlcmUg aXMgYQpnb29kIHJlYXNvbi4gSWYgdGhlIG5hbWUgY2hhbmdlIGlzIGltcG9ydGFudCBmb3IgY2xh cml0eSB0aGVuIHdlIGNoYW5nZQppdC4gQW5kIHRoaXMgaXMgYWJvdXQgdGhlIGVhc2llc3QgY2hh bmdlIGZvciBhbiBvdXQgb2YgdHJlZSBtb2R1bGUgdG8KZGVhbCB3aXRoLCBzbyBpdCBzaG91bGQg YmUgbm8gYmlnIGRlYWwgZm9yIHRoZW0uCgpUaGFua3MsCk5pY2sKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK