From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754686AbdLFELe (ORCPT ); Tue, 5 Dec 2017 23:11:34 -0500 Received: from mail-by2nam01on0083.outbound.protection.outlook.com ([104.47.34.83]:9024 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754559AbdLFELb (ORCPT ); Tue, 5 Dec 2017 23:11:31 -0500 From: Appana Durga Kedareswara Rao To: "robh+dt@kernel.org" , Mike Looijmans , "mark.rutland@arm.com" , "dan.j.williams@intel.com" , "vinod.koul@intel.com" , "Michal Simek (michal.simek@xilinx.com)" , "moritz.fischer@ettus.com" , "laurent.pinchart@ideasonboard.com" , "Jose.Abreu@synopsys.com" , "luis@debethencourt.com" CC: "dmaengine@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH v6 2/3] dmaeninge: xilinx_dma: Fix bug in multiple frame stores scenario in vdma Thread-Topic: [PATCH v6 2/3] dmaeninge: xilinx_dma: Fix bug in multiple frame stores scenario in vdma Thread-Index: AQHSbigaLBieap1iKkOicfxgOahJDaFFMYKAgegxYOCAAAArIA== Date: Wed, 6 Dec 2017 04:11:12 +0000 Message-ID: References: <1484372155-19423-1-git-send-email-appanad@xilinx.com> <1484372155-19423-3-git-send-email-appanad@xilinx.com> <296cffff-3847-4217-bd94-ac72fe044f73@topic.nl> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=appanad@xilinx.com; x-originating-ip: [182.72.145.30] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR02MB1689;6:rvHjvIqdkgHcl4Kxs9vds2bo/IMOHnSxVwwKHqFnZSwmke68I3IynFvYS3KIqlqhUoDSlFpHFJLI2GL32mO1vNmF8h1wSZusSuA1tkuJZIIVNguXOLmvCDUAO5pB149frOUc6/Ufphrp6F/Xhk95Zs5VozFlr2FZUXKFKZCG//xByiXprIT1gO0VRWGFlSb5DQmF3TApjuX/G4Hf88HYS1SspBZO6uuIbaMhSeEIyvWCGXcq6wGlajYmpVzX4u9uhVfGg9aanF3fn1s4CkDEPI6yPwD5QvsYvfMKfhQZgpTRHlHmomLm3ED3jK24cj9U0d4BPhW/U94NP8C+rtzT1S56c2dDbBGTFruEncbwDuY=;5:2+JL6/y+Fcaji/sMLOBeRm/MK69UzJO6rOswEUbBoKj5n6O3O9jbHJOumWc20zRAXflqgYHzO+dLUeiUzXSTvWlVh8J67GT0/BG9oTxkNBMM9VS9ftZ3vsETu/hoEhn/7RCyz1tAu0g8MTRW25ft8n/0wQHdLQKG2w6+3S72Yqw=;24:R3Jndb/dM569KR8JPPNH89/+SJRnSK+QMZUnVIV8l5jBSz7bn076jN1+lStIvE00cjNEzT6LS7RJZgBn9KzfPGgSXK+PxCUOpUpr+hEAsW4=;7:+TZxJ9ArkoCuLKE3kjnkV36Mn7Z24ucmIR6uwDuuXqRq2OCROLAqHxkuuGMCicL1TVbhioVrwEBGQOThZAvZXK1nlii2xBbDJjKsCAtISDEe1gXzU4IffXEGgPFPDaxY3yt9ZItL7sjQ26a9ovG6VKOEkQGebecMVVXHawN/vP0oqDdoGZgxmGBvr8r+2h/Ti8lDYkpNPi1ES557AXasYAfdv2Q1hY/kTYPJe+zAAbhatgTNRRK9uin4JJ9buGn3 x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 6bbda33b-22e3-4c9f-aa15-08d53c5f6383 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(7168020)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603286);SRVR:CY1PR02MB1689; x-ms-traffictypediagnostic: CY1PR02MB1689: x-ld-processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231022)(3002001)(6055026)(6041248)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(20161123564025)(6072148)(201708071742011);SRVR:CY1PR02MB1689;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:CY1PR02MB1689; x-forefront-prvs: 05134F8B4F x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(346002)(366004)(189003)(199004)(51914003)(24454002)(377424004)(2900100001)(2950100002)(2201001)(2501003)(101416001)(97736004)(81156014)(8676002)(33656002)(81166006)(5660300001)(7416002)(86362001)(2906002)(74316002)(106356001)(3280700002)(7736002)(305945005)(105586002)(6116002)(8936002)(3846002)(3660700001)(102836003)(99286004)(9686003)(6436002)(6246003)(478600001)(77096006)(55236003)(6506006)(54906003)(7696005)(25786009)(55016002)(4326008)(110136005)(53936002)(316002)(229853002)(68736007)(93886005)(76176011)(14454004)(66066001)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR02MB1689;H:CY1PR02MB1692.namprd02.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6bbda33b-22e3-4c9f-aa15-08d53c5f6383 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2017 04:11:13.0363 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR02MB1689 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vB64BeqA023109 Hi Mike Looijmans, Thanks for the review... Sorry for the long delay in the reply... Please find comments inline... >On 14-01-17 06:35, Kedareswara rao Appana wrote: >>  When VDMA is configured for more than one frame in the h/w. >>  For example h/w is configured for n number of frames, user >>  Submits n number of frames and triggered the DMA using issue_pending API. >> >>  In the current driver flow we are submitting one frame at a time, >>  But we should submit all the n number of frames at one time >>  As the h/w is configured for n number of frames. > >The hardware can always handle a single frame submission, by using the "park" >bit. This would make a good "cyclic" implementation too (using vdma as >framebuffer). > >It could also handle all cases for "k" frames where n%k==0 (n is a multiple of >k) by simply replicating the frame pointers. Agree with your comments will fix it in the next version. Somehow didn't get enough time to send next version of the patch series. Will modify the driver as per your comments and will post next version of the patch series at the earliest... Regards, Kedar. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Appana Durga Kedareswara Rao Subject: RE: [PATCH v6 2/3] dmaeninge: xilinx_dma: Fix bug in multiple frame stores scenario in vdma Date: Wed, 6 Dec 2017 04:11:12 +0000 Message-ID: References: <1484372155-19423-1-git-send-email-appanad@xilinx.com> <1484372155-19423-3-git-send-email-appanad@xilinx.com> <296cffff-3847-4217-bd94-ac72fe044f73@topic.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: "robh+dt@kernel.org" , Mike Looijmans , "mark.rutland@arm.com" , "dan.j.williams@intel.com" , "vinod.koul@intel.com" , "Michal Simek (michal.simek@xilinx.com)" , "moritz.fischer@ettus.com" , "laurent.pinchart@ideasonboard.com" , "Jose.Abreu@synopsys.com" , "luis@debethencourt.com" Cc: "dmaengine@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org SGkgTWlrZSBMb29pam1hbnMsDQoNCglUaGFua3MgZm9yIHRoZSByZXZpZXcuLi4NCglTb3JyeSBm b3IgdGhlIGxvbmcgZGVsYXkgaW4gdGhlIHJlcGx5Li4uDQpQbGVhc2UgZmluZCBjb21tZW50cyBp bmxpbmUuLi4gDQoNCjxTbmlwPg0KPk9uIDE0LTAxLTE3IDA2OjM1LCBLZWRhcmVzd2FyYSByYW8g QXBwYW5hIHdyb3RlOg0KPj7CoMKgV2hlbiBWRE1BIGlzIGNvbmZpZ3VyZWQgZm9yIG1vcmUgdGhh biBvbmUgZnJhbWUgaW4gdGhlIGgvdy4NCj4+wqDCoEZvciBleGFtcGxlIGgvdyBpcyBjb25maWd1 cmVkIGZvciBuIG51bWJlciBvZiBmcmFtZXMsIHVzZXINCj4+wqDCoFN1Ym1pdHMgbiBudW1iZXIg b2YgZnJhbWVzIGFuZCB0cmlnZ2VyZWQgdGhlIERNQSB1c2luZyBpc3N1ZV9wZW5kaW5nIEFQSS4N Cj4+DQo+PsKgwqBJbiB0aGUgY3VycmVudCBkcml2ZXIgZmxvdyB3ZSBhcmUgc3VibWl0dGluZyBv bmUgZnJhbWUgYXQgYSB0aW1lLA0KPj7CoMKgQnV0IHdlIHNob3VsZCBzdWJtaXQgYWxsIHRoZSBu IG51bWJlciBvZiBmcmFtZXMgYXQgb25lIHRpbWUNCj4+wqDCoEFzIHRoZSBoL3cgaXMgY29uZmln dXJlZCBmb3IgbiBudW1iZXIgb2YgZnJhbWVzLg0KPg0KPlRoZSBoYXJkd2FyZSBjYW4gYWx3YXlz IGhhbmRsZSBhIHNpbmdsZSBmcmFtZSBzdWJtaXNzaW9uLCBieSB1c2luZyB0aGUgInBhcmsiDQo+ Yml0LiBUaGlzIHdvdWxkIG1ha2UgYSBnb29kICJjeWNsaWMiIGltcGxlbWVudGF0aW9uIHRvbyAo dXNpbmcgdmRtYSBhcw0KPmZyYW1lYnVmZmVyKS4NCj4NCj5JdCBjb3VsZCBhbHNvIGhhbmRsZSBh bGwgY2FzZXMgZm9yICJrIiBmcmFtZXMgd2hlcmUgbiVrPT0wIChuIGlzIGEgbXVsdGlwbGUgb2YN Cj5rKSBieSBzaW1wbHkgcmVwbGljYXRpbmcgdGhlIGZyYW1lIHBvaW50ZXJzLg0KDQpBZ3JlZSB3 aXRoIHlvdXIgY29tbWVudHMgd2lsbCBmaXggaXQgaW4gdGhlIG5leHQgdmVyc2lvbi4NClNvbWVo b3cgZGlkbid0IGdldCBlbm91Z2ggdGltZSB0byBzZW5kIG5leHQgdmVyc2lvbiBvZiB0aGUgcGF0 Y2ggc2VyaWVzLg0KV2lsbCBtb2RpZnkgdGhlIGRyaXZlciBhcyBwZXIgeW91ciBjb21tZW50cyBh bmQgd2lsbCBwb3N0IG5leHQgdmVyc2lvbiBvZiB0aGUgcGF0Y2ggc2VyaWVzIGF0IHRoZSBlYXJs aWVzdC4uLiANCg0KUmVnYXJkcywNCktlZGFyLg0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: appanad@xilinx.com (Appana Durga Kedareswara Rao) Date: Wed, 6 Dec 2017 04:11:12 +0000 Subject: [PATCH v6 2/3] dmaeninge: xilinx_dma: Fix bug in multiple frame stores scenario in vdma In-Reply-To: References: <1484372155-19423-1-git-send-email-appanad@xilinx.com> <1484372155-19423-3-git-send-email-appanad@xilinx.com> <296cffff-3847-4217-bd94-ac72fe044f73@topic.nl> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mike Looijmans, Thanks for the review... Sorry for the long delay in the reply... Please find comments inline... >On 14-01-17 06:35, Kedareswara rao Appana wrote: >>??When VDMA is configured for more than one frame in the h/w. >>??For example h/w is configured for n number of frames, user >>??Submits n number of frames and triggered the DMA using issue_pending API. >> >>??In the current driver flow we are submitting one frame at a time, >>??But we should submit all the n number of frames at one time >>??As the h/w is configured for n number of frames. > >The hardware can always handle a single frame submission, by using the "park" >bit. This would make a good "cyclic" implementation too (using vdma as >framebuffer). > >It could also handle all cases for "k" frames where n%k==0 (n is a multiple of >k) by simply replicating the frame pointers. Agree with your comments will fix it in the next version. Somehow didn't get enough time to send next version of the patch series. Will modify the driver as per your comments and will post next version of the patch series at the earliest... Regards, Kedar.