All of lore.kernel.org
 help / color / mirror / Atom feed
From: "zhenhua.luo@freescale.com" <zhenhua.luo@freescale.com>
To: Bob Cochran <yocto@mindchasers.com>
Cc: "meta-freescale@yoctoproject.org"
	<meta-freescale@yoctoproject.org>,
	"Sandeep.Malik@freescale.com" <Sandeep.Malik@freescale.com>
Subject: Re: [meta-fsl-ppc][PATCH] procps: stop disabling	reverse path filtering
Date: Fri, 9 Jan 2015 03:15:45 +0000	[thread overview]
Message-ID: <CY1PR0301MB071526D4938E249D5463158FE4440@CY1PR0301MB0715.namprd03.prod.outlook.com> (raw)
In-Reply-To: <1420651631-8510-1-git-send-email-yocto@mindchasers.com>

Hi Bob, 

It would be better if ASF enablement can be checked dynamically, then the rp_filter option can be enabled/disabled automatically. 

Maybe we can check the AS_FASTPATH option enablement in ${STAGING_KERNEL_DIR}/.config. 
	if [ "`grep "CONFIG_AS_FAST=y" ${STAGING_KERNEL_DIR}/.config`" ]; then
		for keyword in
			net.ipv4.conf.default.rp_filter \
			net.ipv4.conf.all.rp_filter \
		do
			sed -i 's,'"$keyword"'=.*,'"$keyword"'=0,' ${D}${sysconfdir}/sysctl.conf
		done
	fi


Best Regards,

Zhenhua

> -----Original Message-----
> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> bounces@yoctoproject.org] On Behalf Of Bob Cochran
> Sent: Thursday, January 08, 2015 1:27 AM
> To: meta-freescale@yoctoproject.org
> Subject: [meta-freescale] [meta-fsl-ppc][PATCH] procps: stop disabling reverse
> path filtering
> 
> The procps append file that overwrites sysctl.conf and disables reverse path
> filtering isn't needed in the default QorIQ configuration.  It is only needed if
> Application Specific Fastpath is enabled in the linux-qoriq kernel.
> 
> Signed-off-by: Bob Cochran <yocto@mindchasers.com>
> ---
>  recipes-extended/procps/procps_%.bbappend |    9 ---------
>  1 file changed, 9 deletions(-)
>  delete mode 100644 recipes-extended/procps/procps_%.bbappend
> 
> diff --git a/recipes-extended/procps/procps_%.bbappend b/recipes-
> extended/procps/procps_%.bbappend
> deleted file mode 100644
> index face0cc..0000000
> --- a/recipes-extended/procps/procps_%.bbappend
> +++ /dev/null
> @@ -1,9 +0,0 @@
> -do_install_append_qoriq-ppc() {
> -    for keyword in \
> -        net.ipv4.conf.default.rp_filter \
> -        net.ipv4.conf.all.rp_filter \
> -    ; do
> -        sed -i 's,'"$keyword"'=.*,'"$keyword"'=0,' ${D}${sysconfdir}/sysctl.conf
> -    done
> -}
> -
> --
> 1.7.9.5
> 
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale


  reply	other threads:[~2015-01-09  3:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07 17:27 [meta-fsl-ppc][PATCH] procps: stop disabling reverse path filtering Bob Cochran
2015-01-09  3:15 ` zhenhua.luo [this message]
2015-01-09 11:48   ` Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY1PR0301MB071526D4938E249D5463158FE4440@CY1PR0301MB0715.namprd03.prod.outlook.com \
    --to=zhenhua.luo@freescale.com \
    --cc=Sandeep.Malik@freescale.com \
    --cc=meta-freescale@yoctoproject.org \
    --cc=yocto@mindchasers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.