RE: Perftest fails when declaring support for MW_TYPE_2A

["Kalderon, Michal" <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>]

> From: Jason Gunthorpe [mailto:jgg-uk2M96/98Pc@public.gmane.org]
> Sent: Wednesday, November 01, 2017 6:45 PM
> To: Kalderon, Michal <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> Cc: Zohar Ben Aharon <zoharb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>; Gil Rockah
> <gilr-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>; lunnys-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; idos-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org; linux-
> rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Elior, Ariel <Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>;
> leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; Amrani, Ram <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> Subject: Re: Perftest fails when declaring support for MW_TYPE_2A
> 
> On Wed, Nov 01, 2017 at 03:35:54PM +0000, Kalderon, Michal wrote:
> > Hi Mellanox/ Accelio,
> >
> > There is a very old commit in perftest 96050b8b that assumes bit 23 in
> > device cap flags means there is driver support for contiguous buffer
> > allocation of user data
> 
> Wow.
> 
> This is
> 
> https://github.com/linux-
> rdma/perftest/blob/master/src/perftest_resources.c#L272
> 
> And it is totally unacceptable for upstream'ed open source code to have crap
> like this.
> 
> Delete it.
> 
> Jason
Zohar, 

Can you comment? Would you like me to provide a patch ? or would you rather? 
Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html