From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anil Gurumurthy Date: Fri, 06 May 2016 06:44:01 +0000 Subject: RE: [PATCH resend v2] [SCSI] bfa: fix bfa_fcb_itnim_alloc() error handling Message-Id: List-Id: References: <20160413111441.GC4247@mwanda> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Martin K. Petersen" , Dan Carpenter Cc: Sudarsana Kalluru , "James E.J. Bottomley" , linux-scsi , "kernel-janitors@vger.kernel.org" Apologies for the delay. Patch looks good. Acked by: Anil Gurumurthy -----Original Message----- From: Martin K. Petersen [mailto:martin.petersen@oracle.com] Sent: 06 May 2016 06:54 To: Dan Carpenter Cc: Anil Gurumurthy ; Sudarsana Kalluru ; James E.J. Bottomley ; Martin K. Petersen ; linux-scsi ; kernel-janitors@vger.kernel.org Subject: Re: [PATCH resend v2] [SCSI] bfa: fix bfa_fcb_itnim_alloc() error handling >>>>> "Dan" = Dan Carpenter writes: Dan> The caller assumes that "itnim" is NULL on error and non-NULL on Dan> success but really "itnim" is uninitialized on error. This Dan> function should just use normal error handling where it returns Dan> zero on success and negative on failure. Anil, please review: https://patchwork.kernel.org/patch/8820751/ -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anil Gurumurthy Subject: RE: [PATCH resend v2] [SCSI] bfa: fix bfa_fcb_itnim_alloc() error handling Date: Fri, 6 May 2016 06:44:01 +0000 Message-ID: References: <20160413111441.GC4247@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: Received: from mail-by2on0131.outbound.protection.outlook.com ([207.46.100.131]:43973 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751171AbcEFHQc convert rfc822-to-8bit (ORCPT ); Fri, 6 May 2016 03:16:32 -0400 In-Reply-To: Content-Language: en-US Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "Martin K. Petersen" , Dan Carpenter Cc: Sudarsana Kalluru , "James E.J. Bottomley" , linux-scsi , "kernel-janitors@vger.kernel.org" Apologies for the delay. Patch looks good. Acked by: Anil Gurumurthy -----Original Message----- From: Martin K. Petersen [mailto:martin.petersen@oracle.com] Sent: 06 May 2016 06:54 To: Dan Carpenter Cc: Anil Gurumurthy ; Sudarsana Kalluru ; James E.J. Bottomley ; Martin K. Petersen ; linux-scsi ; kernel-janitors@vger.kernel.org Subject: Re: [PATCH resend v2] [SCSI] bfa: fix bfa_fcb_itnim_alloc() error handling >>>>> "Dan" == Dan Carpenter writes: Dan> The caller assumes that "itnim" is NULL on error and non-NULL on Dan> success but really "itnim" is uninitialized on error. This Dan> function should just use normal error handling where it returns Dan> zero on success and negative on failure. Anil, please review: https://patchwork.kernel.org/patch/8820751/ -- Martin K. Petersen Oracle Linux Engineering