All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
	"fio@vger.kernel.org" <fio@vger.kernel.org>,
	Jens Axboe <axboe@kernel.dk>
Cc: Hans Holmberg <Hans.Holmberg@wdc.com>
Subject: Re: [PATCH] t/zbd: Improve pass condition of test case #49
Date: Wed, 22 Jul 2020 09:38:31 +0000	[thread overview]
Message-ID: <CY4PR04MB37516E34B9611326EA07F6F0E7790@CY4PR04MB3751.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20200722092633.350291-1-shinichiro.kawasaki@wdc.com

On 2020/07/22 18:26, Shin'ichiro Kawasaki wrote:
> The test case #49 runs write workloads with verify option. It checks read
> bytes for verify, but it does not check written bytes. To make test pass
> condition more accurate, add check of the written bytes.
> 
> Fixes: 4844bb4716ab ("t/zbd: Add test case to check zonecapacity option")
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> ---
>  t/zbd/test-zbd-support | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/t/zbd/test-zbd-support b/t/zbd/test-zbd-support
> index e53a20c5..471a3487 100755
> --- a/t/zbd/test-zbd-support
> +++ b/t/zbd/test-zbd-support
> @@ -856,6 +856,7 @@ test49() {
>  		    --zonecapacity=${capacity} \
>  		    --verify=md5  --size=${size} >>"${logfile}.${test_number}" 2>&1 ||
>  	return $?
> +    check_written $((capacity * 2)) || return $?
>      check_read $((capacity * 2)) || return $?
>  }
>  
> 

Looks good.

Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>

-- 
Damien Le Moal
Western Digital Research


  reply	other threads:[~2020-07-22  9:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-22  9:26 [PATCH] t/zbd: Improve pass condition of test case #49 Shin'ichiro Kawasaki
2020-07-22  9:38 ` Damien Le Moal [this message]
2020-07-22 13:38 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR04MB37516E34B9611326EA07F6F0E7790@CY4PR04MB3751.namprd04.prod.outlook.com \
    --to=damien.lemoal@wdc.com \
    --cc=Hans.Holmberg@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.