From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Verma, Shally" <Shally.Verma@cavium.com>
Subject: Re: [PATCH v2 2/6] lib/cryptodev: add asym op support in
	cryptodev
Date: Wed, 9 May 2018 07:33:32 +0000
Message-ID: <CY4PR0701MB36346ED665E7A20CED781877F0990@CY4PR0701MB3634.namprd07.prod.outlook.com>
References: <1522927489-23668-1-git-send-email-shally.verma@caviumnetworks.com>
 <1522927489-23668-3-git-send-email-shally.verma@caviumnetworks.com>
 <348A99DA5F5B7549AA880327E580B4358947CD2B@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Doherty, Declan" <declan.doherty@intel.com>, "Athreya, Narayana Prasad"
 <NarayanaPrasad.Athreya@cavium.com>, "Sahu, Sunila" <Sunila.Sahu@cavium.com>,
 "Gupta, Ashish" <Ashish.Gupta@cavium.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "Sahu, Sunila" <Sunila.Sahu@cavium.com>, "Gupta, Ashish"
 <Ashish.Gupta@cavium.com>
To: "Trahe, Fiona" <fiona.trahe@intel.com>, "De Lara Guarch, Pablo"
 <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam02on0054.outbound.protection.outlook.com [104.47.36.54])
 by dpdk.org (Postfix) with ESMTP id 3179F235
 for <dev@dpdk.org>; Wed,  9 May 2018 09:33:42 +0200 (CEST)
In-Reply-To: <348A99DA5F5B7549AA880327E580B4358947CD2B@IRSMSX103.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



>-----Original Message-----
>From: Trahe, Fiona [mailto:fiona.trahe@intel.com]
>Sent: 08 May 2018 20:14
>To: Verma, Shally <Shally.Verma@cavium.com>; De Lara Guarch, Pablo <pablo.=
de.lara.guarch@intel.com>
>Cc: Doherty, Declan <declan.doherty@intel.com>; Athreya, Narayana Prasad <=
NarayanaPrasad.Athreya@cavium.com>; Sahu, Sunila
><Sunila.Sahu@cavium.com>; Gupta, Ashish <Ashish.Gupta@cavium.com>; dev@dpd=
k.org; Sahu, Sunila <Sunila.Sahu@cavium.com>;
>Gupta, Ashish <Ashish.Gupta@cavium.com>
>Subject: RE: [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptode=
v
>
>Hi Shally,
>
>
>> -----Original Message-----
>> From: Shally Verma [mailto:shally.verma@caviumnetworks.com]
>> Sent: Thursday, April 5, 2018 12:25 PM
>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
>> Cc: Doherty, Declan <declan.doherty@intel.com>; Trahe, Fiona <fiona.trah=
e@intel.com>;
>> pathreya@caviumnetworks.com; ssahu@caviumnetworks.com; agupta@caviumnetw=
orks.com;
>> dev@dpdk.org; Sunila Sahu <sunila.sahu@caviumnetworks.com>; Ashish Gupta
>> <ashish.gupta@caviumnetworks.com>
>> Subject: [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev
>>
>>  struct rte_cryptodev_sym_session *
>>  rte_cryptodev_sym_session_create(struct rte_mempool *mp)
>>  {
>>  	struct rte_cryptodev_sym_session *sess;
>>
>>  	/* Allocate a session structure from the session pool */
>> -	if (rte_mempool_get(mp, (void **)&sess)) {
>> +	if (rte_mempool_get(mp, (void *)&sess)) {
>[Fiona] Are you introducing a bug here?
>The fn expects a void **
[Shally] Ya. My bad. Missed it.

>Also this will need rebasing - the latest code has an extra byte.