From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Verma, Shally" <Shally.Verma@cavium.com>
Subject: Re: [PATCH v3 4/5] compress/zlib: support burst
 enqueue/dequeue
Date: Mon, 23 Jul 2018 17:14:26 +0000
Message-ID: <CY4PR0701MB3634D6C72203CEC71EC6EF4EF0560@CY4PR0701MB3634.namprd07.prod.outlook.com>
References: <1532197069-24224-1-git-send-email-shally.verma@caviumnetworks.com>
 <1532197069-24224-5-git-send-email-shally.verma@caviumnetworks.com>
 <20180723095357.5a85b206@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "Athreya, Narayana Prasad"
 <NarayanaPrasad.Athreya@cavium.com>, "Challa, Mahipal"
 <Mahipal.Challa@cavium.com>, "Gupta, Ashish" <Ashish.Gupta@cavium.com>,
 "Sahu, Sunila" <Sunila.Sahu@cavium.com>, "Sahu, Sunila"
 <Sunila.Sahu@cavium.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam03on0072.outbound.protection.outlook.com [104.47.40.72])
 by dpdk.org (Postfix) with ESMTP id DD9D1235
 for <dev@dpdk.org>; Mon, 23 Jul 2018 19:18:21 +0200 (CEST)
In-Reply-To: <20180723095357.5a85b206@xeon-e3>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



>-----Original Message-----
>From: Stephen Hemminger <stephen@networkplumber.org>
>Sent: 23 July 2018 22:24
>To: Verma, Shally <Shally.Verma@cavium.com>
>Cc: pablo.de.lara.guarch@intel.com; dev@dpdk.org; Athreya, Narayana Prasad=
 <NarayanaPrasad.Athreya@cavium.com>; Challa,
>Mahipal <Mahipal.Challa@cavium.com>; Gupta, Ashish <Ashish.Gupta@cavium.co=
m>; Sahu, Sunila <Sunila.Sahu@cavium.com>;
>Sahu, Sunila <Sunila.Sahu@cavium.com>
>Subject: Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueu=
e/dequeue
>
>External Email
>
>On Sat, 21 Jul 2018 23:47:48 +0530
>Shally Verma <shally.verma@caviumnetworks.com> wrote:
>
>> -/** Parse comp xform and set private xform/stream parameters */
>> +/** Compute next mbuf in the list, assign data buffer and length,
>> + *  returns 0 if mbuf is NULL
>> + */
>> +#define COMPUTE_BUF(mbuf, data, len)         \
>> +             ((mbuf =3D mbuf->next) ?          \
>> +             (data =3D rte_pktmbuf_mtod(mbuf, uint8_t *)),     \
>> +             (len =3D rte_pktmbuf_data_len(mbuf)) : 0)
>> +
>
>Could this be an inline not a macro?
[Shally] Again what goes in favour of inline here? Just curious to know if =
DPDK has any preferred guidelines regarding this?

Thanks
Shally=20