All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] unisys: visornic: Replace symbolic perms with octal
@ 2017-04-04 19:15 Thomas Jespersen
  2017-04-05 12:45 ` Kershner, David A
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Jespersen @ 2017-04-04 19:15 UTC (permalink / raw)
  To: david.kershner
  Cc: gregkh, Timothy.Sell, david.binder, jon.frisch, erik.arfvidson,
	sparmaintainer, devel, linux-kernel

Replace symbolic permissions S_IRUSR and S_IWUSR for their octal
counterparts

Signed-off-by: Thomas Jespersen <laumann.thomas@gmail.com>
---
 drivers/staging/unisys/visornic/visornic_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c
index feece91..1008337 100644
--- a/drivers/staging/unisys/visornic/visornic_main.c
+++ b/drivers/staging/unisys/visornic/visornic_main.c
@@ -2146,11 +2146,11 @@ static int visornic_init(void)
 	if (!visornic_debugfs_dir)
 		return err;
 
-	ret = debugfs_create_file("info", S_IRUSR, visornic_debugfs_dir, NULL,
+	ret = debugfs_create_file("info", 0400, visornic_debugfs_dir, NULL,
 				  &debugfs_info_fops);
 	if (!ret)
 		goto cleanup_debugfs;
-	ret = debugfs_create_file("enable_ints", S_IWUSR, visornic_debugfs_dir,
+	ret = debugfs_create_file("enable_ints", 0200, visornic_debugfs_dir,
 				  NULL, &debugfs_enable_ints_fops);
 	if (!ret)
 		goto cleanup_debugfs;
-- 
2.10.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH] unisys: visornic: Replace symbolic perms with octal
  2017-04-04 19:15 [PATCH] unisys: visornic: Replace symbolic perms with octal Thomas Jespersen
@ 2017-04-05 12:45 ` Kershner, David A
  0 siblings, 0 replies; 2+ messages in thread
From: Kershner, David A @ 2017-04-05 12:45 UTC (permalink / raw)
  To: Thomas Jespersen
  Cc: gregkh, Sell, Timothy C, Binder, David Anthony, Frisch, Jon,
	erik.arfvidson, *S-Par-Maintainer, devel, linux-kernel

> -----Original Message-----
> From: Thomas Jespersen [mailto:laumann.thomas@gmail.com]
> Sent: Tuesday, April 4, 2017 3:15 PM
> To: Kershner, David A <David.Kershner@unisys.com>
> Cc: gregkh@linuxfoundation.org; Sell, Timothy C
> <Timothy.Sell@unisys.com>; Binder, David Anthony
> <David.Binder@unisys.com>; Frisch, Jon <Jon.Frisch@unisys.com>;
> erik.arfvidson@unisys.com; *S-Par-Maintainer
> <SParMaintainer@unisys.com>; devel@driverdev.osuosl.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] unisys: visornic: Replace symbolic perms with octal
> 

Should the subject line say "staging: unisys: visornic" instead of just 
"unisys: visornic:"?

Besides that, I'm fine with this patch and have tested it on s-Par. 

David Kershner

> Replace symbolic permissions S_IRUSR and S_IWUSR for their octal
> counterparts
> 
> Signed-off-by: Thomas Jespersen <laumann.thomas@gmail.com>
> ---
>  drivers/staging/unisys/visornic/visornic_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visornic/visornic_main.c
> b/drivers/staging/unisys/visornic/visornic_main.c
> index feece91..1008337 100644
> --- a/drivers/staging/unisys/visornic/visornic_main.c
> +++ b/drivers/staging/unisys/visornic/visornic_main.c
> @@ -2146,11 +2146,11 @@ static int visornic_init(void)
>  	if (!visornic_debugfs_dir)
>  		return err;
> 
> -	ret = debugfs_create_file("info", S_IRUSR, visornic_debugfs_dir,
> NULL,
> +	ret = debugfs_create_file("info", 0400, visornic_debugfs_dir, NULL,
>  				  &debugfs_info_fops);
>  	if (!ret)
>  		goto cleanup_debugfs;
> -	ret = debugfs_create_file("enable_ints", S_IWUSR,
> visornic_debugfs_dir,
> +	ret = debugfs_create_file("enable_ints", 0200, visornic_debugfs_dir,
>  				  NULL, &debugfs_enable_ints_fops);
>  	if (!ret)
>  		goto cleanup_debugfs;
> --
> 2.10.2

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-05 12:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-04 19:15 [PATCH] unisys: visornic: Replace symbolic perms with octal Thomas Jespersen
2017-04-05 12:45 ` Kershner, David A

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.