From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04C2AC433B4 for ; Thu, 1 Apr 2021 02:08:29 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 78F5D61009 for ; Thu, 1 Apr 2021 02:08:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78F5D61009 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9BD76140FA7; Thu, 1 Apr 2021 04:08:27 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id D93FE40142 for ; Thu, 1 Apr 2021 04:08:25 +0200 (CEST) IronPort-SDR: MGlbv+V7gu+DohvJJ2wH5+wb9l5QaZEpGZzN7dRUlWy3cLN4BNEGEd5L8NWigKHAURGY3VZBzC 8mcIARcQXHfA== X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="212380025" X-IronPort-AV: E=Sophos;i="5.81,295,1610438400"; d="scan'208";a="212380025" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2021 19:08:24 -0700 IronPort-SDR: 8dmHLU/BK9Q8FDjV/JMbg61iq8/A8IGmlU8xq5lv7apnpkmC+JRBp2nRgeKDGUrUhFjR6TxUcz Ln5BrD7SFH6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,295,1610438400"; d="scan'208";a="455762854" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 31 Mar 2021 19:08:24 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 31 Mar 2021 19:08:24 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 31 Mar 2021 19:08:23 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 31 Mar 2021 19:08:23 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 31 Mar 2021 19:08:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SAL8RI5+jHx9IJrsO2Cst9HslFt1QketGMQHO4tc+K2QJFDDp0y8sj+rT+BoJJH6xU/wa9zc3iFGCTyvUHIQwjUAqKmRh7P4hom5ggcEU1P/JoAttoJj8ry4PUPwoXFYm3wPx0kkwolw8bmjXA+P9fCbvRlab3eh/N+/XTBQrCYI6ppVyqg8mmGpUy6pHfuTWNDb03ci8U+sC5HB59th4hsKc71vBoq0EDYYGH6EEtn+3aQiuKQzLnGJLdnorSumtiw1RfeX73CYTtmnYpDUn30ET4DBoDEJQ9ibyKze/JR8Qi9jCsUAmq2+puSo95gA100JIRuLodK0cM1pe5B/2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1iuql8v2XTGs8kgC1kG0BMdiEBlwcN2TCjI2v/JKMt8=; b=eYiteqnGhEd+BObX+Ov4ytL0lYc6zSxfglKrDRdASzg/gajVblEHxWVuFyZBFNfFpVwtelCgN7GiwCibpKKjTPQR95mVOsxV9azi+gyAUnEvqH27ugmFDpR8cInzi9mIUar+XuMC4I784lMl208u53kaDDVXYts7tRuj4/C0fFz6fsJVSq6J69Kx1QD9DS4/YNXK2gGDtexx3l/67eYhHmzqszr5PkkOSVYvuSE98BZAJ+ABC5D7DTseQkZRm79BbygzqkJoI30u5OttTrAyULG8sf2OddV9tOtMM9YQjX7n0oZVIGi4ZDWZN3Gb96Gr9CIGPOjFPWt/AHWrZfDq/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1iuql8v2XTGs8kgC1kG0BMdiEBlwcN2TCjI2v/JKMt8=; b=ZrtX/zP+QAS4WNhPd2Cg4U1d8XBDI8uFjRe+a/TSMkCW09RWN2BCM9fYPq58mETmTWA8PH2hUctoKza5fe12D0TxfVLw86d8CbFAq0kghECKkvM+2aMJRpd3LyIStPf3OxWtlJKP6nCvhuCIA7Ii3a38CklAeuP4Aj16rMavVWM= Received: from CY4PR1101MB2069.namprd11.prod.outlook.com (2603:10b6:910:17::7) by CY4PR11MB1317.namprd11.prod.outlook.com (2603:10b6:903:2f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.33; Thu, 1 Apr 2021 02:08:20 +0000 Received: from CY4PR1101MB2069.namprd11.prod.outlook.com ([fe80::54f9:e389:a014:91ca]) by CY4PR1101MB2069.namprd11.prod.outlook.com ([fe80::54f9:e389:a014:91ca%2]) with mapi id 15.20.3977.033; Thu, 1 Apr 2021 02:08:20 +0000 From: "Xu, Ting" To: "Guo, Jia" , "Yang, Qiming" , "Zhang, Qi Z" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2 3/3] net/ice: support FDIR for IP fragment packet Thread-Index: AQHXILXMCSoEtQGAlkOWcAnDpiZ8Uqqe9UFA Date: Thu, 1 Apr 2021 02:08:20 +0000 Message-ID: References: <20210317034335.31974-1-jia.guo@intel.com> <20210324135407.60637-1-jia.guo@intel.com> <20210324135407.60637-4-jia.guo@intel.com> In-Reply-To: <20210324135407.60637-4-jia.guo@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 49414baa-7b05-4e32-72f8-08d8f4b305db x-ms-traffictypediagnostic: CY4PR11MB1317: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3383; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TLWGt2BJjV5VyGC0cQwNK97n7Xz5K9FOvCrySdzcI+1zmTm5veI87vgPC2pBkPaIpIyuUhkDh3Lrs0XWrI9h0VIE2J9zXkca0JBx5PcQblGykmrPlA3WDdIPURdc6ljOfncH2Q35P3BKyv6JdXXpXuyIcEtCn6rqBYAYzmX2N0EIqArzOsVC4Ufh2UpQrPDigl6W+OTR3Pe2dqFBFNd5F7OumNxqAM5X1jWHCxNI46i+kCg/xR8gVTsN6i7t0qOUqGOg3QAF/V7sgJrbwptZ5isx55TfZRdZu727RDmgztOKD0bHtUSKULAav+UgfCNO52R0ULMa6DzP/f6oPQBPnnlQv/xV92ry6SkUFfcqCq8P6ye41cQ/jzns1OUtYHPuE+ON6JfL1E7emuLmeNs+taLU/hEN2Ix2SBx6IMYk/2Xvu0RCqb+ReVgaXxPri1uTlguVd12Kj0Jcl5I1esbSEwGHgWfTF8FRfoim0PIE3uCpoPY0BOmeu8WtJ+j6YyTzlkL8ZOQ690edCI4G3ImMhnHayld2vhjK+xmqWyiskQFYbmJCKJKx2OK+c3vaenQamByrQd6XWFnEyWTEaMwpzeVkq0ScF74lRMGk3DD1dXlYrtGUSkilMpRzPAxByipceYHLSG9KjA08USbgITncyaeWwSqJN2LTQoWwY6bQhEM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1101MB2069.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(366004)(376002)(346002)(39860400002)(136003)(66446008)(53546011)(52536014)(64756008)(66556008)(66946007)(76116006)(66476007)(110136005)(4326008)(316002)(478600001)(6506007)(5660300002)(38100700001)(55016002)(9686003)(71200400001)(7696005)(6636002)(2906002)(83380400001)(86362001)(26005)(33656002)(186003)(8936002)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?LvTbgXUvobhlXRi31RDcdjL/LRllPZzikK2zT/XAKRB+FVW1o52RRoaHpbEw?= =?us-ascii?Q?2UciPtKvHXI3M3Iv7Rhxn6W5v55MoYxrx1QHPp01ZNUXS3Ch09LYkRoc02U0?= =?us-ascii?Q?VRL/K5nf5g01JTanv7ld/O7vXYPuUqqai/GX1wm8mro/5Ura7pVF1e4oKZ4M?= =?us-ascii?Q?cokKpsSUY8MEcjx2+519//hop3sqibf63TyHMFFYSrMkkyrB0n/Mj5HMXonP?= =?us-ascii?Q?jjtQlQycPM0zlP4eWnloxoXcytMssg6pAGy/RrmWZ2zjpwkN9Q3W7q8jLQDV?= =?us-ascii?Q?F38iZrU5Qv0+ttluT9g/tiFXygWQcwTqYy1ECdswS/MQ+ILeegVqHnCQkvZU?= =?us-ascii?Q?A5ao6Eb02oC21KRWfrTteDaZ9DBR2aaZf6qto57gP+d6NtL4rVOUngGimFZX?= =?us-ascii?Q?Atj4iGVgw3nuBKeAgpPZ0rVjnDpJOWsxEzedbph0ZRR5T/NkRn4EI8QHL7Uc?= =?us-ascii?Q?DEZV479XpuKLjXMA/CkrMuM3cX1IF/YR6ypqGsMsZOBCazlTr5987I7jS/Hz?= =?us-ascii?Q?e5lC2CWimYLVq6JaaTGHyU5C5aY1BUd/BlwkkBf3N++rfcAPu6uzZEWeNWZd?= =?us-ascii?Q?7EhH/c2PVMlOB5yzGKvfTf17ZMKwFIf8UhwNSmQqLyPeG+rMNWZET91caNkK?= =?us-ascii?Q?QcAv39eriVXcCO/JhXSzoO4tIKQEb5gcjMkuMneiSSceKzFJvaUkUp7meUDa?= =?us-ascii?Q?pM5nLW/IPKHMXH+IhuSCyUHnUzmFUh3/XMoEjVTtbC2K+Ri6GB5vRKOLosUW?= =?us-ascii?Q?0FB6V7OUYcpwJ4V0kDDHZDhpiHX+TKWTO19DRDFl6W+cEHbXcqGbNX5NRTgJ?= =?us-ascii?Q?xAm6HBH6cqYuUUOtaRl4h6vSuql3dgwrAWksELu9a9Y/IjcPRd7AbExJ3cuU?= =?us-ascii?Q?JPfs0ypAmevT5ZASaSyBAJkWtBxWJtRW/Nbx+Qz4ZrfW6peiwTAH7fhOec5g?= =?us-ascii?Q?fXLQ7MBDwoSg3i2A0RUt73EjkmIifDbBVMmX0XZoNUsef6TuQ3Kw2QRP+DmN?= =?us-ascii?Q?qMOmBwhxBMiVhJBGoaj3qvaTVdHOHKvwHRIzst/cGxh0fILQcWCxCk/d9JNO?= =?us-ascii?Q?w+7h0xjKWtylZ6FWUE464nVFbdN+Ln1CgXQDs15Iw9HOTyFiyvX3kARs17w3?= =?us-ascii?Q?YbUEEQ+IezkkXMYf1dzZhgt5tOIbm0Z9UXdLHLoIXcUHQ9U1Txa6Savn/rJe?= =?us-ascii?Q?ZpXNdhETiZdVxIkKxPU1S0+vIGrr1EOG8l46MJS67MwGrmokRv9KWNJIwCAH?= =?us-ascii?Q?uJ3BrnD+VilPo6PDF5cfawmpYwjL2FQ1s65YwMt3UO6qQZBBNF11qPxx+Zia?= =?us-ascii?Q?HCxqJLI3FhE/nSoe4EFmVjR5?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1101MB2069.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49414baa-7b05-4e32-72f8-08d8f4b305db X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2021 02:08:20.5807 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HU55iL3EChTRhkmGaIV/dIazrBPE0ThTm9cHsu4ATriZRa3nnbnK0nk/1mxyhJP4chXUMHFitSNwH9tU8lEvaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1317 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 3/3] net/ice: support FDIR for IP fragment packet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Jeff See inline Best Regards, Xu Ting > -----Original Message----- > From: Guo, Jia > Sent: Wednesday, March 24, 2021 9:54 PM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: Xu, Ting ; dev@dpdk.org; Guo, Jia > Subject: [PATCH v2 3/3] net/ice: support FDIR for IP fragment packet >=20 > New FDIR parsing are added to handle the fragmented IPv4/IPv6 packet. >=20 > Signed-off-by: Jeff Guo > --- > drivers/net/ice/ice_fdir_filter.c | 96 +++++++++++++++++++++++++++---- > 1 file changed, 85 insertions(+), 11 deletions(-) >=20 > diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir= _filter.c > index 3af5812660..3504d3c6c2 100644 > --- a/drivers/net/ice/ice_fdir_filter.c > +++ b/drivers/net/ice/ice_fdir_filter.c > @@ -24,7 +24,7 @@ > #define ICE_FDIR_INSET_ETH_IPV4 (\ > ICE_FDIR_INSET_ETH | \ > ICE_INSET_IPV4_SRC | ICE_INSET_IPV4_DST | ICE_INSET_IPV4_TOS | \ > - ICE_INSET_IPV4_TTL | ICE_INSET_IPV4_PROTO) > + ICE_INSET_IPV4_TTL | ICE_INSET_IPV4_PROTO | ICE_INSET_IPV4_PKID) >=20 Skip... > @@ -1700,8 +1719,6 @@ ice_fdir_parse_pattern(__rte_unused struct > ice_adapter *ad, > /* Check IPv4 mask and update input set */ > if (ipv4_mask->hdr.version_ihl || > ipv4_mask->hdr.total_length || > - ipv4_mask->hdr.packet_id || > - ipv4_mask->hdr.fragment_offset || > ipv4_mask->hdr.hdr_checksum) { > rte_flow_error_set(error, EINVAL, >=20 > RTE_FLOW_ERROR_TYPE_ITEM, > @@ -1710,6 +1727,20 @@ ice_fdir_parse_pattern(__rte_unused struct > ice_adapter *ad, > return -rte_errno; > } >=20 May need to check if ipv4_last exists before using it. > + if (ipv4_last->hdr.version_ihl || > + ipv4_last->hdr.type_of_service || > + ipv4_last->hdr.time_to_live || > + ipv4_last->hdr.total_length | > + ipv4_last->hdr.next_proto_id || > + ipv4_last->hdr.hdr_checksum || > + ipv4_last->hdr.src_addr || > + ipv4_last->hdr.dst_addr) { > + rte_flow_error_set(error, EINVAL, > + > RTE_FLOW_ERROR_TYPE_ITEM, > + item, "Invalid IPv4 last."); > + return -rte_errno; > + } > + > if (ipv4_mask->hdr.dst_addr =3D=3D UINT32_MAX) > *input_set |=3D ICE_INSET_IPV4_DST; > if (ipv4_mask->hdr.src_addr =3D=3D UINT32_MAX) @@ - Skip... > 2.20.1