From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Date: Wed, 8 May 2019 14:54:13 +0000 Subject: [Buildroot] [arc-buildroot] [PATCH] linux-tools/perf: Respect TARGET_CFLAGS In-Reply-To: <20190508143127.GD31209@scaer> References: <20190418093902.41835-1-abrodkin@synopsys.com> <20190418114336.61f3f404@windsurf> <20190427175603.GA27252@scaer> <20190508143127.GD31209@scaer> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi Yann, > -----Original Message----- > From: Yann E. MORIN > Sent: Wednesday, May 8, 2019 5:31 PM > To: Alexey Brodkin > Cc: Thomas Petazzoni ; buildroot at busybox.net; ARC Buildroot mailing list > ; Arnout Vandecappelle > Subject: Re: [arc-buildroot] [Buildroot] [PATCH] linux-tools/perf: Respect TARGET_CFLAGS > > Alexey, All, > > On 2019-05-08 13:19 +0000, Alexey Brodkin spake thusly: > > From: Yann E. MORIN On Behalf Of Yann E. MORIN > [--SNIP--] > > > I'm not too fond of this, but what about the following: > > > > > > diff --git a/arch/arch.mk.arc b/arch/arch.mk.arc > > > new file mode 100644 > > > index 0000000000..83503841b6 > > > --- /dev/null > > > +++ b/arch/arch.mk.arc > > > @@ -0,0 +1,3 @@ > > > +ifeq ($(BR2_arcle),y) > > > +ARCH_TOOLCHAIN_WRAPPER_OPTS = -matomic > > > +endif > > > diff --git a/toolchain/toolchain-wrapper.mk > > > b/toolchain/toolchain-wrapper.mk > > > index ca66fa7ba4..8f872506ec 100644 > > > --- a/toolchain/toolchain-wrapper.mk > > > +++ b/toolchain/toolchain-wrapper.mk > > > @@ -17,6 +17,7 @@ TOOLCHAIN_WRAPPER_ARGS = > > > $($(PKG)_TOOLCHAIN_WRAPPER_ARGS) > > > TOOLCHAIN_WRAPPER_ARGS += -DBR_SYSROOT='"$(STAGING_SUBDIR)"' > > > > > > TOOLCHAIN_WRAPPER_OPTS = \ > > > + $(ARCH_TOOLCHAIN_WRAPPER_OPTS) \ > > > $(call qstrip,$(BR2_SSP_OPTION)) \ > > > $(call qstrip,$(BR2_TARGET_OPTIMIZATION)) > > > > That looks good to me with only one change: prefer generic "BR2_arc" > > instead of little-endian only "BR2_arcle". > > Yes, of course, it was just a quicky to demo what I was thinking... > > > Care to send-out a patch? > > Aw... But *you* are the arc guy! ;-) > > OK, will do. I'm all for sending it myself but it will be like I'm stealing your nice idea - nothing more that that. Want me to do that instead? -Alexey