Michel, My review is only for the first patch. Slava ________________________________ From: Michel Dänzer Sent: Thursday, June 28, 2018 4:26:28 AM To: Abramov, Slava Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Subject: Re: [PATCH xf86-video-amdgpu 1/2] Remove #if 0'd code On 2018-06-27 08:29 PM, Abramov, Slava wrote: > I wonder how '#if 0' made its way upstream, but besides this It was inherited from xf86-video-ati, where it's been in drmmode_display.c since that file was first added (in 2009). > Reviewed-by: Slava Abramov Thanks Slava (and Alex)! Is that only for this patch, or also for patch 2 of the series? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer