From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Abramov, Slava" Subject: Re: [PATCH xf86-video-amdgpu 1/2] Remove #if 0'd code Date: Thu, 28 Jun 2018 15:38:16 +0000 Message-ID: References: <20180627163941.18737-1-michel@daenzer.net> , Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0747887315==" Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?iso-8859-1?Q?Michel_D=E4nzer?= Cc: "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" --===============0747887315== Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CY4PR12MB13042A723690746E0A043209FE4F0CY4PR12MB1304namp_" --_000_CY4PR12MB13042A723690746E0A043209FE4F0CY4PR12MB1304namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Michel, My review is only for the first patch. Slava ________________________________ From: Michel D=E4nzer Sent: Thursday, June 28, 2018 4:26:28 AM To: Abramov, Slava Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Subject: Re: [PATCH xf86-video-amdgpu 1/2] Remove #if 0'd code On 2018-06-27 08:29 PM, Abramov, Slava wrote: > I wonder how '#if 0' made its way upstream, but besides this It was inherited from xf86-video-ati, where it's been in drmmode_display.c since that file was first added (in 2009). > Reviewed-by: Slava Abramov Thanks Slava (and Alex)! Is that only for this patch, or also for patch 2 of the series? -- Earthling Michel D=E4nzer | http://www.amd.com Libre software enthusiast | Mesa and X developer --_000_CY4PR12MB13042A723690746E0A043209FE4F0CY4PR12MB1304namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

Michel,

My review is only for the first patch.

Slava

From: Michel D=E4nzer <m= ichel-otUistvHUpPR7s880joybQ@public.gmane.org>
Sent: Thursday, June 28, 2018 4:26:28 AM
To: Abramov, Slava
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH xf86-video-amdgpu 1/2] Remove #if 0'd code

On 2018-06-27 08:29 PM, Abramov, Slava wrote:
> I wonder how '#if 0' made its way upstream, but besides this

It was inherited from xf86-video-ati, where it's been in
drmmode_display.c since that file was first added (in 2009).

> Reviewed-by: Slava Abramov <slava.abramov-5C7GfCeVMHo@public.gmane.org>

Thanks Slava (and Alex)! Is that only for this patch, or also for patch
2 of the series?

--
Earthling Michel D=E4nzer &n= bsp; | &nb= sp; http://www.amd.com
Libre software enthusiast &n= bsp; | &nb= sp; Mesa and X developer

--_000_CY4PR12MB13042A723690746E0A043209FE4F0CY4PR12MB1304namp_-- --===============0747887315== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBt YWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg== --===============0747887315==--