From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Kumar, Ravi1" <Ravi1.Kumar@amd.com>
Subject: Re: [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD
Date: Tue, 17 Apr 2018 06:11:32 +0000
Message-ID: <CY4PR12MB150927C257B1F2B229866A10AEB70@CY4PR12MB1509.namprd12.prod.outlook.com>
References: <1520584520-130522-1-git-send-email-Ravi1.kumar@amd.com>
 <1521462233-13590-1-git-send-email-Ravi1.kumar@amd.com>
 <E115CCD9D858EF4F90C690B0DCB4D8976CCC30CE@IRSMSX108.ger.corp.intel.com>
 <CY4PR12MB15095C3BE2B0A5F584ED6803AEA60@CY4PR12MB1509.namprd12.prod.outlook.com>
 <E115CCD9D858EF4F90C690B0DCB4D8976CCD50FB@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam02on0080.outbound.protection.outlook.com [104.47.36.80])
 by dpdk.org (Postfix) with ESMTP id 2CE19AAC2
 for <dev@dpdk.org>; Tue, 17 Apr 2018 08:11:34 +0200 (CEST)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CCD50FB@IRSMSX108.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

>Hi Ravi,
>
>> -----Original Message-----
>> From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com]
>> Sent: Monday, April 2, 2018 6:50 AM
>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;=20
>> dev@dpdk.org
>> Cc: hemant.agrawal@nxp.com
>> Subject: RE: [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD
>>=20
>> >
>> >
>> >> -----Original Message-----
>> >> From: Ravi Kumar [mailto:Ravi1.kumar@amd.com]
>> >> Sent: Monday, March 19, 2018 12:24 PM
>> >> To: dev@dpdk.org
>> >> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;=20
>> >> hemant.agrawal@nxp.com
>> >> Subject: [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD
>> >>
>> >> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
>> >
>> >Patchset applied to dpdk-next-crypto, with same minor changes (title=20
>> >changes
>> and driver registering modification due to an earlier patch).
>> >
>> >Thanks for the work!
>> >Pablo
>> >
>
>There's been a memory rework applied in DPDK at the same time I applied yo=
ur PMD in next-crypto, Which means that it is broken now. Could you submit =
a fix for it?
>At least, compilation is broken now, but it may require more changes:
>
>drivers/crypto/ccp/ccp_dev.c:98:7: error: implicit declaration of function=
 'rte_eal_get_physmem_layout' is invalid in C99
>      [-Werror,-Wimplicit-function-declaration]
>        ms =3D rte_eal_get_physmem_layout();
>
>This function does not exist anymore.
>Commit 2d84772bf858 ("crypto/qat: use contiguous allocation for DMA memory=
") makes a similar required changed in QAT.
>Take a look at it and see if it suits you.
>

Hi Pablo,

Sure, we will send updated patch for this.

Regards,
Ravi

>>=20
>> Thanks a lot Pablo.
>>=20
>> Regards,
>> Ravi
>