From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Kumar, Ravi1" <Ravi1.Kumar@amd.com>
Subject: Re: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
Date: Thu, 11 Jan 2018 06:36:41 +0000
Message-ID: <CY4PR12MB1509C081F296B856D5E7943DAE160@CY4PR12MB1509.namprd12.prod.outlook.com>
References: <1515145198-97367-1-git-send-email-Ravi1.kumar@amd.com>
 <1515577379-18453-1-git-send-email-Ravi1.kumar@amd.com>
 <E115CCD9D858EF4F90C690B0DCB4D8976CC6C65A@IRSMSX108.ger.corp.intel.com>
 <CY4PR12MB1509E3766BC079F6A8070CA2AE110@CY4PR12MB1509.namprd12.prod.outlook.com>
 <E115CCD9D858EF4F90C690B0DCB4D8976CC6CCAD@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Shippen, Greg" <Greg.Shippen@amd.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam03on0079.outbound.protection.outlook.com [104.47.42.79])
 by dpdk.org (Postfix) with ESMTP id CE47F1B16B
 for <dev@dpdk.org>; Thu, 11 Jan 2018 07:36:44 +0100 (CET)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC6CCAD@IRSMSX108.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
>> From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com]
>> Sent: Wednesday, January 10, 2018 10:30 AM
>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;=20
>> dev@dpdk.org
>> Cc: Shippen, Greg <Greg.Shippen@amd.com>
>> Subject: RE: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
>>=20
>> >Hi Ravi,
>> >
>> >> -----Original Message-----
>> >> From: Ravi Kumar [mailto:Ravi1.kumar@amd.com]
>> >> Sent: Wednesday, January 10, 2018 9:43 AM
>> >> To: dev@dpdk.org
>> >> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
>> >> Subject: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
>> >>
>> >> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
>> >> ---
>> >
>> >...
>> >
>> >> --- /dev/null
>> >> +++ b/drivers/crypto/ccp/Makefile
>> >> @@ -0,0 +1,55 @@
>> >> +#
>> >> +#   Copyright(c) 2018 Advanced Micro Devices, Inc.
>> >> +#   All rights reserved.
>> >> +#
>> >
>> >As Hemant commented, you need to change this full license with SPDX
>> tags:
>> >
>> >http://dpdk.org/ml/archives/dev/2018-January/085510.html
>> >
>> >Could you submit a v4 with these changes today?
>> >
>> >Thanks,
>> >Pablo
>>=20
>> Hi Pablo,
>>=20
>> Our legal team is still working on the license. We want to get the=20
>> code reviewed in parallel.
>> I will give you and update later if we can upload the v4 patch with=20
>> SPDX tags today.
>>=20
>
>Ok, I have looked at the overall patchset and it looks ok to me.
>The only thing that I would change is the title of patch 7/19:
>I would change it to "crypto/ccp: support sessionless operations".
>
>Regards,
>Pablo

Hi Pablo,

Thanks for going through our code. Good to know the code is fine.=20

The new changes in licensing policy has introduced some delays as we work t=
hrough the implications and get agreement from the third party.

We are working on it and will upload the v4 with SPDX license tags as soon =
as possible.=20

Regards,
Ravi
>
>> Regards,
>> Ravi