From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhu, Rex" Subject: Re: [PATCH] drm/amd/powerplay: fix a signedness bugs Date: Tue, 23 May 2017 05:36:48 +0000 Message-ID: References: <20170516144253.vvu3i6mbx3rv5uki@mwanda>, Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1477717354==" Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Huang, JinHuiEric" , Dan Carpenter , "Deucher, Alexander" Cc: David Airlie , "kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "Huang, Ray" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "Wang, Ken" , "Koenig, Christian" List-Id: dri-devel@lists.freedesktop.org --===============1477717354== Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CY4PR12MB1687B73D93B5416B22518676FBF90CY4PR12MB1687namp_" --_000_CY4PR12MB1687B73D93B5416B22518676FBF90CY4PR12MB1687namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Patches has been applied. Thanks. Best Regards Rex ________________________________ From: Huang, JinHuiEric Sent: Friday, May 19, 2017 12:28:09 AM To: Dan Carpenter; Deucher, Alexander; Zhu, Rex Cc: Koenig, Christian; David Airlie; Wang, Ken; Huang, Ray; amd-gfx@lists.f= reedesktop.org; dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org; kernel-janitors-u79uwXL29TZNg+MwTxZMZA@public.gmane.org= l.org Subject: Re: [PATCH] drm/amd/powerplay: fix a signedness bugs Reviewed-by: Eric Huang On 2017-05-16 10:42 AM, Dan Carpenter wrote: > Smatch complains about a signedness bug here: > > vega10_hwmgr.c:4202 vega10_force_clock_level() > warn: always true condition '(i >=3D 0) =3D> (0-u32max >=3D 0)' > > Fixes: 7b52db39a4c2 ("drm/amd/powerplay: fix bug sclk/mclk level can't be= set on vega10.") > Signed-off-by: Dan Carpenter > > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers= /gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c > index ad30f5d3a10d..2614af2f553f 100644 > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c > @@ -4186,7 +4186,7 @@ static int vega10_force_clock_level(struct pp_hwmgr= *hwmgr, > enum pp_clock_type type, uint32_t mask) > { > struct vega10_hwmgr *data =3D (struct vega10_hwmgr *)(hwmgr->backe= nd); > - uint32_t i; > + int i; > > if (hwmgr->dpm_level !=3D AMD_DPM_FORCED_LEVEL_MANUAL) > return -EINVAL; --_000_CY4PR12MB1687B73D93B5416B22518676FBF90CY4PR12MB1687namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

Patches has been applied.


Thanks.


Best Regards

Rex

From: Huang, JinHuiEric Sent: Friday, May 19, 2017 12:28:09 AM
To: Dan Carpenter; Deucher, Alexander; Zhu, Rex
Cc: Koenig, Christian; David Airlie; Wang, Ken; Huang, Ray; amd-gfx@= lists.freedesktop.org; dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org; kernel-janitors@vge= r.kernel.org
Subject: Re: [PATCH] drm/amd/powerplay: fix a signedness bugs
 
Reviewed-by: Eric Huang <JinHuiEric.Huang@amd.c= om>


On 2017-05-16 10:42 AM, Dan Carpenter wrote:
> Smatch complains about a signedness bug here:
>
>        vega10_hwmgr.c:4202 vega10_f= orce_clock_level()
>        warn: always true condition = '(i >=3D 0) =3D> (0-u32max >=3D 0)'
>
> Fixes: 7b52db39a4c2 ("drm/amd/powerplay: fix bug sclk/mclk level = can't be set on vega10.")
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/driv= ers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> index ad30f5d3a10d..2614af2f553f 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c > @@ -4186,7 +4186,7 @@ static int vega10_force_clock_level(struct p= p_hwmgr *hwmgr,
>            = ;    enum pp_clock_type type, uint32_t mask)
>   {
>        struct vega10_hwmgr *data = =3D (struct vega10_hwmgr *)(hwmgr->backend);
> -     uint32_t i;
> +     int i;
>  
>        if (hwmgr->dpm_level !=3D= AMD_DPM_FORCED_LEVEL_MANUAL)
>            = ;    return -EINVAL;

 --_000_CY4PR12MB1687B73D93B5416B22518676FBF90CY4PR12MB1687namp_-- --===============1477717354== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBt YWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg== --===============1477717354==--