RE: [PATCH 4/4] drm/amd/powerplay: add profiling mode in dpm level

["Zhu, Rex" <Rex.Zhu-5C7GfCeVMHo@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2304 bytes --]

Thanks for quick response.

>>>The patch doesn't apply directly to drm-next-4.10-wip, here's what I tested -

Sorry, it is because code base has been changed in my local.

Please review the attached patch.

Best Regards
Rex


-----Original Message-----
From: Andy Furniss [mailto:adf.lists@gmail.com] 
Sent: Monday, January 09, 2017 6:29 PM
To: Zhu, Rex; Alex Deucher
Cc: amd-gfx list
Subject: Re: [PATCH 4/4] drm/amd/powerplay: add profiling mode in dpm level

Hi, that change does fix it for me.

The patch doesn't apply directly to drm-next-4.10-wip, here's what I tested -

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
index 0345fbb..ac2e5f4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
@@ -162,7 +162,7 @@ static ssize_t
amdgpu_set_dpm_forced_performance_level(struct device *dev,
         }

         if (current_level == level)
-               return 0;
+               return count;

         if (level == AMD_DPM_FORCED_LEVEL_PROFILING)
                 amdgpu_set_clockgating_state(adev, AMD_IP_BLOCK_TYPE_GFX,



Zhu, Rex wrote:
> Thanks Andy,
>
> The attached patch can fix this bug.
> Please review.
>
> Best Regards
> Rex
>
> -----Original Message-----
> From: Andy Furniss [mailto:adf.lists@gmail.com]
> Sent: Monday, January 09, 2017 4:18 AM
> To: Alex Deucher; Zhu, Rex
> Cc: amd-gfx list
> Subject: Re: [PATCH 4/4] drm/amd/powerplay: add profiling mode in dpm 
> level
>
> Alex Deucher wrote:
>> On Fri, Dec 23, 2016 at 3:45 AM, Rex Zhu <Rex.Zhu@amd.com> wrote:
>>> Change-Id: I4a46440882cd94fe5e77e3f351aaccc218a2ece5
>>
>> Patches 1-3:
>> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>>
>> patch 4:
>> Please add a better patch description and explain what profiling mode 
>> is good for, etc.
>
> This on drm-next-4.10-wip regresses setting profile a bit on R9285.
>
> It works eg. if in auto then doing
>
> echo high > 
> /sys/class/drm/card0/device/power_dpm_force_performance_level
>
> is OK and echo auto  > ... is also OK.
>
> The issue if I am in auto and echo auto > .... then I don't get my prompt back.
>
> echo high from elsewhere will make it return - but it doesn't set high.
>


[-- Attachment #2: 0001-drm-amdgpu-fix-bug-return-invaild-value-to-sysfs.patch --]
[-- Type: application/octet-stream, Size: 901 bytes --]

From d020dae854fb0cf50a663ec8e932b85694f75f98 Mon Sep 17 00:00:00 2001
From: Rex Zhu <Rex.Zhu@amd.com>
Date: Mon, 9 Jan 2017 15:18:01 +0800
Subject: [PATCH 1/6] drm/amdgpu: fix bug return invaild value to sysfs.

Change-Id: Ib9e1f60ad816eaaedd247c224684686d764a72fc
Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
index 8438642..02aa7ce 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
@@ -162,7 +162,7 @@ static ssize_t amdgpu_set_dpm_forced_performance_level(struct device *dev,
 	}
 
 	if (current_level == level)
-		return 0;
+		return count;
 
 	if (level == AMD_DPM_FORCED_LEVEL_PROFILING)
 		amdgpu_set_clockgating_state(adev, AMD_IP_BLOCK_TYPE_GFX,
-- 
1.9.1


[-- Attachment #3: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx