From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sony.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=S1; bh=/o0fA1YHDEpnLrPLzFfmZJszfaVquiGnIhc5FeQrGms=; b=FCJTnO7yIdARiABZSCVe/AebjCDZrEE8At2uywOMqLeu0hqABWUIuDuLD4XhxhJo5reV H7VIPw1bz27AhUpWLsO7Vtu/29NtNFmz8+eUv083O44RBSD1ZTRQyWlVbZuA2yi3ne6I A/4tDKkhhQGcva8x/KgyVpBHNQ2BbL1N4idzWZHY7fZYlLpNTPDouGsByzhZJ8zQr3rL buDBp6XE2w6D6VNjAkVgKvBdmWQj7niRKQgaY7loEAdBGEe9MMAo+qpO3zDDNg9xmrWU 1knfeN1M1n4qvYsZ8SQ8gUKSHqLBopMkVp3fieC6Xtf/1eGvo/1lkfbHgMYHMZPLm45a NA== From: "Bird, Tim" Date: Mon, 27 Jul 2020 17:33:45 +0000 Message-ID: References: In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Fuego] Dockerfile vs install-debian.sh List-Id: Mailing list for the Fuego test framework List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Georg Piewald , "fuego@lists.linuxfoundation.org" > -----Original Message----- > From: Georg Piewald >=20 > Hi guys, >=20 > I was just looking into how to install Fuego without a Docker container > (since the CHANGELOG says it's possible). Apparently, that's what > install-debian.sh is good for (or is there something else, that I missed?= ). I believe that's it. But Daniel would know. >=20 > But honestly, this script seems like a halfhearted attempt to me and > strongly violates the DRY principle. It is clearly descendant from > Dockerfile, but did not evolve with it. Several later modifications in > Dockerfile did not make it to install-debian.sh. How do you plan to keep > these files in sync? To be brutally honest, I don't think we have a plan. So making it so that the information is in one place sounds like a great improvement. >=20 > I propose to only let install-debian.sh have all the code that sets up > the OS and installs all requirements. The Dockerfile instead should do > (almost) nothing but execute install-debian.sh. >=20 > An additional benefit of that method is that it will be much easier to > also keep Dockerfile.nojenkins in sync with the standard Dockerfile. > Because here we have the same problem of lots of copied code, that is > slowly drifting apart. We might even not need Dockerfile.nojenkins > anymore at all. >=20 > I can offer to implement this, unless there are strong objections by anyo= ne. No objections - and strong support. Thanks very much for the offer. Any help is appreciated! :-) -- Tim