Re: [igt-dev] [PATCH i-g-t 1/2] Add descriptions to pm rc6 residency tests

["Gupta, Anshuman" <anshuman.gupta@intel.com>]

> -----Original Message-----
> From: Sunkesula, Karthikeya <karthikeya.sunkesula@intel.com>
> Sent: Thursday, September 15, 2022 1:47 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Gupta, Anshuman <anshuman.gupta@intel.com>; Nilawar, Badal
> <badal.nilawar@intel.com>; Sunkesula, Karthikeya
> <karthikeya.sunkesula@intel.com>
> Subject: [PATCH i-g-t 1/2] Add descriptions to pm rc6 residency tests
> 
> Signed-off-by: Karthikeya Sunkesula <karthikeya.sunkesula@intel.com>
> ---
>  tests/i915/i915_pm_rc6_residency.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tests/i915/i915_pm_rc6_residency.c
> b/tests/i915/i915_pm_rc6_residency.c
> index cf7a92b9..f8cf4325 100644
> --- a/tests/i915/i915_pm_rc6_residency.c
> +++ b/tests/i915/i915_pm_rc6_residency.c
> @@ -57,6 +57,8 @@ struct residencies {
>  	int duration;
>  };
> 
> +IGT_TEST_DESCRIPTION("Tests to verify rc6 in different cases");
Every rc6 test is running for_each_gt(), so batter to specify GT here
instead of  subtest description.
> +
>  static unsigned long get_rc6_enabled_mask(void)  {
>  	unsigned long enabled;
> @@ -541,6 +543,8 @@ igt_main
>  		ctx = intel_ctx_create_all_physical(i915);
>  	}
> 
> +	igt_describe("Measure rc6 residency and energy, when GPU is idle, "
> +			"with light workload and with waitboost.");
Measure -> Validate everywhere.
>  	igt_subtest_with_dynamic("rc6-idle") {
>  		const struct intel_execution_engine2 *e;
> 
> @@ -555,6 +559,8 @@ igt_main
>  		}
>  	}
> 
> +	igt_describe("Measure rc6 residency for a request held-up by external "
> +			"fence and verify power conservation while waiting.");
How about "Validate rc6 residency while execbuf is waiting for sync_file fd in unblocking manner "
>  	igt_subtest("rc6-fence") {
>  		igt_require_gem(i915);
>  		gem_quiescent_gpu(i915);
> @@ -580,6 +586,7 @@ igt_main
>  			igt_require(rc6_enabled & RC6_ENABLED);
>  		}
> 
> +		igt_describe("Measure rc6 residency per gt  when it is idle.");
I think it is " Validate rc6 residency count accuracy with respect to wall time"
Br,
Anshuman Gupta.
>  		igt_subtest("rc6-accuracy") {
>  			struct residencies res;
> 
> @@ -587,6 +594,7 @@ igt_main
>  			residency_accuracy(res.rc6, res.duration, "rc6");
>  		}
> 
> +		igt_describe("Measure media rc6 residency per gt when it is
> idle.");
>  		igt_subtest("media-rc6-accuracy") {
>  			struct residencies res;
> 
> --
> 2.25.1