From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 788F512C7FD; Thu, 21 Mar 2024 16:20:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711038000; cv=none; b=k2jzrKU0H5dIQdu7yXpJju7eq6A1LbcX2EkDw7lJuHc9crGuRf7uoEWNdF9VWyOcFN4UV0Gak/2b45TYKRutrtB5bvphxPtdA0Q0DHJvb7CjlEaZrfcqq1ZV7vGim35bfiWe926A8MebSMz3Qqd9BgR69TyYu9Ek/Hba7gYj6VY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711038000; c=relaxed/simple; bh=cw0xFQH2DJGFteeL3Rk+RfTx2SeLml2rDG34W3UbhJ4=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=RKEi5wmoP/Y/1IWi18UBIiErDJdp9kzzhulCbKGtfmlaSJpZlXPvS7PYF1S4cOaduIrjsLOMbufR5dto0QrJ5rESQImfrZdEFwDNEthG9+nrw/azS7/kemeLF8Vhd6YZ0rsQTiflobGUOBf57OVmm2mcgJqD6GgftbmaTVZrC/A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VeXUxJ7g; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VeXUxJ7g" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A139BC433C7; Thu, 21 Mar 2024 16:19:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711038000; bh=cw0xFQH2DJGFteeL3Rk+RfTx2SeLml2rDG34W3UbhJ4=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=VeXUxJ7gly7e89nCNfjnoffFAXoqvt0NaaJvHvQxHAyZvcHDh3NzOluNfe4me99jx 2iNB1mXfe9KYEEcGApvs8whH/iWfV6LTNWQy/D2563cYMW/T60sfLovQxznKDt+VCl UG072CQ8007J0hsBmjE6tCIdZhoC0bFyuI99E2ltFAsvhz/my0QvLvB1ARSBHEIn8v tdJRATlPCVRSopn3x0fvcn2PmULJ2puIb7YqmS448JgwGN/5hAjcRqVSKDOT5JlnRw SSBpkoH/NWcC53tp4cKjadd39d3WUQIkHNCxvUYgjozFWMaEJdYfDy4RKBaNvR8nrc /N2lkhY5BIuug== Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 21 Mar 2024 18:19:54 +0200 Message-Id: Cc: "Stefan Berger" , "Stefan Berger" , , , , , , , Subject: Re: [PATCH v6 00/13] Add support for NIST P521 to ecdsa From: "Jarkko Sakkinen" To: "Jarkko Sakkinen" , "Konstantin Ryabitsev" , "Lukas Wunner" X-Mailer: aerc 0.17.0 References: <20240312183618.1211745-1-stefanb@linux.vnet.ibm.com> <20240320-quirky-truthful-manul-da6eb9@lemur> In-Reply-To: On Thu Mar 21, 2024 at 6:17 PM EET, Jarkko Sakkinen wrote: > On Wed Mar 20, 2024 at 4:41 PM EET, Konstantin Ryabitsev wrote: > > On Wed, Mar 20, 2024 at 06:40:33AM +0100, Lukas Wunner wrote: > > > If Herbert applies patches with "b4 am --apply-cover-trailers" or > > > "b4 shazam --apply-cover-trailers" (I don't know if he does), > > > it is completely irrelevant whether Stefan strips my Tested-by from > > > individual patches: It will automatically be re-added when the > > > series gets applied. > > > > Applying trailers sent to the cover letter is now the default behaviour= in > > 0.13, so this flag is no longer required (it does nothing). > > > > -K > > The whole policy of how to put tested-by in my experience is subsystem > dependent. > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html > > Official documentation only speaks about patches so perhaps it should > then be refined for the series. > > I'm hearing about this option in b4 for the first time in my life. It is also pretty relevant to know when you read the commit log e.g. when bisecting what was *actually* tested. If you put tested-by to whole series it probably means that you've tested the uapi and are getting the expected results. Thus in this case it would 13/13 that is *actually* tested. Putting tested-by to every possible patch only degrades the quality of the commit log. I don't see how this is "irrelevant". BR, Jarkko