From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp1.ms.mff.cuni.cz (smtp-in1.ms.mff.cuni.cz [195.113.20.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66EA9B66F for ; Thu, 21 Mar 2024 17:07:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.113.20.234 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711040869; cv=none; b=j6hhK9NpVqGH8+Gv4Z18UV/JKRNKlCmuHLp6C2qCOkYRP+sPGJ5mcNk+xhmYBge++d3uS5hL7Z4N3YLn2fO3yQXJhQMpKvKTJQUEy4YAl6HB36ZI9M7xQU63JKACyminhORCUNSF2sVRKmH5EkXlJqLOdgv8L0npheV2SOPdc5s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711040869; c=relaxed/simple; bh=3eTxWlyZ3yvKG7IqSaj3xnqURvyDX21tfOB8h+e0Gbg=; h=Mime-Version:Content-Type:Date:Message-Id:From:Cc:Subject:To: References:In-Reply-To; b=luYXLTpQz2n2Eqrhp/vQfLFDndnjVTGnYxGzAt9mbHIZn/atDPeOTnjS0YA4aKaNtrME5PXNM3G9h24vuuIPPbHPJ5I/D7gXfP47rEmZC8wicdEPekvqixHocMb7kZ6NMX956n52AoIkquxk0hannZO3cMZiNvESq0nmaD1SclE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=matfyz.cz; spf=pass smtp.mailfrom=matfyz.cz; arc=none smtp.client-ip=195.113.20.234 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=matfyz.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=matfyz.cz X-SubmittedBy: id balejk@matfyz.cz subject /postalCode=110+2000/O=Univerzita+20Karlova/street=Ovocn+5CxC3+5CxBD+20trh+20560/5/ST=Praha,+20Hlavn+5CxC3+5CxAD+20m+5CxC4+5Cx9Bsto/C=CZ/CN=Karel+20Balej/emailAddress=balejk@matfyz.cz serial F5FD910E8FE2121B897F7E55B84E351D issued by /C=NL/O=GEANT+20Vereniging/CN=GEANT+20Personal+20CA+204 auth type TLS.CUNI Received: from localhost (koleje-wifi-0015.koleje.cuni.cz [78.128.191.15]) (authenticated) by smtp1.ms.mff.cuni.cz (8.16.1/8.16.1) with ESMTPS id 42LH7hHN095693 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=OK); Thu, 21 Mar 2024 18:07:44 +0100 (CET) (envelope-from balejk@matfyz.cz) Precedence: bulk X-Mailing-List: phone-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 21 Mar 2024 18:08:16 +0100 Message-Id: From: "Karel Balej" Cc: "Lee Jones" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Dmitry Torokhov" , "Liam Girdwood" , , , , =?utf-8?q?Duje_Mihanovi=C4=87?= , <~postmarketos/upstreaming@lists.sr.ht>, Subject: Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC To: "Mark Brown" References: <20240311160110.32185-1-karelb@gimli.ms.mff.cuni.cz> <20240311160110.32185-3-karelb@gimli.ms.mff.cuni.cz> <20240321154211.GA13211@google.com> <20240321162045.GC13211@google.com> <879296b4-5186-4170-af3f-971787d28514@sirena.org.uk> In-Reply-To: <879296b4-5186-4170-af3f-971787d28514@sirena.org.uk> Mark Brown, 2024-03-21T16:58:44+00:00: > On Thu, Mar 21, 2024 at 05:55:17PM +0100, Karel Balej wrote: > > Lee Jones, 2024-03-21T16:20:45+00:00: > > > On Thu, 21 Mar 2024, Karel Balej wrote: > > > > > > > +static const struct regmap_config pm886_i2c_regmap =3D { > > > > > > + .reg_bits =3D 8, > > > > > > + .val_bits =3D 8, > > > > > > + .max_register =3D PM886_REGMAP_CONF_MAX_REG, > > > > > > +}; > > > > > > Why is this in here? > > > > > Because since I moved the regulators regmap initialization into the > > > > regulators driver, I need to access it from there. > > > > So move it into the regulators driver? > > > It is used in the MFD driver too for the base regmap. > > You shouldn't be creating two regmaps for the same set of registers, > that just opens the potential for confusion. Just the regmap config is the same. Otherwise, each regmap lives at a different I2C address. Regards, K. B.