From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Liang, Cunming" Subject: Re: [PATCH] eal: fix rte_intr_dp_is_en() check Date: Wed, 20 Jul 2016 08:56:36 +0000 Message-ID: References: <1468542971-48198-1-git-send-email-yongwang@vmware.com> <2847845.SJj9hZrsaB@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: Yong Wang , "dev@dpdk.org" , "david.marchand@6wind.com" To: Thomas Monjalon Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 16388377A for ; Wed, 20 Jul 2016 10:56:56 +0200 (CEST) In-Reply-To: <2847845.SJj9hZrsaB@xps13> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, July 20, 2016 4:42 PM > To: Liang, Cunming > Cc: Yong Wang ; dev@dpdk.org; > david.marchand@6wind.com > Subject: Re: [dpdk-dev] [PATCH] eal: fix rte_intr_dp_is_en() check >=20 > 2016-07-20 07:03, Liang, Cunming: > > Probably a clean way is not to handle device external interrupt even= t in EAL > > interrupt thread (intr mb may have some problem). The EAL interrupt = thread > is > > only used to postpone the delay execution or other background interr= upt > > (e.g. alarm). Then misc/non-misc can be combined, while requiring A= PP to > > detect the interrupt causes. >=20 > I am not sure it was a good idea to have a thread for the link interrupt. > It may be simpler and cleaner to let the application do the pthread_creat= e. The EAL intr thread is reserved for all interrupt before, is not design for= link interrupt on the first day. Personally I vote to remove link interrupt from interrupt= thread. -Cunming