From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wilde, Martin" Subject: Re: Responsiveness Changes to i915 Driver Date: Tue, 19 Aug 2014 21:33:55 +0000 Message-ID: References: <20140815062628.GB16480@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="_002_D01910563DC4Bmartinwildeintelcom_" Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 2C1F86E654 for ; Tue, 19 Aug 2014 14:33:59 -0700 (PDT) In-Reply-To: <20140815062628.GB16480@nuc-i3427.alporthouse.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org --_002_D01910563DC4Bmartinwildeintelcom_ Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable Greetings - after reviewing Chris=B9s feedback below and some thought, I most likely do not need to add another trace message and the existing =B3i915_flip_complete=B2 trace message can be used. Thus the only change requested is to have the T1_T3 value printed out during driver init/re-init. Here is the requested change: diff -rupN src.org/third_party/kernel/3.10/drivers/gpu/drm/i915/intel_dp.c src/third_party/kernel/3.10/drivers/gpu/drm/i915/intel_dp.c ---=20 src.org/third_party/kernel/3.10/drivers/gpu/drm/i915/intel_dp.c 2014-08-14 14:24:45.655312785 -0700 +++ src/third_party/kernel/3.10/drivers/gpu/drm/i915/intel_dp.c 2014-08-14 11:57:30.203608374 -0700 @@ -3528,6 +3528,7 @@ intel_dp_init_panel_power_sequencer(stru intel_dp->panel_power_cycle_delay =3D get_delay(t11_t12); #undef get_delay =20 + printk(KERN_INFO "i915: eDP T3 Value: %d\n", intel_dp->panel_power_up_delay); DRM_DEBUG_KMS("panel power up delay %d, power down delay %d, power cycle delay %d\n", intel_dp->panel_power_up_delay, intel_dp->panel_power_down_delay, intel_dp->panel_power_cycle_delay); Regards, -martin On 8/14/14, 11:26 PM, "Chris Wilson" wrote: >On Thu, Aug 14, 2014 at 11:52:47PM +0000, Wilde, Martin wrote: >> Greetings, >>=20 >> I am submitting the below changes to i915 Gfx driver to support resume >>time Responsiveness measurements. These changes parallel the work >>already done in the IVB Windows Gfx driver. These changes in addition >>to other OTS scripts (suspend_resume) allow tracking of what is referred >>to as the =B3B2I=B2 or =B3Button To Image=B2 time of the platform. The s= horter >>this time, the more responsiveness the platform is viewed by the end >>user. Panel selection is an important factor in providing a more >>responsive system. Note there is no dependency on other scripts. The >>changes are standalone. >>=20 >>=20 >> * Display the current T1_T3 value. This is used to verify that the >>timing set in the VBT is correct. We have seen many instances where the >>value is not set correctly for the panel and the resume time is longer >>than necessary (e.g. 500ms T3 versus 200ms T3). >> * Print the time when the first page flip occurs. This is when the >>user first sees the desktop displayed from resume. While this >>measurement could be done by other methods, this is the actual time that >>the desktop manager/framebuffer makes the driver request and the Gfx >>driver performs the action. Thus any layering software added can be >>correlated to increases in this time. >>=20 >> To support the latter (first page flip), I added a new ftrace called >>=B3trace_i915_resume=B2. I looked at the existing page flip trace messag= e >>and that one is designed for every page flip. I did not want to >>convolute it with the one time flip trace on resume. I used a trace >>message instead of a printk to reduce any performance impacts of using a >>printk. Additionally printk is not reliable of when the message >>actually appears in the kernel log. > >I am sorry, you are complaining that there is a tracepoint that gives >you exactly what you want already, only that userspace needs to do some >filtering? Which by the way, does not give you what you say you want >anyway - the scanout is already active long before the first flip is >handled, and in many, many cass that flip is just a figment of your >imagination. Maybe what you mean is to B2UR rather than >button-to-static-image. >-Chris > > >--=20 >Chris Wilson, Intel Open Source Technology Centre --_002_D01910563DC4Bmartinwildeintelcom_ Content-Type: application/octet-stream; name="i915.patch" Content-Description: i915.patch Content-Disposition: attachment; filename="i915.patch"; size=768; creation-date="Tue, 19 Aug 2014 21:33:55 GMT"; modification-date="Tue, 19 Aug 2014 21:33:55 GMT" Content-ID: <1BDFA30E8A135E4583F2E3FDB9749354@intel.com> Content-Transfer-Encoding: base64 ZGlmZiAtcnVwTiBzcmMub3JnL3RoaXJkX3BhcnR5L2tlcm5lbC8zLjEwL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RwLmMgc3JjL3RoaXJkX3BhcnR5L2tlcm5lbC8zLjEwL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2RwLmMKLS0tIHNyYy5vcmcvdGhpcmRfcGFydHkva2VybmVsLzMuMTAv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwkyMDE0LTA4LTE0IDE0OjI0OjQ1LjY1NTMx Mjc4NSAtMDcwMAorKysgc3JjL3RoaXJkX3BhcnR5L2tlcm5lbC8zLjEwL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RwLmMJMjAxNC0wOC0xNCAxMTo1NzozMC4yMDM2MDgzNzQgLTA3MDAKQEAg LTM1MjgsNiArMzUyOCw3IEBAIGludGVsX2RwX2luaXRfcGFuZWxfcG93ZXJfc2VxdWVuY2VyKHN0 cnUKIAlpbnRlbF9kcC0+cGFuZWxfcG93ZXJfY3ljbGVfZGVsYXkgPSBnZXRfZGVsYXkodDExX3Qx Mik7CiAjdW5kZWYgZ2V0X2RlbGF5CiAKKwlwcmludGsoS0VSTl9JTkZPICJpOTE1OiBlRFAgVDMg VmFsdWU6ICVkXG4iLCBpbnRlbF9kcC0+cGFuZWxfcG93ZXJfdXBfZGVsYXkpOwogCURSTV9ERUJV R19LTVMoInBhbmVsIHBvd2VyIHVwIGRlbGF5ICVkLCBwb3dlciBkb3duIGRlbGF5ICVkLCBwb3dl ciBjeWNsZSBkZWxheSAlZFxuIiwKIAkJICAgICAgaW50ZWxfZHAtPnBhbmVsX3Bvd2VyX3VwX2Rl bGF5LCBpbnRlbF9kcC0+cGFuZWxfcG93ZXJfZG93bl9kZWxheSwKIAkJICAgICAgaW50ZWxfZHAt PnBhbmVsX3Bvd2VyX2N5Y2xlX2RlbGF5KTsK --_002_D01910563DC4Bmartinwildeintelcom_ Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --_002_D01910563DC4Bmartinwildeintelcom_--