From: "Sanford, Robert" <rsanford@akamai.com>
To: Karmarkar Suyash <skarmarkar@sonusnet.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>,
"reshma.pattan@intel.com" <reshma.pattan@intel.com>
Subject: Re: [PATCH v2]:rte_timer:timer lag issue correction
Date: Tue, 4 Oct 2016 21:39:46 +0000 [thread overview]
Message-ID: <D09D8D35-BE32-48DD-B070-030C590744F4@akamai.com> (raw)
In-Reply-To: <BN3PR03MB14312FD1C71886E4A3AC4A25B3CE0@BN3PR03MB1431.namprd03.prod.outlook.com>
Yes, this change makes sense. I ran timer tests and they passed.
Acked-by: Robert Sanford <rsanford@akamai.com>
Thanks,
Robert
On 9/29/16, 10:27 AM, "Karmarkar Suyash" <skarmarkar@sonusnet.com> wrote:
Hello,
Can you please review the changes and suggest next steps? Thanks
Regards
Suyash Karmarkar
-----Original Message-----
From: Karmarkar Suyash
Sent: Wednesday, September 21, 2016 4:54 PM
To: dev@dpdk.org; thomas.monjalon@6wind.com; rsanford@akamai.com; reshma.pattan@intel.com
Cc: Karmarkar Suyash <skarmarkar@sonusnet.com>
Subject: [PATCH v2]:rte_timer:timer lag issue correction
For Periodic timers ,if the lag gets introduced, the current code
added additional delay when the next peridoc timer was initialized
by not taking into account the delay added, with this fix the code
would start the next occurrence of timer keeping in account the
lag added.Corrected the behavior.
Fixes: 9b15ba89 ("timer: use a skip list")
Karmarkar Suyash (1):
Signed-off-by: Karmarkar Suyash <skarmarkar@sonusnet.com>
lib/librte_timer/rte_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
lib/librte_timer/rte_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c
index 43da836..18782fa 100644
--- a/lib/librte_timer/rte_timer.c
+++ b/lib/librte_timer/rte_timer.c
@@ -613,7 +613,7 @@ void rte_timer_manage(void)
status.owner = (int16_t)lcore_id;
rte_wmb();
tim->status.u32 = status.u32;
- __rte_timer_reset(tim, cur_time + tim->period,
+ __rte_timer_reset(tim, tim->expire + tim->period,
tim->period, lcore_id, tim->f, tim->arg, 1);
rte_spinlock_unlock(&priv_timer[lcore_id].list_lock);
}
--
2.9.3.windows.1
next prev parent reply other threads:[~2016-10-04 21:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 16:02 [PATCH v2]:rte_timer:timer lag issue correction Karmarkar Suyash
2016-09-21 17:08 ` Karmarkar Suyash
2016-09-21 20:03 ` Thomas Monjalon
2016-09-21 20:54 ` Karmarkar Suyash
2016-09-29 14:27 ` Karmarkar Suyash
2016-10-04 19:31 ` Karmarkar Suyash
2016-10-04 20:51 ` Sanford, Robert
2016-10-04 21:39 ` Sanford, Robert [this message]
2016-10-04 22:36 ` Karmarkar Suyash
2016-10-05 9:34 ` Pattan, Reshma
2016-10-05 10:06 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2016-09-16 15:58 Karmarkar Suyash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D09D8D35-BE32-48DD-B070-030C590744F4@akamai.com \
--to=rsanford@akamai.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
--cc=skarmarkar@sonusnet.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.