From: "Michael Walle" <michael@walle.cc>
To: "Tom Rini" <trini@konsulko.com>, "Marek Vasut" <marex@denx.de>
Cc: u-boot@lists.denx.de, "Joe Hershberger" <joe.hershberger@ni.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Ramon Fried" <rfried.dev@gmail.com>,
"Rasmus Villemoes" <rasmus.villemoes@prevas.dk>
Subject: Re: [PATCH] net: phy: broadcom: Configure LEDs on BCM54210E
Date: Tue, 02 Apr 2024 10:11:48 +0200 [thread overview]
Message-ID: <D09HHD0G6HHN.1KMUSO6YCM010@walle.cc> (raw)
In-Reply-To: <20240328150905.GW3442575@bill-the-cat>
[-- Attachment #1: Type: text/plain, Size: 666 bytes --]
On Thu Mar 28, 2024 at 4:09 PM CET, Tom Rini wrote:
> On Mon, Jan 01, 2024 at 10:07:47PM +0100, Marek Vasut wrote:
>
> > Configure LEDs on BCM54210E so they would blink on activity
> > and indicate link speed. Without this the LEDs are always on
> > if cable is plugged in.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
>
> Applied to u-boot/next, thanks!
Pretty late and I'm not implying this should be reverted. I just
want to point out, that this is really board dependent and might
even break boards which have this PHY and are using its default
configuration for the attached LEDs.
FWIW, linux now have LED PHY DT bindings.
-michael
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]
prev parent reply other threads:[~2024-04-02 8:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-01 21:07 [PATCH] net: phy: broadcom: Configure LEDs on BCM54210E Marek Vasut
2024-03-28 15:09 ` Tom Rini
2024-04-02 8:11 ` Michael Walle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D09HHD0G6HHN.1KMUSO6YCM010@walle.cc \
--to=michael@walle.cc \
--cc=joe.hershberger@ni.com \
--cc=marex@denx.de \
--cc=rafal@milecki.pl \
--cc=rasmus.villemoes@prevas.dk \
--cc=rfried.dev@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.