From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754262AbbKGT1U (ORCPT ); Sat, 7 Nov 2015 14:27:20 -0500 Received: from mga11.intel.com ([192.55.52.93]:65503 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754026AbbKGT1T convert rfc822-to-8bit (ORCPT ); Sat, 7 Nov 2015 14:27:19 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,258,1444719600"; d="scan'208";a="814268152" From: "Dilger, Andreas" To: Dan Carpenter CC: "Simmons, James A." , Shivani Bhardwaj , "gregkh@linuxfoundation.org" , "Drokin, Oleg" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/3] Staging: lustre: module: Replace function calls Thread-Topic: [PATCH 1/3] Staging: lustre: module: Replace function calls Thread-Index: AQHRGLdFVvcNxZFX2USzxJxnkPGLTZ6QEvOAgADc7ACAAANSbA== Date: Sat, 7 Nov 2015 19:27:16 +0000 Message-ID: References: <1cdd091b39e2202a0810efe538ddd520da967ed4.1446830119.git.shivanib134@gmail.com> <29aacb945be3417d96c1ebc49d9eeb6c@EXCHCS32.ornl.gov>,<20151107111523.GG18797@mwanda> In-Reply-To: <20151107111523.GG18797@mwanda> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Nov 7, 2015, at 04:15, Dan Carpenter wrote: > > On Fri, Nov 06, 2015 at 10:04:41PM +0000, Simmons, James A. wrote: >>> From: devel [mailto:driverdev-devel-bounces@linuxdriverproject.org] On Behalf Of Shivani Bhardwaj >>> Sent: Friday, November 06, 2015 12:18 PM >>> To: gregkh@linuxfoundation.org >>> Cc: oleg.drokin@intel.com; devel@driverdev.osuosl.org; andreas.dilger@intel.com; linux-kernel@vger.kernel.org >>> Subject: [PATCH 1/3] Staging: lustre: module: Replace function calls >>> >>> Replace the calls of function cfs_trace_free_string_buffer() with >>> kfree() as the former function is not required. >>> >>> Signed-off-by: Shivani Bhardwaj >>> --- >>> drivers/staging/lustre/lustre/libcfs/module.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> Acked-by: James Simmons >> >> diff --git a/drivers/staging/lustre/lustre/libcfs/module.c b/drivers/staging/lustre/lustre/libcfs/module.c >> index 50e8fd2..516a9e7 100644 >> --- a/drivers/staging/lustre/lustre/libcfs/module.c >> +++ b/drivers/staging/lustre/lustre/libcfs/module.c >> @@ -392,7 +392,7 @@ static int __proc_dobitmasks(void *data, int write, >> } else { > > Why do your acks include the original diff without the "> " prefix? How > are you even managing that trick? I was wondering the same, though it does look nicer. Cheers, Andreas