From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Narsimhulu Musini (nmusini)" Subject: Re: [PATCH v2 6/9] snic:Add low level queuing interfaces Date: Wed, 8 Apr 2015 09:05:20 +0000 Message-ID: References: <1426093299-4511-1-git-send-email-nmusini@cisco.com> <1426093299-4511-7-git-send-email-nmusini@cisco.com> <55129874.1010604@suse.de> <55237B73.7080702@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from alln-iport-1.cisco.com ([173.37.142.88]:49992 "EHLO alln-iport-1.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751159AbbDHJFW convert rfc822-to-8bit (ORCPT ); Wed, 8 Apr 2015 05:05:22 -0400 In-Reply-To: <55237B73.7080702@suse.de> Content-Language: en-US Content-ID: <31931369265FAD4781FF58C43309DAA0@emea.cisco.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Hannes Reinecke , "JBottomley@Parallels.com" , "linux-scsi@vger.kernel.org" Cc: "Sesidhar Baddela (sebaddel)" Hi Hannes, Thank you for reviewing patches. Please find responses inline. On 07/04/15 12:08 pm, "Hannes Reinecke" wrote: >On 04/02/2015 10:13 AM, Narsimhulu Musini (nmusini) wrote: >> Hi Hannes, >>=20 >> Thank you for reviewing the patch. Please find responses inline. >> I will incorporate the comments and suggestions in next patch submit= tal. >>=20 >>=20 >> On 25/03/15 4:43 pm, "Hannes Reinecke" wrote: >>=20 >>> Hi Narsimhulu, >>> >>> On 03/11/2015 06:01 PM, Narsimhulu Musini wrote: >>>> These files contain low level queueing interfaces includes >>>> hardware queues, and management of hardware features. >>>> >>>> v2 >>>> driver supports x86-64 arch, so removed cpu_to_XX API to maintain >>>> consistency. >>>> >>>> Signed-off-by: Narsimhulu Musini >>>> Signed-off-by: Sesidhar Baddela >>>> --- >>> Please find some comments below. >>> >[ .. ] >>> That really looks like a 64bit structure read in as 32bit values ..= =2E >>> If so please use 64bit values here ... >> The structure members are aligned to hardware data, I would prefer t= o >>keep >> it same. >>=20 >I _know_ that they are aligned. >The point of my question was whether these values are _real_ 32-bit >values or rather 64-bit values with the top 32-bit masked off. They are real 32 bit values. These are registers, falling on 64 bit boundaries. > >Cheers, > >Hannes >--=20 >Dr. Hannes Reinecke zSeries & Storage >hare@suse.de +49 911 74053 688 >SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=FCrnberg >GF: F. Imend=F6rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton >HRB 21284 (AG N=FCrnberg) Thanks Narsimhulu > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html