From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 6622DE0051B; Tue, 19 May 2015 09:37:11 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [134.134.136.65 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id CCE7BE0027F for ; Tue, 19 May 2015 09:37:10 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 19 May 2015 09:36:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,459,1427785200"; d="scan'208";a="573744455" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga003.jf.intel.com with ESMTP; 19 May 2015 09:36:34 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.124]) by IRSMSX151.ger.corp.intel.com ([169.254.4.102]) with mapi id 14.03.0224.002; Tue, 19 May 2015 17:36:32 +0100 From: "Barros Pena, Belen" To: "Damian, Alexandru" , "toaster@yoctoproject.org" , "Wood, Michael G" Thread-Topic: [Toaster] [review-request] adamian/20150515_fix_table_header Thread-Index: AQHQkkjoqmH77R70cECmJF6bmwGtI52Df1qA Date: Tue, 19 May 2015 16:36:32 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.5.0.150423 x-originating-ip: [10.237.224.81] MIME-Version: 1.0 Subject: Re: [review-request] adamian/20150515_fix_table_header X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2015 16:37:11 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable On 19/05/2015 16:27, "Damian, Alexandru" wrote: >Hi, > > >Can you please review this branch ? It brings in an important piece of >refactoring to move Toaster towards the REST-style API that will enable a >cleaner design and support for interconnection > with other systems. > > >Getting into details, the "New build" button in all the pages, bar the >project page, now fetches data using the projects API, which is just the >"all projects" page in machine-readable format. Hi Alex: I've looked at the UI, and I've found some issues with the interaction of the new build button. Here comes a list: * When no project is selected, the recipe input field is disabled, but the build button is enabled, which looks a bit strange. We would need to disable the build button as well while no project is selected * When no project is selected, the 'Cancel' link needs to be disabled. Otherwise you end up in a weird state you cannot get out of. * The project name autocomplete now works, but when I select a project, the 'change' icon is missing, which means I am stuck: I cannot select a different project. The change icon needs to show next to the project name, except when the number of projects in the Toaster instance is one. * The recipes autocomplete is not working for me, but maybe it's not related to this branch. * If I select a project, then refresh the page, the page has forgotten about the project I just selected. It would be nice to remember the last project I chose.=20 Thanks! Bel=E9n > This cleans up a bit the overloading of the xhr_datatypeahead; after the >API refactoring, all xhr_ calls should be completely replaced with proper >calls to the REST endpoints. > > >The code is here: >https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=3Dadamian/2= 01 >50515_fix_table_header > > > >Incidentally, this patch fixes the "new build" breakage by the first >round of URL refactoring, and the "construction" of URLs on the client >side. > > >Can you please review and comment ? > >Cheers, >Alex > > >--=20 >Alex Damian >Yocto Project > >SSG / OTC=20 > > >