From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kumar Gala Subject: Re: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active Date: Thu, 30 Jul 2009 09:02:46 -0500 Message-ID: References: <4A70A78D.7070601@gmail.com> <16444A0F3094A24C83EAB7836A12C63B032E5A@zin33exm20.fsl.freescale.net> <16444A0F3094A24C83EAB7836A12C63B032E5C@zin33exm20.fsl.freescale.net> Mime-Version: 1.0 (Apple Message framework v935.3) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from gate.crashing.org ([63.228.1.57]:43490 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750921AbZG3OE5 (ORCPT ); Thu, 30 Jul 2009 10:04:57 -0400 In-Reply-To: <16444A0F3094A24C83EAB7836A12C63B032E5C@zin33exm20.fsl.freescale.net> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Kalra Ashish-B00888 Cc: Robert Hancock , linux-ide@vger.kernel.org, linuxppc-dev@ozlabs.org On Jul 30, 2009, at 8:58 AM, Kalra Ashish-B00888 wrote: > Hello Kumar, > > >> > This doesn't look like it should change anything. sata_fsl_ops > >> inherits > >> > from sata_pmp_port_ops, which inherits from sata_port_ops, which > >> already > >> > sets qc_defer to ata_std_qc_defer. > >> Oh, yes. Actually this patch was for older kernels where there > >> inheritence was not there. As you mentioned, this patch is not > >> required now. > >> > >How old? Should we be asking for this to be applied to some of the > >stable kernel series? > > I believe that the inheritence stuff was added in 2.6.26, thus, this > patch is > required for quite old kernels ( < 2.6.26 ). Ok, than I'm not going to worry about it. - k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id D529BB7BA5 for ; Fri, 31 Jul 2009 00:04:57 +1000 (EST) Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 3259FDDD1C for ; Fri, 31 Jul 2009 00:04:56 +1000 (EST) Message-Id: From: Kumar Gala To: "Kalra Ashish-B00888" In-Reply-To: <16444A0F3094A24C83EAB7836A12C63B032E5C@zin33exm20.fsl.freescale.net> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Mime-Version: 1.0 (Apple Message framework v935.3) Subject: Re: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active Date: Thu, 30 Jul 2009 09:02:46 -0500 References: <4A70A78D.7070601@gmail.com> <16444A0F3094A24C83EAB7836A12C63B032E5A@zin33exm20.fsl.freescale.net> <16444A0F3094A24C83EAB7836A12C63B032E5C@zin33exm20.fsl.freescale.net> Cc: linuxppc-dev@ozlabs.org, linux-ide@vger.kernel.org, Robert Hancock List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Jul 30, 2009, at 8:58 AM, Kalra Ashish-B00888 wrote: > Hello Kumar, > > >> > This doesn't look like it should change anything. sata_fsl_ops > >> inherits > >> > from sata_pmp_port_ops, which inherits from sata_port_ops, which > >> already > >> > sets qc_defer to ata_std_qc_defer. > >> Oh, yes. Actually this patch was for older kernels where there > >> inheritence was not there. As you mentioned, this patch is not > >> required now. > >> > >How old? Should we be asking for this to be applied to some of the > >stable kernel series? > > I believe that the inheritence stuff was added in 2.6.26, thus, this > patch is > required for quite old kernels ( < 2.6.26 ). Ok, than I'm not going to worry about it. - k