All of lore.kernel.org
 help / color / mirror / Atom feed
* [lustre-devel] [PATCH] Remove unused MDS_CLOSE_CLEANUP define
@ 2015-07-06 17:59 Ben Evans
  2015-07-06 18:12 ` Dilger, Andreas
  0 siblings, 1 reply; 3+ messages in thread
From: Ben Evans @ 2015-07-06 17:59 UTC (permalink / raw)
  To: lustre-devel

Previously, MDS_CLOSE_CLEANUP was used to detect file closing, due to eviction.
This flag is no longer used.

Signed-off-by: Aurelien Degremont <aurelien.degremont@cea.fr>
Intel-bug-ID: http://jira.hpdd.intel.com/browse/LU-3677
Reviewed-on: http://review.whamcloud.com/7195
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Fan Yong <fan.yong@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Ben Evans <bevans@cray.com>
---
 .../lustre/lustre/include/lustre/lustre_idl.h      |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
index 4d72d6e..14547d1 100644
--- a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
+++ b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
@@ -2390,7 +2390,7 @@ enum mds_op_bias {
 	MDS_PERM_BYPASS		= 1 << 3,
 	MDS_SOM			= 1 << 4,
 	MDS_QUOTA_IGNORE	= 1 << 5,
-	MDS_CLOSE_CLEANUP	= 1 << 6,
+	/* MDS_UNUSED	= 1 << 6, */
 	MDS_KEEP_ORPHAN		= 1 << 7,
 	MDS_RECOV_OPEN		= 1 << 8,
 	MDS_DATA_MODIFIED	= 1 << 9,
-- 
1.6.5.6

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [lustre-devel] [PATCH] Remove unused MDS_CLOSE_CLEANUP define
  2015-07-06 17:59 [lustre-devel] [PATCH] Remove unused MDS_CLOSE_CLEANUP define Ben Evans
@ 2015-07-06 18:12 ` Dilger, Andreas
  2015-07-06 18:17   ` Ben Evans
  0 siblings, 1 reply; 3+ messages in thread
From: Dilger, Andreas @ 2015-07-06 18:12 UTC (permalink / raw)
  To: lustre-devel

For submitting upstream, the component should be listed like:

staging/lustre: remove unused MDS_CLOSE_CLEANUP define

On 2015/07/06, 11:59 AM, "Ben Evans" <bevans@cray.com> wrote:

>Previously, MDS_CLOSE_CLEANUP was used to detect file closing, due to
>eviction.  This flag is no longer used.
>
>Signed-off-by: Aurelien Degremont <aurelien.degremont@cea.fr>
>Intel-bug-ID: http://jira.hpdd.intel.com/browse/LU-3677
>Reviewed-on: http://review.whamcloud.com/7195
>Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
>Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>
>Reviewed-by: John L. Hammond <john.hammond@intel.com>
>Reviewed-by: Fan Yong <fan.yong@intel.com>
>Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
>Signed-off-by: Ben Evans <bevans@cray.com>
>---
> .../lustre/lustre/include/lustre/lustre_idl.h      |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
>b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
>index 4d72d6e..14547d1 100644
>--- a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
>+++ b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
>@@ -2390,7 +2390,7 @@ enum mds_op_bias {
> 	MDS_PERM_BYPASS		= 1 << 3,
> 	MDS_SOM			= 1 << 4,
> 	MDS_QUOTA_IGNORE	= 1 << 5,
>-	MDS_CLOSE_CLEANUP	= 1 << 6,
>+	/* MDS_UNUSED	= 1 << 6, */
> 	MDS_KEEP_ORPHAN		= 1 << 7,
> 	MDS_RECOV_OPEN		= 1 << 8,
> 	MDS_DATA_MODIFIED	= 1 << 9,
>-- 
>1.6.5.6
>
>_______________________________________________
>lustre-devel mailing list
>lustre-devel at lists.lustre.org
>http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org
>


Cheers, Andreas
-- 
Andreas Dilger

Lustre Software Architect
Intel High Performance Data Division

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [lustre-devel] [PATCH] Remove unused MDS_CLOSE_CLEANUP define
  2015-07-06 18:12 ` Dilger, Andreas
@ 2015-07-06 18:17   ` Ben Evans
  0 siblings, 0 replies; 3+ messages in thread
From: Ben Evans @ 2015-07-06 18:17 UTC (permalink / raw)
  To: lustre-devel

Got it, thanks for the feedback!

-Ben 

-----Original Message-----
From: Dilger, Andreas [mailto:andreas.dilger at intel.com] 
Sent: Monday, July 06, 2015 2:13 PM
To: Ben Evans
Cc: lustre-devel at lists.lustre.org
Subject: Re: [lustre-devel] [PATCH] Remove unused MDS_CLOSE_CLEANUP define

For submitting upstream, the component should be listed like:

staging/lustre: remove unused MDS_CLOSE_CLEANUP define

On 2015/07/06, 11:59 AM, "Ben Evans" <bevans@cray.com> wrote:

>Previously, MDS_CLOSE_CLEANUP was used to detect file closing, due to 
>eviction.  This flag is no longer used.
>
>Signed-off-by: Aurelien Degremont <aurelien.degremont@cea.fr>
>Intel-bug-ID: http://jira.hpdd.intel.com/browse/LU-3677
>Reviewed-on: http://review.whamcloud.com/7195
>Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
>Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>
>Reviewed-by: John L. Hammond <john.hammond@intel.com>
>Reviewed-by: Fan Yong <fan.yong@intel.com>
>Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
>Signed-off-by: Ben Evans <bevans@cray.com>
>---
> .../lustre/lustre/include/lustre/lustre_idl.h      |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
>b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
>index 4d72d6e..14547d1 100644
>--- a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
>+++ b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
>@@ -2390,7 +2390,7 @@ enum mds_op_bias {
> 	MDS_PERM_BYPASS		= 1 << 3,
> 	MDS_SOM			= 1 << 4,
> 	MDS_QUOTA_IGNORE	= 1 << 5,
>-	MDS_CLOSE_CLEANUP	= 1 << 6,
>+	/* MDS_UNUSED	= 1 << 6, */
> 	MDS_KEEP_ORPHAN		= 1 << 7,
> 	MDS_RECOV_OPEN		= 1 << 8,
> 	MDS_DATA_MODIFIED	= 1 << 9,
>--
>1.6.5.6
>
>_______________________________________________
>lustre-devel mailing list
>lustre-devel at lists.lustre.org
>http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org
>


Cheers, Andreas
--
Andreas Dilger

Lustre Software Architect
Intel High Performance Data Division

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-07-06 18:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-06 17:59 [lustre-devel] [PATCH] Remove unused MDS_CLOSE_CLEANUP define Ben Evans
2015-07-06 18:12 ` Dilger, Andreas
2015-07-06 18:17   ` Ben Evans

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.