From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB089C4167B for ; Wed, 9 Dec 2020 08:48:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A443323B1A for ; Wed, 9 Dec 2020 08:48:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728210AbgLIIsY (ORCPT ); Wed, 9 Dec 2020 03:48:24 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([81.169.146.164]:8295 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727806AbgLIIsN (ORCPT ); Wed, 9 Dec 2020 03:48:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1607503520; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:From: Subject:Sender; bh=Php6UbWO3LXsLeMNj2vpYHNEMmvf8nM4PJMlcMYMu+s=; b=miXG//Oim8SR5Ah990LHF9HwdbV/cLsP45c/ZYssAncLnrcOU2ab9vLPyKmIupJFqG s3a2tUpW8ZBjjYN+1H7ucuAIAZTBUSBKDfoC7FEDghRgVwBYNM4AfRGXgAVsa5pyr1Vx d8UxKBXJQMbWxaYCaI5gdvwlmE3fmDheUJAoP2evH3g72GqDv7WIJ63p+5aiZUsmEqOL b7K1qZysxXGyLOY8scDbiF35xNeks4h83aK8HRzJo/+JmI19Wmu6AiE5GitKGDRkJCKf Qt72k2wqB+9jOg8fTkLg3vE8mr5v642DgwzcweeeWsufF1GRBP2yX1ua/205v2E0Mjm6 Ng5A== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj5Qpw97WFDlafXAoNHQ==" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 47.6.2 DYNA|AUTH) with ESMTPSA id 908871wB98j54lV (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Wed, 9 Dec 2020 09:45:05 +0100 (CET) Subject: Re: [BUG] SPI broken for SPI based panel drivers Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=us-ascii From: "H. Nikolaus Schaller" In-Reply-To: Date: Wed, 9 Dec 2020 09:45:04 +0100 Cc: Sven Van Asbroeck , Lukas Wunner , Mark Brown , kernel list , Laurent Pinchart , Discussions about the Letux Kernel , Andreas Kemnade Content-Transfer-Encoding: quoted-printable Message-Id: References: <2D7916FA-678F-4236-B478-C953CADF2FFA@goldelico.com> <4AC29229-9542-4E77-B993-217E29C7E209@goldelico.com> <20201201121620.GB5239@sirena.org.uk> <6283C16F-549C-4463-BC08-E2C1A1D78B2F@goldelico.com> <9380CE00-9CE6-4E0B-B2E1-1B534F85E47D@goldelico.com> <7702A943-FCC5-416B-B53A-3B0427458915@goldelico.com> To: Linus Walleij X-Mailer: Apple Mail (2.3124) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, > Am 09.12.2020 um 09:38 schrieb Linus Walleij = : >=20 > On Sat, Dec 5, 2020 at 8:07 AM H. Nikolaus Schaller = wrote: >=20 >> I find it interesting that so far nobody wants to take responsibility >> for a decision > (...) >=20 >=20 >>> What I can do is to provide just a skeleton for the table that you = or Linus >>> can fix/fill in and make a patch out of it. Is attached and the ??? = is >>> something you should discuss and define. >>=20 >> Please take the attached diff, comment it here and define the = question marks >> according to your intention and then make a patch for the YAML = bindings out >> of it. (I can't do because I don't know your intentions and what to = write into >> the commit message). >=20 > I'll comment what I know, then you can send a proper patch to > Mark. But you really need more people than me to look at this. >=20 >> + device node | cs-gpio | CS pin state active | Note >> + =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D >> + spi-cs-high | - | H | >> + - | - | L | >> + spi-cs-high | ACTIVE_HIGH | H | >> + - | ACTIVE_HIGH | L (or H ???) | 1 >=20 > When using GPIO descriptors it will be enforced to ACTIVE_LOW (L) with = an > explicit warning in dmesg, see drivers/gpio/gpiolib-of.c Ok, so in this line the L is ok. >=20 > When using legacy GPIOs, will be enforced ACTIVE_LOW by the SPI > core. >=20 >> + spi-cs-high | ACTIVE_LOW | H (or L ???) | 2 >=20 > When using GPIO descriptors it will be enforced to ACTIVE_HIGH (H) = with an > explicit warning in dmesg, see drivers/gpio/gpiolib-of.c Ok, so my assumption about H is right and not the part in parenthesis = with ???. >=20 >> + 3) Effectively this rule defines that the ACTIVE level of the >> + gpio has to be ignored >=20 > Nr 3 isn't tagged in the table. Well, it was thought as a third but general note. Maybe should have been = a *) or omitted since the table stands for itself. >=20 > Yours, > Linus Walleij So let me prepare a patch with fixes for this. BR and thanks, Nikolaus