Re: ext4: media error but where?

[Andreas Dilger <adilger@dilger.ca>]

[-- Attachment #1: Type: text/plain, Size: 2148 bytes --]


On Jul 4, 2014, at 2:33 PM, Pavel Machek <pavel@ucw.cz> wrote:

> On Fri 2014-07-04 13:17:37, Andreas Dilger wrote:
>> Maybe it is worthwhile to improve this error message to be:
>> 
>>    EXT4-fs (sda3): initial error at time 1401714179: ...
> 
> I'm glad you suggested it. I actually done a patch before reading
> this. What about:

Looks good to me.  There have been a few users confused by these messages
already, so it is nice to make them a bit more clear.

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> 
> Make it clear that values printed are times, and that it is error
> since last fsck. Also add note about fsck version required.
> 
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index b9b9aab..3423947 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -2809,10 +2809,11 @@ static void print_daily_error_info(unsigned long arg)
> 	es = sbi->s_es;
> 
> 	if (es->s_error_count)
> -		ext4_msg(sb, KERN_NOTICE, "error count: %u",
> +		/* fsck newer than v1.41.13 is needed to clean this condition. */
> +		ext4_msg(sb, KERN_NOTICE, "error count since last fsck: %u",
> 			 le32_to_cpu(es->s_error_count));
> 	if (es->s_first_error_time) {
> -		printk(KERN_NOTICE "EXT4-fs (%s): initial error at %u: %.*s:%d",
> +		printk(KERN_NOTICE "EXT4-fs (%s): initial error at time %u: %.*s:%d",
> 		       sb->s_id, le32_to_cpu(es->s_first_error_time),
> 		       (int) sizeof(es->s_first_error_func),
> 		       es->s_first_error_func,
> @@ -2826,7 +2827,7 @@ static void print_daily_error_info(unsigned long arg)
> 		printk("\n");
> 	}
> 	if (es->s_last_error_time) {
> -		printk(KERN_NOTICE "EXT4-fs (%s): last error at %u: %.*s:%d",
> +		printk(KERN_NOTICE "EXT4-fs (%s): last error at time %u: %.*s:%d",
> 		       sb->s_id, le32_to_cpu(es->s_last_error_time),
> 		       (int) sizeof(es->s_last_error_func),
> 		       es->s_last_error_func,
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


Cheers, Andreas






[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 833 bytes --]