From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Sujith Sankar (ssujith)" <ssujith@cisco.com>
Subject: Re: [PATCH] enic: fix vlan filtering
Date: Sat, 31 Oct 2015 17:04:51 +0000
Message-ID: <D25AF1B5.156E8%ssujith@cisco.com>
References: <1446221603-10679-1-git-send-email-david.marchand@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: Julien Meunier <julien.meunier@6wind.com>,
 "John Daley \(johndale\)" <johndale@cisco.com>
To: David Marchand <david.marchand@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from alln-iport-3.cisco.com (alln-iport-3.cisco.com [173.37.142.90])
 by dpdk.org (Postfix) with ESMTP id E71FA567C
 for <dev@dpdk.org>; Sat, 31 Oct 2015 18:04:53 +0100 (CET)
In-Reply-To: <1446221603-10679-1-git-send-email-david.marchand@6wind.com>
Content-Language: en-US
Content-ID: <7E52A38542B37248A2A83EE2DCFF4825@emea.cisco.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 30/10/15 9:43 pm, "David Marchand" <david.marchand@6wind.com> wrote:

>From: Julien Meunier <julien.meunier@6wind.com>
>
>Report an error when something went wrong.
>
>Signed-off-by: Julien Meunier <julien.meunier@6wind.com>
>Signed-off-by: David Marchand <david.marchand@6wind.com>
>---
> drivers/net/enic/enic_ethdev.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/net/enic/enic_ethdev.c
>b/drivers/net/enic/enic_ethdev.c
>index e385560..5df9a6c 100644
>--- a/drivers/net/enic/enic_ethdev.c
>+++ b/drivers/net/enic/enic_ethdev.c
>@@ -271,13 +271,14 @@ static int enicpmd_vlan_filter_set(struct
>rte_eth_dev *eth_dev,
> 	uint16_t vlan_id, int on)
> {
> 	struct enic *enic =3D pmd_priv(eth_dev);
>+	int err;
>=20
> 	ENICPMD_FUNC_TRACE();
> 	if (on)
>-		enic_add_vlan(enic, vlan_id);
>+		err =3D enic_add_vlan(enic, vlan_id);
> 	else
>-		enic_del_vlan(enic, vlan_id);
>-	return 0;
>+		err =3D enic_del_vlan(enic, vlan_id);
>+	return err;

Acked.

Thanks,
-Sujith

> }
>=20
> static void enicpmd_vlan_offload_set(struct rte_eth_dev *eth_dev, int
>mask)
>--=20
>1.9.1
>