All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@amacapital.net>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Rian Hunter <rian@alum.mit.edu>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Andy Lutomirski <luto@kernel.org>,
	Borislav Petkov <bpetkov@suse.de>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Joerg Roedel <jroedel@suse.de>, Dmitry Safonov <dima@arista.com>,
	Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH] x86/process: Export start_thread()
Date: Mon, 20 Aug 2018 07:27:11 -0700	[thread overview]
Message-ID: <D2852E34-BC10-4161-A05D-981E3A3D4098@amacapital.net> (raw)
In-Reply-To: <alpine.DEB.2.21.1808200927550.2151@nanos.tec.linutronix.de>



> On Aug 20, 2018, at 12:30 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> 
> On Sun, 19 Aug 2018, Andy Lutomirski wrote:
>>> On Aug 19, 2018, at 4:08 PM, Rian Hunter <rian@alum.mit.edu> wrote:
>>> 
>>> Commit e634d8fc792c ("x86-64: merge the standard and compat
>>> start_thread() functions") removed exporting for the start_thread()
>>> function in what seems like a typo. Add it back to
>>> arch/x86/kernel/process_64.c for parity with process_32.c and other
>>> arch.
>> 
>> What for?  Perhaps 32-bit could remove it instead?
> 
> No. start_thread() is called from various binfmt implementations which can
> be built as modules.

Fair enough. I’m fine with the patch.

> 
> Thanks,
> 
>    tglx

  reply	other threads:[~2018-08-20 14:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-19 23:08 [PATCH] x86/process: Export start_thread() Rian Hunter
2018-08-20  2:29 ` Andy Lutomirski
2018-08-20  4:34   ` Rian Hunter
2018-08-20  7:30   ` Thomas Gleixner
2018-08-20 14:27     ` Andy Lutomirski [this message]
2018-08-20 16:11 ` [tip:x86/urgent] x86/process: Re-export start_thread() tip-bot for Rian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D2852E34-BC10-4161-A05D-981E3A3D4098@amacapital.net \
    --to=luto@amacapital.net \
    --cc=bpetkov@suse.de \
    --cc=dima@arista.com \
    --cc=hpa@zytor.com \
    --cc=jpoimboe@redhat.com \
    --cc=jroedel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=rian@alum.mit.edu \
    --cc=tglx@linutronix.de \
    --cc=vkuznets@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.