From: "Verma, Vishal L" <vishal.l.verma@intel.com> To: Alexey Khoroshilov <khoroshilov@ispras.ru>, Ross Zwisler <ross.zwisler@linux.intel.com> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>, "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>, "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "ldv-project@linuxtesting.org" <ldv-project@linuxtesting.org> Subject: Re: [PATCH] nfit: acpi_nfit_notify(): Do not leave device locked Date: Fri, 11 Dec 2015 22:01:48 +0000 [thread overview] Message-ID: <D2909598.28AEA%vishal.l.verma@intel.com> (raw) In-Reply-To: <1449865450-8145-1-git-send-email-khoroshilov@ispras.ru> On 12/11/15, 13:24, "Alexey Khoroshilov" <khoroshilov@ispras.ru> wrote: >Even if dev->driver is null because we are being removed, >it is safer to not leave device locked. > >Found by Linux Driver Verification project (linuxtesting.org). > >Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> >--- > drivers/acpi/nfit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks good, thanks! Reviewed-by: Vishal Verma <vishal.l.verma@intel.com> > >diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c >index e7ed39bab97d..aa45d4802707 100644 >--- a/drivers/acpi/nfit.c >+++ b/drivers/acpi/nfit.c >@@ -1810,7 +1810,7 @@ static void acpi_nfit_notify(struct acpi_device >*adev, u32 event) > if (!dev->driver) { > /* dev->driver may be null if we're being removed */ > dev_dbg(dev, "%s: no driver found for dev\n", __func__); >- return; >+ goto out_unlock; > } > > if (!acpi_desc) { >-- >1.9.1 > >
WARNING: multiple messages have this Message-ID (diff)
From: "Verma, Vishal L" <vishal.l.verma@intel.com> To: Alexey Khoroshilov <khoroshilov@ispras.ru>, Ross Zwisler <ross.zwisler@linux.intel.com> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>, "linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>, "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "ldv-project@linuxtesting.org" <ldv-project@linuxtesting.org> Subject: Re: [PATCH] nfit: acpi_nfit_notify(): Do not leave device locked Date: Fri, 11 Dec 2015 22:01:48 +0000 [thread overview] Message-ID: <D2909598.28AEA%vishal.l.verma@intel.com> (raw) In-Reply-To: <1449865450-8145-1-git-send-email-khoroshilov@ispras.ru> On 12/11/15, 13:24, "Alexey Khoroshilov" <khoroshilov@ispras.ru> wrote: >Even if dev->driver is null because we are being removed, >it is safer to not leave device locked. > >Found by Linux Driver Verification project (linuxtesting.org). > >Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> >--- > drivers/acpi/nfit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks good, thanks! Reviewed-by: Vishal Verma <vishal.l.verma@intel.com> > >diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c >index e7ed39bab97d..aa45d4802707 100644 >--- a/drivers/acpi/nfit.c >+++ b/drivers/acpi/nfit.c >@@ -1810,7 +1810,7 @@ static void acpi_nfit_notify(struct acpi_device >*adev, u32 event) > if (!dev->driver) { > /* dev->driver may be null if we're being removed */ > dev_dbg(dev, "%s: no driver found for dev\n", __func__); >- return; >+ goto out_unlock; > } > > if (!acpi_desc) { >-- >1.9.1 > >
next prev parent reply other threads:[~2015-12-11 22:01 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-11 20:24 [PATCH] nfit: acpi_nfit_notify(): Do not leave device locked Alexey Khoroshilov 2015-12-11 20:24 ` Alexey Khoroshilov 2015-12-11 21:53 ` Ross Zwisler 2015-12-11 21:53 ` Ross Zwisler 2015-12-11 22:01 ` Verma, Vishal L [this message] 2015-12-11 22:01 ` Verma, Vishal L
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=D2909598.28AEA%vishal.l.verma@intel.com \ --to=vishal.l.verma@intel.com \ --cc=khoroshilov@ispras.ru \ --cc=ldv-project@linuxtesting.org \ --cc=lenb@kernel.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=rjw@rjwysocki.net \ --cc=ross.zwisler@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.