All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Barros Pena, Belen" <belen.barros.pena@intel.com>
To: "toaster@yoctoproject.org" <toaster@yoctoproject.org>
Cc: "Purdie, Richard" <richard.purdie@intel.com>,
	"Bartosh, Eduard" <eduard.bartosh@intel.com>
Subject: FW: [OE-core] [PATCH 6/7] toaster: Update for buildstats changes
Date: Fri, 18 Dec 2015 09:21:16 +0000	[thread overview]
Message-ID: <D2997F47.6D98C%belen.barros.pena@intel.com> (raw)
In-Reply-To: <1450364093.13505.210.camel@linuxfoundation.org>

I applied the buildstats series on top of toaster-next, ran a build, and
checked the build stats info. I can see time per task coming in. I cannot
see cpu usage or disk i/o data in the UI because of this

https://bugzilla.yoctoproject.org/show_bug.cgi?id=8571

But there is data for both in the database, and it looks sane. So I guess,
from the UI standpoint, the patches are ok: things were as broken as they
were before ;)

Cheers

Belén

On 17/12/2015 14:54, "openembedded-core-bounces@lists.openembedded.org on
behalf of Richard Purdie"
<openembedded-core-bounces@lists.openembedded.org on behalf of
richard.purdie@linuxfoundation.org> wrote:


>This updates the toaster class to use the new data format from buildstats.
>This does mean it will no longer read IO data from older builds, however
>since that data is completely useless anyway, I don't consider that to be
>an issue.
>
>Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>
>diff --git a/meta/classes/toaster.bbclass b/meta/classes/toaster.bbclass
>index d63cff5..7af495e 100644
>--- a/meta/classes/toaster.bbclass
>+++ b/meta/classes/toaster.bbclass
>@@ -199,8 +199,6 @@ python toaster_collect_task_stats() {
>     def _read_stats(filename):
>         cpu_usage = 0
>         disk_io = 0
>-        startio = '0'
>-        endio = '0'
>         started = '0'
>         ended = '0'
>         pn = ''
>@@ -215,11 +213,11 @@ python toaster_collect_task_stats() {
>         if "CPU usage" in statinfo:
>             cpu_usage = str(statinfo["CPU usage"]).strip('% \n\r')
> 
>-        if "EndTimeIO" in statinfo:
>-            endio = str(statinfo["EndTimeIO"]).strip('% \n\r')
>+        if "IO write_bytes" in statinfo:
>+            disk_io = disk_io + str(statinfo["IO write_bytes"]).strip('%
>\n\r')
> 
>-        if "StartTimeIO" in statinfo:
>-            startio = str(statinfo["StartTimeIO"]).strip('% \n\r')
>+        if "IO read_bytes" in statinfo:
>+            disk_io = disk_io + str(statinfo["IO read_bytes"]).strip('%
>\n\r')
> 
>         if "Started" in statinfo:
>             started = str(statinfo["Started"]).strip('% \n\r')
>@@ -227,8 +225,6 @@ python toaster_collect_task_stats() {
>         if "Ended" in statinfo:
>             ended = str(statinfo["Ended"]).strip('% \n\r')
> 
>-        disk_io = int(endio) - int(startio)
>-
>         elapsed_time = float(ended) - float(started)
> 
>         cpu_usage = float(cpu_usage)
>
>
>-- 
>_______________________________________________
>Openembedded-core mailing list
>Openembedded-core@lists.openembedded.org
>http://lists.openembedded.org/mailman/listinfo/openembedded-core



  reply	other threads:[~2015-12-18  9:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17 14:54 [PATCH 6/7] toaster: Update for buildstats changes Richard Purdie
2015-12-18  9:21 ` Barros Pena, Belen [this message]
2015-12-18 10:56   ` FW: [OE-core] " Richard Purdie
2015-12-18 10:56     ` [Toaster] FW: " Richard Purdie
2015-12-18 10:56   ` FW: [OE-core] " Richard Purdie
2015-12-18 10:56     ` [Toaster] FW: " Richard Purdie
2015-12-21 11:34     ` FW: [OE-core] " Barros Pena, Belen
2015-12-21 11:34       ` [Toaster] FW: " Barros Pena, Belen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D2997F47.6D98C%belen.barros.pena@intel.com \
    --to=belen.barros.pena@intel.com \
    --cc=eduard.bartosh@intel.com \
    --cc=richard.purdie@intel.com \
    --cc=toaster@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.