All of lore.kernel.org
 help / color / mirror / Atom feed
From: Federico Fuga <fuga@studiofuga.com>
To: Gregory CLEMENT <gregory.clement@bootlin.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: mv64xxx: Implement I2C_M_RECV_LEN and I2C_FUNC_SMBUS_READ_BLOCK_DATA
Date: Fri, 13 Mar 2020 21:58:03 +0100	[thread overview]
Message-ID: <D320E497-D240-4821-99F7-D0BE8744D3EF@studiofuga.com> (raw)
In-Reply-To: <87k13ox9q1.fsf@FE-laptop>

Hello all,



> Il giorno 13 mar 2020, alle ore 21:48, Gregory CLEMENT <gregory.clement@bootlin.com> ha scritto:
> 
> Hello Wolfram,
> 
>> On Sat, Jan 18, 2020 at 12:58:20PM +0100, Federico Fuga wrote:
>>> The i2c_mv64xxx driver doesn't implement the I2C_M_REC_LEN function
>>> essential to allow blocks with variable length to be read from an i2c
>>> slave.
>>> This is needed to implement the SMBus Read Block Data function.
>>> 
>>> This patch implements the function by changing the bytes_left and
>>> msg len on the fly if the flag is specified.
>>> 
>>> It has been successfully tested on Allwinner A33 with a special
>>> i2c chip that returns variable length blocks on reading.
>>> 
>>> Signed-off-by: Federico Fuga <fuga@studiofuga.com>
>>> ---
>> 
>> Gregory, any comment? I can't say much about the implementation. In
>> general, this is a nice feature to have...
> 
> I thought I was already sent a reviewed by, as I reviewed this patch
> before Frederico actually sent it.
> 
> So you can even add a
> 
> Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>
> 
> Thanks,


For what it worth, I can confirm that after many weeks of use the patch works as expected without any issue.


Federico






  reply	other threads:[~2020-03-13 21:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-18 11:58 [PATCH] i2c: mv64xxx: Implement I2C_M_RECV_LEN and I2C_FUNC_SMBUS_READ_BLOCK_DATA Federico Fuga
2020-01-18 11:58 ` Federico Fuga
2020-02-22 12:48 ` Wolfram Sang
2020-03-13 20:48   ` Gregory CLEMENT
2020-03-13 20:58     ` Federico Fuga [this message]
2020-03-20 14:55 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D320E497-D240-4821-99F7-D0BE8744D3EF@studiofuga.com \
    --to=fuga@studiofuga.com \
    --cc=gregory.clement@bootlin.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.