Re: [master][PATCH] python3-inotify: add ptest -> v2 please

["Qiu, Zheng" <Zheng.Qiu@windriver.com>]

[-- Attachment #1: Type: text/plain, Size: 2816 bytes --]


On Nov 25, 2022, at 4:43 PM, MacLeod, Randy <Randy.MacLeod@windriver.com> wrote:

On 2022-11-25 14:55, Qiu, Zheng wrote:

+
+SRCREV = "f77596ae965e47124f38d7bd6587365924dcd8f7"
This is the current head, which is fine but add a note in the  long log
about that choice. It's
$ git log --oneline 0.2.10... | wc -l

14

commits ahead of 0.2.10

Will change it to the head of 0.2.10

Hmmm, here are the commits, most of which don't affect runtime:

$ git log --oneline 0.2.10...
f77596a (HEAD -> master, origin/master, origin/HEAD) Add Dockerfile
9be6a51 Fix constant in adapter to match with DELETE events
  ^^^^^-------- seems like a bug fix that we should pick up. <<----
269d541 etup.cfg: Add missing newline
8e79335 tests/test_inotify.py: Canonicalize import
f844ea2 Added setup.cfg option to make bdist_wheel create
       a universal wheel.
53fd4ea Increase test coverage of Inotify initializer (#76)
0d802dc Update README.rst
f0d5b98 Update README.rst
9075acc Fix for issue #66, removing 'nose' as a production requirement.
82d1439 .travis.yml: Use 4.x version of coverage package
ebffda0 .travis.yml: Drop 3.3 support. Add 3.6, 3.7, 3.8
983049a .gitignore: Add ignore
cd7b276 requirements.txt: Remove nose from requirements
7202fc4 Propagate superficial parameter to remove_watch_with_id


Here's that one, reformatted, patch:

commit 9be6a51d1660991562eefaaddefa757ca0e0e00f
Author: Raphaël Beamonte <raphael.beamonte@gmail.com>
Date:   Sun Jul 29 01:24:52 2018

   Fix constant in adapter to match with DELETE events

   The previous behavior was duplicating a block of code and making
   one of the two useless. This fixes that by replacing the constant to
   IN_DELETE instead of IN_MOVED_FROM in one of the two blocks.

   Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>

diff --git a/inotify/adapters.py b/inotify/adapters.py
index 7f3f708..e8301da 100644
--- a/inotify/adapters.py
+++ b/inotify/adapters.py
@@ -299,7 +299,7 @@ class _BaseTree(object):

                 self._i.add_watch(full_path, self._mask)

-             if header.mask & inotify.constants.IN_MOVED_FROM:
+             if header.mask & inotify.constants.IN_DELETE:
                 _LOGGER.debug("A directory has been removed. We're "
                               "being recursive, but it would have "
                               "automatically been deregistered: [%s]",



What's the impact to users of not having this fix?
It seems like a bug fix that we should pick up by backport of
user _git and HEAD.

I will submit another patch for this…because I am worried about if some commit in between will produce further bugs.
This package seems like have very limited support right now.



--
# Randy MacLeod
# Wind River Linux



[-- Attachment #2: Type: text/html, Size: 5290 bytes --]