From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95564C433EF for ; Thu, 7 Apr 2022 06:15:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 257688D0001; Thu, 7 Apr 2022 02:15:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 206536B0074; Thu, 7 Apr 2022 02:15:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CFFC8D0001; Thu, 7 Apr 2022 02:15:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0001.hostedemail.com [216.40.44.1]) by kanga.kvack.org (Postfix) with ESMTP id F38666B0073 for ; Thu, 7 Apr 2022 02:15:01 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A59001839261F for ; Thu, 7 Apr 2022 06:14:51 +0000 (UTC) X-FDA: 79329069582.24.D0CD7AF Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) by imf08.hostedemail.com (Postfix) with ESMTP id 09073160006 for ; Thu, 7 Apr 2022 06:14:50 +0000 (UTC) Received: by mail-il1-f170.google.com with SMTP id x9so3531134ilc.3 for ; Wed, 06 Apr 2022 23:14:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=DEcDvF/0jxfViIE343xN6cCnES7hC3rxvptoIwd8q3w=; b=nm5+WrNzEZYnk5pRuMOQ70GODR0QhDJ8ZoqBSmslokrf/XHoOrXfqYxoPJ/8s0/DD9 NPLmexZOr7a1N9V5pXT9Yhymyga3lsrsv5Gp9R37fgd1xRruFOILs5SnOiWWGCCRseFO 0qJ3AJJwNIzlL7gKb0taT5htTt30h87zJ8ID66E9+EKObTy6veg6bN8ZgKL4TfOVv+xS pql9V7gMofmQxLSSKruaixF18d09wCp5LqxUDTWVjcQ4KOZ+IBLflUNqlvQOYSueSuPm 7YuNELbadsW+R2H9Wm0uzopGpGfHC8d4hQ6Slj17wxjCG15+ZPDiOE9dHp9XxUGrZKQA xjhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=DEcDvF/0jxfViIE343xN6cCnES7hC3rxvptoIwd8q3w=; b=nObJfE39ZizyabQM2254LMnqEAkmBPD9/C/JZApxj01jzATJrvQdXXzeznYXfAWqnO lrFYlJUQRoYOZ6bfwSdfxVEQrAzPwDGk+vb9ADR76JRobguWtvV2RLvHRk92V475LcnK mBshBRKFVx1yVK7GhTXtEdsOBp1Qrr/7z31EZkVyGCOCVElX5MSNqGc/mnOLZjmLmaF+ bQe95xln/7KkZY55ccs9PGnMzqhBIDm7pdHmyyDldwrnmL0LHf18ez6jTyV7PXNzgcPg 6OppaP6rQ0p1EKNKTKR8x1Tlklxqwa8JJmHEIA+MyNFun4NN3ShcQ6GbZbRzkY+4kslx a3Sg== X-Gm-Message-State: AOAM533y2IVIRH5AkmUKKdxYeTMJ4F13dX7PNf5a0y/VYliITnhnNVj1 jFIF1vSnIe5ifzsaCyc5KmA= X-Google-Smtp-Source: ABdhPJxsCB0F975sUAxHN8h8FW7Y8/+4wO+g7Yg53Njm7cxRUTU0/XDrk+BeIt95cc7RLnBd07gk1g== X-Received: by 2002:a05:6e02:168b:b0:2ca:36a1:489a with SMTP id f11-20020a056e02168b00b002ca36a1489amr5952403ila.49.1649312090243; Wed, 06 Apr 2022 23:14:50 -0700 (PDT) Received: from smtpclient.apple ([2601:285:8200:efd:1c82:59d7:d4dd:8c37]) by smtp.gmail.com with ESMTPSA id c2-20020a92dc82000000b002c9b0f25e62sm10655466iln.60.2022.04.06.23.14.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Apr 2022 23:14:49 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.1\)) Subject: Re: [PATCH 0/4] Alternative fixes for migration From: William Kucharski In-Reply-To: <20220404193006.1429250-1-willy@infradead.org> Date: Thu, 7 Apr 2022 00:14:48 -0600 Cc: linux-mm@kvack.org, Andrew Morton , Zi Yan Content-Transfer-Encoding: quoted-printable Message-Id: References: <20220404193006.1429250-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" X-Mailer: Apple Mail (2.3696.100.1) X-Stat-Signature: 6ooyb7qrcyixg9ar1qeouawsueh7i1we Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nm5+WrNz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of kucharsk@gmail.com designates 209.85.166.170 as permitted sender) smtp.mailfrom=kucharsk@gmail.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 09073160006 X-HE-Tag: 1649312090-809166 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: For the series: Reviewed-by: William Kucharski > On Apr 4, 2022, at 1:30 PM, Matthew Wilcox (Oracle) = wrote: >=20 > I heartily endorse Zi Yan's minimal fixes. These patches, drawn from > my development tree and with absolutely no testing, are a different > approach to fixing the problem. I would have submitted these patches > earlier if I'd known they were needed. >=20 > I think migrate_misplaced_transhuge_page() may be missing from Zi's > patch, but maybe filesystem pages can't end up in that path? Anyway, > let me know if you like these patches better. >=20 > Matthew Wilcox (Oracle) (4): > mm/migrate: Use a folio in alloc_migration_target() > mm/migrate: Use a folio in migrate_misplaced_transhuge_page() > mm: Add vma_alloc_folio() > mm/mempolicy: Use vma_alloc_folio() in new_page() >=20 > include/linux/gfp.h | 8 +++-- > mm/mempolicy.c | 38 +++++++++++++-------- > mm/migrate.c | 80 +++++++++++++++------------------------------ > 3 files changed, 56 insertions(+), 70 deletions(-) >=20 > --=20 > 2.34.1 >=20 >=20