From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753343AbcAQCbF (ORCPT ); Sat, 16 Jan 2016 21:31:05 -0500 Received: from mail-pf0-f174.google.com ([209.85.192.174]:35849 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753284AbcAQCbD (ORCPT ); Sat, 16 Jan 2016 21:31:03 -0500 Subject: Re: [Y2038] [RFC 02/15] vfs: Change all structures to support 64 bit time Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Content-Type: multipart/signed; boundary="Apple-Mail=_5986A358-E022-4044-86E1-CD7AA3EFF1C3"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Pgp-Agent: GPGMail 2.5.2 From: Andreas Dilger In-Reply-To: <6591497.mpSR1PpHzG@wuerfel> Date: Sat, 16 Jan 2016 19:30:55 -0700 Cc: y2038@lists.linaro.org, Dave Chinner , linux-fsdevel@vger.kernel.org, Deepa Dinamani , linux-kernel@vger.kernel.org Message-Id: References: <1452144972-15802-1-git-send-email-deepa.kernel@gmail.com> <4756197.dta9JQvfZs@wuerfel> <6591497.mpSR1PpHzG@wuerfel> To: Arnd Bergmann X-Mailer: Apple Mail (2.2104) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Apple-Mail=_5986A358-E022-4044-86E1-CD7AA3EFF1C3 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On Jan 16, 2016, at 4:36 PM, Arnd Bergmann wrote: > > On Saturday 16 January 2016 12:14:22 Andreas Dilger wrote: >>>> >>>> Sure, and nfs is a pain because of all it's internal use of >>>> timespecs, too. >>> >>> lustre is probably the worst. >> >> Lustre currently only has one-second granularity in a 64-bit field, >> so it doesn't really care about the difference between timespec or >> timespec64 at all. >> >> The only other uses are for measuring relative times, so the 64-bitness >> shouldn't really matter. >> >> Could you please point out what issues exist so they can be fixed. > > It's not really a bug that needs to be fixed, but more the general > issue of referencing inode->i_?time and attr->ia_?time and passing > them around. When we change the types in the inode and iattr from > timespec to timespec64, all assigments need to be modified, and lustre > has more of those assignments than any other file system I'm aware of. All of those accesses are with the LTIME_S() macro to get/set only the seconds field of the inode time, so it should only be a one-line patch? Cheers, Andreas --Apple-Mail=_5986A358-E022-4044-86E1-CD7AA3EFF1C3 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iQIVAwUBVpr84HKl2rkXzB/gAQiPeA/+MuKKEEP+XoTuLShKUXxlL7gjL5QOZoXL koOVxLuiPqYbOJ39bscwcE6RDBlJhUb2uAldfY88sxfhpfGe7m9CCha4Fi9W/K1M 9Btx45RIkLWOjlq6t1yHV6z4PzZcVE8nIXqn+VxUWDomO04k8DdOtiE5NDSPq6nx /YWipJTcfM/BBUo1Tijr0keXNyTMqcbWVtT/fJTg0Tcxxb1I1TY6sqnVLXz0daHH V2dnaPJYq4d++oy6klC4AmRwD/UNQdykXbLZBhvq1XfQVR2jMTWKLm0Ezz3lghHR N90oPfUvS/g0zS9Q2VdJ5r6hXzqX00bP3P7lsQwMubXwordTa4iTtp/KM+RkTH5b TgYfHE1VtcUTofuvyIy4YQ/EizNKFw+iCBgBa7pkk9JPQRJRyjRXMeVFRXaP1yVE 78JQmmwNVqQi/xVo6v7IVPEqyQrbilPIsnXKx1pizo4w3q7jivIj9qlidVuy2hpv nfRKnay3xpZfn2O4KHc/FZmpTFfiC+49ORaRq8vuU4zAY0smaK+QNBjtLxsureyQ KSQzLuzY24BR00AlssduguYqHR/bJjs9n/2+GJ/q3BFafijUqXjLMiemLO3cNGVA lnbVyKYdWcNeTpBMdELitesXFNHqRzh5BMW6xdvCfcLen1rM956nxpiklI744I2Q R1UDBOnl6ds= =mNTz -----END PGP SIGNATURE----- --Apple-Mail=_5986A358-E022-4044-86E1-CD7AA3EFF1C3--