From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjmH1-00037n-B7 for qemu-devel@nongnu.org; Tue, 13 Sep 2016 07:53:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjmGv-0002Yt-IM for qemu-devel@nongnu.org; Tue, 13 Sep 2016 07:53:10 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:32391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjmGv-0002Xx-6R for qemu-devel@nongnu.org; Tue, 13 Sep 2016 07:53:05 -0400 From: Ola Liljedahl Date: Tue, 13 Sep 2016 11:52:58 +0000 Message-ID: References: <1473738741-220600-1-git-send-email-arei.gonglei@huawei.com> <1473738741-220600-3-git-send-email-arei.gonglei@huawei.com> <20160913092050.GD30949@redhat.com> <8cfc0ce6-babb-6115-f64d-4f17074ae8f7@redhat.com> In-Reply-To: <8cfc0ce6-babb-6115-f64d-4f17074ae8f7@redhat.com> Content-Language: en-US Content-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [virtio-dev] Re: [PATCH v2 02/15] crypto: introduce crypto queue handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , "Daniel P. Berrange" , Gonglei Cc: "qemu-devel@nongnu.org" , "virtio-dev@lists.oasis-open.org" , "peter.huangpeng@huawei.com" , "luonengjun@huawei.com" , "mst@redhat.com" , "stefanha@redhat.com" , "weidong.huang@huawei.com" , "mike.caraman@nxp.com" , "agraf@suse.de" , "xin.zeng@intel.com" , "claudio.fontana@huawei.com" , "nmorey@kalray.eu" , "vincent.jardin@6wind.com" On 13/09/2016, 12:58, "virtio-dev@lists.oasis-open.org on behalf of Paolo Bonzini" wrote: > > >On 13/09/2016 11:20, Daniel P. Berrange wrote: >>> > +typedef struct CryptoPacket CryptoPacket; >>> > +typedef struct CryptoQueue CryptoQueue; >>> > +typedef struct CryptoPacketBuf CryptoPacketBuf; >>> > + >>> > +typedef void (CryptoPacketSent) (CryptoClientState *, int); >> As previously, I'd expect naming of >> >> QCryptoCryptodevPacket >> QCryptoCryptodevPacketBuf >> QCryptoCryptodevQueue >> > >Gonglei, > >you are copying a lot of code from network backends. > >I am not sure why you would need a queue for virtio-crypto rather than a >direct connection between frontend and backend (and the backend would be >QEMU crypto APIs, like Daniel suggested). What about backends implemented directly in HW? Bypass the middle man. Make crypto offload meaningful for small size blocks. =8B Ola > >Paolo > >--------------------------------------------------------------------- >To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org >For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.