From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bk5Ua-0000FS-0I for qemu-devel@nongnu.org; Wed, 14 Sep 2016 04:24:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bk5UV-00041C-VZ for qemu-devel@nongnu.org; Wed, 14 Sep 2016 04:24:27 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([207.82.80.143]:50530) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bk5UV-00040Q-Ia for qemu-devel@nongnu.org; Wed, 14 Sep 2016 04:24:23 -0400 From: Ola Liljedahl Date: Wed, 14 Sep 2016 08:24:18 +0000 Message-ID: References: <1473738741-220600-1-git-send-email-arei.gonglei@huawei.com> <1473738741-220600-3-git-send-email-arei.gonglei@huawei.com> <20160913092050.GD30949@redhat.com> <8cfc0ce6-babb-6115-f64d-4f17074ae8f7@redhat.com> <33183CC9F5247A488A2544077AF19020B03CABA9@SZXEMA503-MBS.china.huawei.com> In-Reply-To: <33183CC9F5247A488A2544077AF19020B03CABA9@SZXEMA503-MBS.china.huawei.com> Content-Language: en-US Content-ID: <92F9F88C7D99E44FA101CF815821332A@eurprd08.prod.outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [virtio-dev] Re: [PATCH v2 02/15] crypto: introduce crypto queue handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" , Paolo Bonzini , "Daniel P. Berrange" Cc: "qemu-devel@nongnu.org" , "virtio-dev@lists.oasis-open.org" , "Huangpeng (Peter)" , Luonengjun , "mst@redhat.com" , "stefanha@redhat.com" , "Huangweidong (C)" , "mike.caraman@nxp.com" , "agraf@suse.de" , "xin.zeng@intel.com" , Claudio Fontana , "nmorey@kalray.eu" , "vincent.jardin@6wind.com" On 14/09/2016, 03:07, "Gonglei (Arei)" wrote: >Hi Ola, > > > >> -----Original Message----- >> From: Ola Liljedahl [mailto:Ola.Liljedahl@arm.com] >> Sent: Tuesday, September 13, 2016 7:53 PM >> To: Paolo Bonzini; Daniel P. Berrange; Gonglei (Arei) >> Cc: qemu-devel@nongnu.org; virtio-dev@lists.oasis-open.org; Huangpeng >> (Peter); Luonengjun; mst@redhat.com; stefanha@redhat.com; Huangweidong >> (C); mike.caraman@nxp.com; agraf@suse.de; xin.zeng@intel.com; Claudio >> Fontana; nmorey@kalray.eu; vincent.jardin@6wind.com >> Subject: Re: [virtio-dev] Re: [PATCH v2 02/15] crypto: introduce crypto >>queue >> handler >> >> >> >> >> >> On 13/09/2016, 12:58, "virtio-dev@lists.oasis-open.org on behalf of >>Paolo >> Bonzini" > pbonzini@redhat.com> wrote: >> >> > >> > >> >On 13/09/2016 11:20, Daniel P. Berrange wrote: >> >>> > +typedef struct CryptoPacket CryptoPacket; >> >>> > +typedef struct CryptoQueue CryptoQueue; >> >>> > +typedef struct CryptoPacketBuf CryptoPacketBuf; >> >>> > + >> >>> > +typedef void (CryptoPacketSent) (CryptoClientState *, int); >> >> As previously, I'd expect naming of >> >> >> >> QCryptoCryptodevPacket >> >> QCryptoCryptodevPacketBuf >> >> QCryptoCryptodevQueue >> >> >> > >> >Gonglei, >> > >> >you are copying a lot of code from network backends. >> > >> >I am not sure why you would need a queue for virtio-crypto rather than >>a >> >direct connection between frontend and backend (and the backend would >>be >> >QEMU crypto APIs, like Daniel suggested). >> >> What about backends implemented directly in HW? Bypass the middle man. >> Make crypto offload meaningful for small size blocks. >> >As I said in other reply, I only provide interfaces, you can realize them >according >to different backend cryptodevs. Interfaces imposes contraints on performance and implementation. A poor interface could make certain implementations unnecessarily difficult. Since these virtio-* interfaces will live for a long time, we should ensure that they do not impose unnecessary constraints. For functionality like crypto and IPsec, I can see the benefit of implementing the backend in HW (for the datapath). > >Regards, >-Gonglei > >> < Ola >> >> > >> >Paolo >> > >> >--------------------------------------------------------------------- >> >To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org >> >For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org >> > >> >> IMPORTANT NOTICE: The contents of this email and any attachments are >> confidential and may also be privileged. If you are not the intended >>recipient, >> please notify the sender immediately and do not disclose the contents >>to any >> other person, use it for any purpose, or store or copy the information >>in any >> medium. Thank you. > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.