From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mail.openembedded.org (Postfix) with ESMTP id 580BD73695 for ; Thu, 15 Sep 2016 06:38:32 +0000 (UTC) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP; 14 Sep 2016 23:38:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,338,1470726000"; d="scan'208,217";a="8584202" Received: from lvernat-mobl7.ger.corp.intel.com (HELO [10.252.23.81]) ([10.252.23.81]) by fmsmga005.fm.intel.com with ESMTP; 14 Sep 2016 23:38:31 -0700 User-Agent: Microsoft-MacOutlook/14.6.7.160722 Date: Thu, 15 Sep 2016 09:38:31 +0300 From: Markus Lehtonen To: "Burton, Ross" Message-ID: Thread-Topic: [OE-core] [PATCH] scripts: introduce buildstats-diff References: <1473852282-12088-1-git-send-email-markus.lehtonen@linux.intel.com> In-Reply-To: Mime-version: 1.0 Cc: OE-core Subject: Re: [PATCH] scripts: introduce buildstats-diff X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2016 06:38:33 -0000 Content-type: multipart/alternative; boundary="B_3556777116_22425659" --B_3556777116_22425659 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit From: "Burton, Ross" Date: Wednesday 14 September 2016 at 19:38 To: Markus Lehtonen Cc: OE-core Subject: Re: [OE-core] [PATCH] scripts: introduce buildstats-diff On 14 September 2016 at 12:24, Markus Lehtonen wrote: > + if not tasks1: > + pkg_op = '++' > + elif not tasks2: > + pkg_op = '--' BTW, I've been reading buildstats-diff output all day and find the lack of whitespace between the operator and the package name makes the output harder to read, so I've patched it locally to be just '+ ' or '- ' for clarity. Sounds fine to me. I don't object your modification. - Markus --B_3556777116_22425659 Content-type: text/html; charset="US-ASCII" Content-transfer-encoding: quoted-printable

From: "Burton, Ross" <ross.burton@intel.com>
Date: <= /span> Wednesday 14 September 2016 at 19:38
To: Markus Lehtonen <markus.lehtonen@linux.intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] scripts: introduce = buildstats-diff


On 14 September 2016 at 12:24, Markus Lehto= nen <markus.lehtonen@linux.intel.com> wrote:
+&nbs= p;       if not tasks1:
+            pkg_op =3D '++'
+        elif not tasks2:
+            pkg_op =3D '--'
=

BTW, I've been reading buildstats-diff output all day and find the= lack of whitespace between the operator and the package name makes the outp= ut harder to read, so I've patched it locally to be just '+ ' or '- ' for cl= arity.

Sounds fine to me. I don't obje= ct your modification.
  - Markus

 --B_3556777116_22425659--