[dpdk-dev] 答复: [PATCH v2 12/17] net/hinic: set link down and up - Wangxiaoyun (Cloud, Network Chip Application Development Dept)

From: "Wangxiaoyun (Cloud, Network Chip Application Development Dept)" <cloud.wangxiaoyun@huawei.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Luoxianjun <luoxianjun@huawei.com>,
	Tanya Brokhman <tanya.brokhman@huawei.com>,
	zhouguoyang <zhouguoyang@huawei.com>,
	"Wulike (Collin)" <wulike1@huawei.com>,
	"Xuanziyang (William)" <xuanziyang2@huawei.com>,
	Shahar Belkar <shahar.belkar@huawei.com>
Subject: [dpdk-dev] 答复: [PATCH v2 12/17] net/hinic: set link down and up
Date: Sat, 28 Sep 2019 08:59:24 +0000	[thread overview]
Message-ID: <D4754EB8F98E474A85C888484253F61CA0B00749@NKGEML515-MBS.china.huawei.com> (raw)
In-Reply-To: <9559f32e-2a6e-b786-4224-d65adc9df1a7@intel.com>

-----邮件原件-----
发件人: Ferruh Yigit [mailto:ferruh.yigit@intel.com] 
发送时间: 2019年9月27日 2:48
收件人: Wangxiaoyun (Cloud, Network Chip Application Development Dept)
抄送: dev@dpdk.org; Xuanziyang (William); Shahar Belkar; Luoxianjun; Tanya Brokhman; zhouguoyang; Wulike (Collin)
主题: Re: [PATCH v2 12/17] net/hinic: set link down and up

On 9/25/2019 3:30 PM, Xiaoyun wang wrote:
> This patch supports setting link down and up,
> Also adds support for geting firmware version.
> 
> Signed-off-by: Xiaoyun wang <cloud.wangxiaoyun@huawei.com>

<...>

> @@ -2751,9 +2832,12 @@ static void hinic_dev_close(struct rte_eth_dev *dev)
>  static const struct eth_dev_ops hinic_pmd_ops = {
>  	.dev_configure                 = hinic_dev_configure,
>  	.dev_infos_get                 = hinic_dev_infos_get,
> +	.fw_version_get                = hinic_fw_version_get,
>  	.rx_queue_setup                = hinic_rx_queue_setup,
>  	.tx_queue_setup                = hinic_tx_queue_setup,
>  	.dev_start                     = hinic_dev_start,
> +	.dev_set_link_up               = hinic_dev_set_link_up,
> +	.dev_set_link_down             = hinic_dev_set_link_down,
>  	.link_update                   = hinic_link_update,
>  	.rx_queue_release              = hinic_rx_queue_release,
>  	.tx_queue_release              = hinic_tx_queue_release,
> @@ -2785,6 +2869,7 @@ static void hinic_dev_close(struct rte_eth_dev *dev)
>  static const struct eth_dev_ops hinic_pmd_vf_ops = {
>  	.dev_configure                 = hinic_dev_configure,
>  	.dev_infos_get                 = hinic_dev_infos_get,
> +	.fw_version_get                = hinic_fw_version_get,
>  	.rx_queue_setup                = hinic_rx_queue_setup,
>  	.tx_queue_setup                = hinic_tx_queue_setup,
>  	.dev_start                     = hinic_dev_start,
> 

Patch is also updating fw version get support, can you please mention from it in
the commit log? Or separate the patch..

Hi, Ferruh,
	Thanks for your comments. I will separate this patch to 2 patches, one is "set link down and up" , the other is "get firmware version". 
And I will fix it by patch V3.

Best regards
Xiaoyun Wang